From patchwork Fri May 13 02:19:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 35753 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp91333pzb; Thu, 12 May 2022 19:20:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbpevHLR2q60owADh1ZdUgVYSNuFY+31Bswe9dpR5vNQXXkL/63dDi2GlwZOfrGHJ0ejIb X-Received: by 2002:a05:6402:1f0b:b0:427:b390:2020 with SMTP id b11-20020a0564021f0b00b00427b3902020mr37875440edb.70.1652408452657; Thu, 12 May 2022 19:20:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652408452; cv=none; d=google.com; s=arc-20160816; b=ahnJbi6Z/vlJkfLN8VTXv3QN93viA36nLNFMJFbFrHkXKrzEUiX1XiAfVYzbhNyIit gFzD+jC5aWb+fFj1vd64jmwesGo1kMhLZu6qJzNsBCh8V0RqlM6I7+O7TzqsBgVSSyPw Co0VcoVO22YPn2LCrS7x4ARLXRt3k4E8DaDQNgAAJ8Z1Hpfb3nDk+d5yW5nEM01uU2XZ ppP8bq1ag2CuYQcFTF37AAIDa6GCd45bkzBoEc0NTg4uS2bE3DIPAASBXK8juwCps6td 4z33L+xmTFmtH0gAFBRiyq/dPWMK2L7A9jjalg9k6SJK6ScSlHC5MaLksubP4UC1rw+D tuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:mime-version:message-id:date :to:from:delivered-to; bh=PEiBN4ssSKD1gT88WnUdJmKybbtVnD0xMa427RecpuE=; b=KlXL/+IdKDATwHq5ZEENWEtY0Sz7nCI/GomZY+0TccMXEzWL59Hsuzdu8UvNJvJfri nzHVP426pZoEzs2yJpcAyBYmTLt5Ghw0ag7jgxB2Gu7vRAkxen5yy+nTv8VXRL4RDcO2 cKK1iguSTuCO8KsqUshPKwBEsZrYLqN4m/VHTqAutNYfI6UfarIB+EJ5R3kqjVM/cjp/ wHnvkES/T7cUiJWt820dnTXGZ/ovjP6keKtimZtVKaJbdTwpuRYc87vO9eO5OdQIgEHv fykECAh4osxCAhXSN8AIjZdBgmAZTk5LKB8UM0eiM+RhJabQIeJWn85KFyK+IhzjsJA8 O6ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c16-20020a05640227d000b00425fcc5d236si1015508ede.53.2022.05.12.19.20.51; Thu, 12 May 2022 19:20:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95A9068B44F; Fri, 13 May 2022 05:20:48 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbg.qq.com (smtpbg138.qq.com [106.55.201.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4338268B2F6 for ; Fri, 13 May 2022 05:20:42 +0300 (EEST) X-QQ-mid: bizesmtp82t1652408368t9p7w7yo Received: from localhost ( [103.107.216.227]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 13 May 2022 10:19:27 +0800 (CST) X-QQ-SSF: 01100000002000Z0Z000B00A0000000 X-QQ-FEAT: QadFjRvMUN3SuFQw3fuJgDoV2l2EOLqSfLmOoKVcy1OiegfC4zCaWXUJeUtz5 APRJD9sZXBnRw2s772fLawJaWY9We4ykcM8fWGAgi5zIeq3tV3+bd0ioTiApLfSLjuF7n37 mg7WktrNZqmadUgk4FyKHn3+XwGw7rt9GH2giR5GoqEUAewVnWTLn2k6wgjCaPmqyeGCTCO 2sxkC1IPY+bdm8x7zQdsXaBSwJ4rBPVqTnSfalc+tHQAaPKzAbTyp45Ysn/eUSfS14ZmtWo wZC6aPOr3Hzpw2xj3xEbTmS+HvkKbFEEXOgTqBJkE745jn1s+m6vNOEY8= X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Fri, 13 May 2022 10:19:24 +0800 Message-Id: <20220513021924.64854-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgspam:qybgspam10 Subject: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: fix memleak in plot_freqs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ug95dHYaDdNa plot_freqs should free colors before return error when ff_get_video_buffer failed Signed-off-by: Steven Liu --- libavfilter/avf_showfreqs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c index 6dcff686b6..86a67c7328 100644 --- a/libavfilter/avf_showfreqs.c +++ b/libavfilter/avf_showfreqs.c @@ -421,8 +421,10 @@ static int plot_freqs(AVFilterLink *inlink, int64_t pts) return AVERROR(ENOMEM); out = ff_get_video_buffer(outlink, outlink->w, outlink->h); - if (!out) + if (!out) { + av_free(colors); return AVERROR(ENOMEM); + } for (n = 0; n < outlink->h; n++) memset(out->data[0] + out->linesize[0] * n, 0, outlink->w * 4);