| Message ID | 20220518155505.4912-1-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avformat/http: Remove always true non NULL check | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
diff --git a/libavformat/http.c b/libavformat/http.c index c8f3f4b6a3..81c3048934 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -692,8 +692,7 @@ static int http_open(URLContext *h, const char *uri, int flags, if (!s->uri) return AVERROR(ENOMEM); - if (options) - av_dict_copy(&s->chained_options, *options, 0); + av_dict_copy(&s->chained_options, *options, 0); if (s->headers) { int len = strlen(s->headers);
Coverity uses the logic of "Comparing options to null implies that options might be null." But ffurl_connect() checks for NULL already and uses &tmp_opts Helps: CID1374122 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavformat/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)