diff mbox series

[FFmpeg-devel] libavcodec/qsvenc_hevc: Use default value from MSDK to set bf.

Message ID 20220620090631.198807-1-wenbin.chen@intel.com
State Accepted
Commit afa20e6db82245807bd0bb181dd22e1b714972cc
Headers show
Series [FFmpeg-devel] libavcodec/qsvenc_hevc: Use default value from MSDK to set bf. | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Wenbin Chen June 20, 2022, 9:06 a.m. UTC
Change the default value of "bf" for hevc_qsv to -1. 8 isn't the best
choice so let MSDK to decide the number of b frames.

Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
 libavcodec/qsvenc_hevc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiang, Haihao June 25, 2022, 2:42 a.m. UTC | #1
On Mon, 2022-06-20 at 17:06 +0800, Wenbin Chen wrote:
> Change the default value of "bf" for hevc_qsv to -1. 8 isn't the best
> choice so let MSDK to decide the number of b frames.
> 
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
>  libavcodec/qsvenc_hevc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
> index da2bf457af..f6027f600b 100644
> --- a/libavcodec/qsvenc_hevc.c
> +++ b/libavcodec/qsvenc_hevc.c
> @@ -287,7 +287,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
>      { "refs",      "0"     },
>      // same as the x264 default
>      { "g",         "248"   },
> -    { "bf",        "8"     },
> +    { "bf",        "-1"    },
>      { "qmin",      "-1"    },
>      { "qmax",      "-1"    },
>      { "trellis",   "-1"    },

LGTM, will apply.

-Haihao
diff mbox series

Patch

diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
index da2bf457af..f6027f600b 100644
--- a/libavcodec/qsvenc_hevc.c
+++ b/libavcodec/qsvenc_hevc.c
@@ -287,7 +287,7 @@  static const FFCodecDefault qsv_enc_defaults[] = {
     { "refs",      "0"     },
     // same as the x264 default
     { "g",         "248"   },
-    { "bf",        "8"     },
+    { "bf",        "-1"    },
     { "qmin",      "-1"    },
     { "qmax",      "-1"    },
     { "trellis",   "-1"    },