From patchwork Tue Jun 21 06:46:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 36369 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1a22:b0:84:42e0:ad30 with SMTP id cj34csp2050919pzb; Mon, 20 Jun 2022 23:47:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uRsia62J8rEhQSbU0+3MJjO1UwNg7eXUKLVbQKZtOr2XVQnRbkk+wYhEPbE5NPb/tJmtUR X-Received: by 2002:a05:6402:3689:b0:435:95b0:edf2 with SMTP id ej9-20020a056402368900b0043595b0edf2mr2090769edb.279.1655794069966; Mon, 20 Jun 2022 23:47:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655794069; cv=none; d=google.com; s=arc-20160816; b=r8qQwBLpEKnPEktGp62n2OSMqgfL/vji1gUfDKHa9MlxCpoMyLMp+3Q2bTs1iC3skz SBk6eA0rIYH7ZTyHJwYjMPxx2L5cAomTb/WXiE2UpyymiubXyrTSDjkSRTzrMJdBDVSm uaUQI+v93V2Xymn+W6mScn/MAF+Xi66OOtNiVOkQumctQRZ9mBPmBrbEcR+clKuKag6A xYa1zXfaYAO6sgukw8dAd4EUmR32J9aQ8lcZ3I0cXwsgGbs8U7grOiUdDhHWds4LElRI lelQUiN5wTk55f922WcPSH2W2RioT+Jxd9Z1XFj6gFLmk8twyQS7y/4bE6ge2xdZHQBd pvpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=rAkgtQ2ZBYDZybG/f/jZi/iFuqsoSRA4PZbPA1MSVtQ=; b=POtlfzfwRQAzTEwKsUxjwr95ATHP4THFgd7981oFg/xfdaGJ3iA8XruU0J/+w3agzM coTbjs9u6jGDc5CU61dkit1HOzzHQEzFRsiDZOnqYSozvPEvMxwP3f3Ukz8vwWNqkFh1 NTt8jzIzZAErHg0SIHFCQUNA9XvRHrRZh4AIOCgDBSM1UBdf9Vl5D1VvV83WAhzMjZqZ OD2aj+XhA+H3jCAKwfYZT7XFKdheX9i84zVH8z7eJZa58dnHcV614QtGnw+NsLJPgciG VG1/xTi8qnvNz+gRUQfW/5zaJMx4eHEj2knyrqq8l9pSyGT6U3WgXWwn999UumQyxuEN q7+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=F6hJSwu2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ch16-20020a0564021bd000b00435817432fesi4697719edb.308.2022.06.20.23.47.49; Mon, 20 Jun 2022 23:47:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=F6hJSwu2; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF4FB68B687; Tue, 21 Jun 2022 09:46:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BAD668B66E for ; Tue, 21 Jun 2022 09:46:45 +0300 (EEST) Received: by mail-lj1-f175.google.com with SMTP id c30so14268263ljr.9 for ; Mon, 20 Jun 2022 23:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=cRUrgyOZT5G//cmFaQpGLw8Vhg8lE26rI3oOpsVnAzE=; b=F6hJSwu23xib2HWeA83UDPfrL/Hw3GS4pOIgoubhbQCdEAPy+7EwCnK6Y2VZMM30se nChrvYPOo5rbxtNY4+bSyP9Tg6k49cglBifFh9MKTGanJ0Jlca9UlC31f8QnPCmI53bM i9i5PmNUo8sVhChCscZtM3SNwzFq+hph++2rEHFt4A6c2O7AYTU1YpZwNY5sNO/D3ZGe 4pS7YjAwqz9uUU9QXGNqxI5JZToIoxtQjT7cnayQ47oiQB4VI106if32Hjyvx9w31i7w zTyDQU0dalmASWvO9kPUEltUxkpEANcNushvbCHXKYNvuToskKXO1ytej9g+5UkdOQ4K Ibmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cRUrgyOZT5G//cmFaQpGLw8Vhg8lE26rI3oOpsVnAzE=; b=T1YZSEQ3z4NzuHG1EpOjWa7HlM6KQhL7L0pEuOtGrWWNiqJb+Nazhm6mVr+XXdeD15 ssF/vJf9UK07Ew7xTiAD5DIj06ELwtvqtS2/rA1XtAWXnPazNat0guaK2hf9AvdFgDco XFwkLeDKBENxBRjh8MeNN6qCELyUtnb2xXP2WGkWM9ycUcjwVlWkWIhDGgpMNOyiOzqL BX/ss040QwWnvpO2y0fG4L1VGJRDE83h1QLH2+tYAPyVPakAwjgz3W+Kt50dDm/42fxK wL7OGce5faqGoXWckgkeeC+9UdGzP1hirxtQJ+jHIz3DxRi/6TNNMU1BWlJN3Yu7zGdv BrRw== X-Gm-Message-State: AJIora9oNI1R8+pzoBY5KWL0e5Kt/sC3EXcgU5oY6OJ7ohIBeq7B2XEF cGWjLA3OJVAsf7p0UPdYkaPo5I98Y1Y= X-Received: by 2002:a05:651c:2124:b0:255:847d:38ea with SMTP id a36-20020a05651c212400b00255847d38eamr13254098ljq.439.1655794004458; Mon, 20 Jun 2022 23:46:44 -0700 (PDT) Received: from localhost.localdomain (91-153-198-187.elisa-laajakaista.fi. [91.153.198.187]) by smtp.gmail.com with ESMTPSA id u18-20020a199212000000b0047255d211c7sm2046767lfd.246.2022.06.20.23.46.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 23:46:43 -0700 (PDT) From: =?utf-8?q?Jan_Ekstr=C3=B6m?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 Jun 2022 09:46:33 +0300 Message-Id: <20220621064634.16797-6-jeebjp@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220621064634.16797-1-jeebjp@gmail.com> References: <20220621064634.16797-1-jeebjp@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 5/6] avformat/movenc: utilize existing AC-3 parsing workflow for AC-3 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: NbGdSlvoXXJq From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/Makefile | 1 + libavformat/Makefile | 1 + libavformat/ac3_bitrate_tab.c | 22 ++++++++++++++ libavformat/movenc.c | 55 +++++++++++++++++------------------ 4 files changed, 51 insertions(+), 28 deletions(-) create mode 100644 libavformat/ac3_bitrate_tab.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 10697d31f7..7e0d278e3d 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1018,6 +1018,7 @@ STLIBOBJS-$(CONFIG_FLV_MUXER) += mpeg4audio_sample_rates.o STLIBOBJS-$(CONFIG_HLS_DEMUXER) += ac3_channel_layout_tab.o STLIBOBJS-$(CONFIG_MATROSKA_DEMUXER) += mpeg4audio_sample_rates.o STLIBOBJS-$(CONFIG_MOV_DEMUXER) += ac3_channel_layout_tab.o +STLIBOBJS-$(CONFIG_MOV_MUXER) += ac3_bitrate_tab.o STLIBOBJS-$(CONFIG_MXF_MUXER) += golomb.o STLIBOBJS-$(CONFIG_MP3_MUXER) += mpegaudiotabs.o STLIBOBJS-$(CONFIG_NUT_MUXER) += mpegaudiotabs.o diff --git a/libavformat/Makefile b/libavformat/Makefile index 1416bf31bd..c71de95b2f 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -699,6 +699,7 @@ SHLIBOBJS-$(CONFIG_FLV_MUXER) += mpeg4audio_sample_rates.o SHLIBOBJS-$(CONFIG_HLS_DEMUXER) += ac3_channel_layout_tab.o SHLIBOBJS-$(CONFIG_MATROSKA_DEMUXER) += mpeg4audio_sample_rates.o SHLIBOBJS-$(CONFIG_MOV_DEMUXER) += ac3_channel_layout_tab.o +SHLIBOBJS-$(CONFIG_MOV_MUXER) += ac3_bitrate_tab.o SHLIBOBJS-$(CONFIG_MP3_MUXER) += mpegaudiotabs.o SHLIBOBJS-$(CONFIG_MXF_MUXER) += golomb_tab.o SHLIBOBJS-$(CONFIG_NUT_MUXER) += mpegaudiotabs.o diff --git a/libavformat/ac3_bitrate_tab.c b/libavformat/ac3_bitrate_tab.c new file mode 100644 index 0000000000..57b6181511 --- /dev/null +++ b/libavformat/ac3_bitrate_tab.c @@ -0,0 +1,22 @@ +/* + * AC-3 bit rate table + * copyright (c) 2001 Fabrice Bellard + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "libavcodec/ac3_bitrate_tab.h" diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 103f958d75..a071f1cdd5 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -36,6 +36,7 @@ #include "av1.h" #include "avc.h" #include "libavcodec/ac3_parser_internal.h" +#include "libavcodec/ac3tab.h" #include "libavcodec/dnxhddata.h" #include "libavcodec/flac.h" #include "libavcodec/get_bits.h" @@ -362,44 +363,42 @@ struct eac3_info { static int mov_write_ac3_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *track) { - GetBitContext gbc; + struct eac3_info *info = track->eac3_priv; + int8_t ac3_bit_rate_code = -1; PutBitContext pbc; uint8_t buf[3]; - int fscod, bsid, bsmod, acmod, lfeon, frmsizecod; - if (track->vos_len < 7) { + if (!info || !info->ec3_done) { av_log(s, AV_LOG_ERROR, "Cannot write moov atom before AC3 packets." " Set the delay_moov flag to fix this.\n"); return AVERROR(EINVAL); } - avio_wb32(pb, 11); - ffio_wfourcc(pb, "dac3"); + for (unsigned int i = 0; i < FF_ARRAY_ELEMS(ff_ac3_bitrate_tab); i++) { + if (info->data_rate == ff_ac3_bitrate_tab[i]) { + ac3_bit_rate_code = i; + break; + } + } - init_get_bits(&gbc, track->vos_data + 4, (track->vos_len - 4) * 8); - fscod = get_bits(&gbc, 2); - frmsizecod = get_bits(&gbc, 6); - bsid = get_bits(&gbc, 5); - bsmod = get_bits(&gbc, 3); - acmod = get_bits(&gbc, 3); - if (acmod == 2) { - skip_bits(&gbc, 2); // dsurmod - } else { - if ((acmod & 1) && acmod != 1) - skip_bits(&gbc, 2); // cmixlev - if (acmod & 4) - skip_bits(&gbc, 2); // surmixlev + if (ac3_bit_rate_code < 0) { + av_log(s, AV_LOG_ERROR, + "No valid AC3 bit rate code for data rate of %d!\n", + info->data_rate); + return AVERROR(EINVAL); } - lfeon = get_bits1(&gbc); + + avio_wb32(pb, 11); + ffio_wfourcc(pb, "dac3"); init_put_bits(&pbc, buf, sizeof(buf)); - put_bits(&pbc, 2, fscod); - put_bits(&pbc, 5, bsid); - put_bits(&pbc, 3, bsmod); - put_bits(&pbc, 3, acmod); - put_bits(&pbc, 1, lfeon); - put_bits(&pbc, 5, frmsizecod >> 1); // bit_rate_code + put_bits(&pbc, 2, info->substream[0].fscod); + put_bits(&pbc, 5, info->substream[0].bsid); + put_bits(&pbc, 3, info->substream[0].bsmod); + put_bits(&pbc, 3, info->substream[0].acmod); + put_bits(&pbc, 1, info->substream[0].lfeon); + put_bits(&pbc, 5, ac3_bit_rate_code); // bit_rate_code put_bits(&pbc, 5, 0); // reserved flush_put_bits(&pbc); @@ -5975,8 +5974,7 @@ int ff_mov_write_packet(AVFormatContext *s, AVPacket *pkt) if ((par->codec_id == AV_CODEC_ID_DNXHD || par->codec_id == AV_CODEC_ID_H264 || par->codec_id == AV_CODEC_ID_HEVC || - par->codec_id == AV_CODEC_ID_TRUEHD || - par->codec_id == AV_CODEC_ID_AC3) && !trk->vos_len && + par->codec_id == AV_CODEC_ID_TRUEHD) && !trk->vos_len && !TAG_IS_AVCI(trk->tag)) { /* copy frame to create needed atoms */ trk->vos_len = size; @@ -6053,7 +6051,8 @@ int ff_mov_write_packet(AVFormatContext *s, AVPacket *pkt) } } - } else if (par->codec_id == AV_CODEC_ID_EAC3) { + } else if (par->codec_id == AV_CODEC_ID_EAC3 || + par->codec_id == AV_CODEC_ID_AC3) { size = handle_eac3(mov, pkt, trk); if (size < 0) return size;