From patchwork Thu Jun 23 05:32:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chen, Wenbin" X-Patchwork-Id: 36383 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1a22:b0:84:42e0:ad30 with SMTP id cj34csp3264680pzb; Wed, 22 Jun 2022 22:37:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uzGxuIyR6BCp1B4pf2EU/QdkvPSIqICxvbcNYYALKNdqfe8DlPYUOBQsMXvIAFsddOmoVe X-Received: by 2002:a05:6402:1771:b0:435:ba4c:eb4e with SMTP id da17-20020a056402177100b00435ba4ceb4emr6129816edb.172.1655962647287; Wed, 22 Jun 2022 22:37:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655962647; cv=none; d=google.com; s=arc-20160816; b=M12aE26Rpw9SV8m6MP8AZLh0pi/9SYJIZl9iHCGAmw2Ek5feUMT4EhWxrNRR1j8+Gd rNoOV3/FzOTx81AbhlOJ0r6rvoXHvSOsI+G/h4vepox117SwVN/ogSomet3s/QB7WBhX T4jzCsCFIzFqib0AKixwMst+GsrNpc+ZQVvBkn0wEA6vCdIDA86PslSOVeL0wENBdYzf BroKWmyC+/q6VGDYcOT1Geh96DHDnY7hAdxvcq/0T9aKCYysZBY3EptoDmWL8rSNqmXX 46zbCxiiqoq/QoPJ7QfKUe+rH+klvLXh0rB++LKIeRmLDixPZHUvLuzukQVzvR/xtPuB 37Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=3bBd1muCc+Av6exeDXdag59LUUd63loJmoadP6fYa5w=; b=Mt3D+tkt/48sgO0f+GL1Cjs24b/X2otOEaWewwtLmYw6DGhjurxWMx340KZfL6z3zN LKAyZ4Kn5RO4Oojv2c9GDkDJ2mHzxf/rCz1LynyQpy+M6a0+XpmgWn0yi+G9DFcohJgS 3VYBbCLCy1qPivKERNyR+zpRal40bpAJ9UAS9rQ+/O/yqjiCi0JOvsHvyus5a24Fd7ZD 5HYs3vpkUxicM17VEXa+ytB6CAZpuww2lsnNiAywh55tqKiTXJBb5lha1DPI8ky84WsZ 3uAZy/nfyjx1EKH33ps7W9pM2vraSXv+ApAikxEM/g5belsc//hwQzHhuNR5E24434uM jhyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=HrKVTXJi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d4-20020a1709067a0400b00718d0985aa7si3201094ejo.157.2022.06.22.22.37.26; Wed, 22 Jun 2022 22:37:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=HrKVTXJi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7897D68B62B; Thu, 23 Jun 2022 08:37:21 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC4FE68B5F5 for ; Thu, 23 Jun 2022 08:37:14 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655962640; x=1687498640; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=4myoNaXFqDAWb+tU4HWaNN/gaJsmFEWQvcc4fHqJ5Y4=; b=HrKVTXJiuw8PdPS0qMwBZp+eL+59vlBHVx1j2vbFjoi8dpAcWzDF8kxI 4kZvZ9mfnk6gNdKfFaAD1O5VoLMHJkii3FdQySiM2tlXl7pVM8tHTEsXP CUUgqPJmxLqBcdOdkQwmmmJwpzd94l/zn9jpY5ZVYIK/g2GF89DaA2bui cUmRX68QZyqPIqLfCzqN+kFEPLv2zJejcHxmrift+1iKRVwebs6r9DjOS z3z78FkfmLTPLa+iQm3i9i35eM/M0SDfody6IOBwOWsN2MmaHwpXkj34t LYaS7DA4VfL6opuQZJN65eQTN8JPit/joATAcgZYTEL5HOI19F3QmaedF g==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="366950610" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="366950610" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 22:37:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="656016858" Received: from wenbin-z390-aorus-ultra.sh.intel.com ([10.239.35.4]) by fmsmga004.fm.intel.com with ESMTP; 22 Jun 2022 22:37:10 -0700 From: Wenbin Chen To: ffmpeg-devel@ffmpeg.org Date: Thu, 23 Jun 2022 13:32:42 +0800 Message-Id: <20220623053242.360909-1-wenbin.chen@intel.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 6T/MV/q8h4lc From: Yue Heng Enable dynamic QP configuration in runtime on qsv encoder. Through AVFrame->metadata, we can set key "qsv_config_qp" to change QP configuration when we encode video in CQP mode. Signed-off-by: Yue Heng Signed-off-by: Wenbin Chen --- doc/encoders.texi | 10 +++++ libavcodec/qsvenc.c | 89 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 1850c99fe9..02a91ffe96 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3333,6 +3333,16 @@ Forcing I frames as IDR frames. For encoders set this flag to ON to reduce power consumption and GPU usage. @end table +@subsection Runtime Options +Following options can be used durning qsv encoding. + +@table @option +@item @var{qsv_config_qp} +Supported in h264_qsv and hevc_qsv. +This option can be set in per-frame metadata. QP parameter can be dynamically +changed when encoding in CQP mode. +@end table + @subsection H264 options These options are used by h264_qsv diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 902bada55b..2382c2f5f7 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -146,6 +146,14 @@ static const struct { { MFX_RATECONTROL_QVBR, "QVBR" }, }; +#define UPDATE_PARAM(a, b) \ +do { \ + if ((a) != (b)) { \ + a = b; \ + updated = 1; \ + } \ +} while (0) \ + static const char *print_ratecontrol(mfxU16 rc_mode) { int i; @@ -1613,6 +1621,83 @@ static int set_roi_encode_ctrl(AVCodecContext *avctx, const AVFrame *frame, return 0; } +static int update_qp(AVCodecContext *avctx, QSVEncContext *q, + const AVFrame *frame) +{ + int updated = 0, qp = 0, new_qp; + char *tail; + AVDictionaryEntry *entry = NULL; + + if (avctx->codec_id != AV_CODEC_ID_H264 && avctx->codec_id != AV_CODEC_ID_HEVC) + return 0; + + entry = av_dict_get(frame->metadata, "qsv_config_qp", NULL, 0); + if (entry && q->param.mfx.RateControlMethod == MFX_RATECONTROL_CQP) { + qp = strtol(entry->value, &tail, 10); + if (*tail) { + av_log(avctx, AV_LOG_WARNING, "Invalid qsv_config_qp string. Ignore this metadata\n"); + return 0; + } + if (qp < 0 || qp > 51) { + av_log(avctx, AV_LOG_WARNING, "Invalid qp, clip to 0 ~ 51\n"); + qp = av_clip(qp, 0, 51); + } + av_log(avctx, AV_LOG_DEBUG, "Configure qp: %d\n",qp); + UPDATE_PARAM(q->param.mfx.QPP, qp); + new_qp = av_clip(qp * fabs(avctx->i_quant_factor) + + avctx->i_quant_offset, 0, 51); + UPDATE_PARAM(q->param.mfx.QPI, new_qp); + new_qp = av_clip(qp * fabs(avctx->b_quant_factor) + + avctx->b_quant_offset, 0, 51); + UPDATE_PARAM(q->param.mfx.QPB, new_qp); + av_log(avctx, AV_LOG_DEBUG, + "using fixed qp = %d/%d/%d for idr/p/b frames\n", + q->param.mfx.QPI, q->param.mfx.QPP, q->param.mfx.QPB); + } + return updated; +} + +static int update_parameters(AVCodecContext *avctx, QSVEncContext *q, + const AVFrame *frame) +{ + int needReset = 0, ret = 0; + + if (!frame) + return 0; + + needReset = update_qp(avctx, q, frame); + if (!needReset) + return 0; + + if (avctx->hwaccel_context) { + AVQSVContext *qsv = avctx->hwaccel_context; + int i, j; + q->param.ExtParam = q->extparam; + for (i = 0; i < qsv->nb_ext_buffers; i++) + q->param.ExtParam[i] = qsv->ext_buffers[i]; + q->param.NumExtParam = qsv->nb_ext_buffers; + + for (i = 0; i < q->nb_extparam_internal; i++) { + for (j = 0; j < qsv->nb_ext_buffers; j++) { + if (qsv->ext_buffers[j]->BufferId == q->extparam_internal[i]->BufferId) + break; + } + if (j < qsv->nb_ext_buffers) + continue; + q->param.ExtParam[q->param.NumExtParam++] = q->extparam_internal[i]; + } + } else { + q->param.ExtParam = q->extparam_internal; + q->param.NumExtParam = q->nb_extparam_internal; + } + av_log(avctx, AV_LOG_DEBUG, "Parameter change, call msdk reset.\n"); + ret = MFXVideoENCODE_Reset(q->session, &q->param); + if (ret < 0) + return ff_qsv_print_error(avctx, ret, "Error during resetting"); + + return 0; +} + static int encode_frame(AVCodecContext *avctx, QSVEncContext *q, const AVFrame *frame) { @@ -1731,6 +1816,10 @@ int ff_qsv_encode(AVCodecContext *avctx, QSVEncContext *q, { int ret; + ret = update_parameters(avctx, q, frame); + if (ret < 0) + return ret; + ret = encode_frame(avctx, q, frame); if (ret < 0) return ret;