From patchwork Sat Jul 2 12:22:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 36591 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:8b27:b0:88:1bbf:7fd2 with SMTP id l39csp1623715pzh; Sat, 2 Jul 2022 05:23:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vgOLdJiVv5BWPEjTmMrCMLtSkMc8HV+U+KN14ZtA+mE00LzStz1yl8e1XKmA2vW5KXTdeN X-Received: by 2002:a17:907:1c87:b0:6f0:29ea:cc01 with SMTP id nb7-20020a1709071c8700b006f029eacc01mr19222407ejc.671.1656764583122; Sat, 02 Jul 2022 05:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656764583; cv=none; d=google.com; s=arc-20160816; b=QLigOmWLOjvUaCrhiEiGZJTVu+A8njWrx1fZyXXqnCsmr137pXWegWEg0BIdSigZbD i6V7ue37rxwd77a8eCQh2PJ570FUm0CDuOqjzI0QTBix3S4LeU3pq2Dpvt16Qoo9vbuL fnSh801TGT08CjgIjfeS52GodBQv0gtl0mo+ipFrlAYNO5iyQvNfFQ21J9OF6WeW0318 50URsiFu6I21fx6eT0D509MRhfIM9YP089qdSJs8u2kfkUBFP0HkOk1+dPMZy4IauSwf 6TduCigZCu3lZsYH47RWas7EUjZDF67ewuJGmYnPRM8eTsBPELyzw5kE4OUKAm+fnSUI 0Z0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=4nXIzy+SfAVzJqSO1PsmgHz/RcHAGeoyS53VysGgs0E=; b=Kmh60/jwgg6VBqbHg06i315xM0VN6KMTyt5bbEbQAMKNfX6Q1I86ksckPHdmihRbi/ 76ZE0+U/ByUW+iBIyhBAdW/EbGCdSoJMAfueb+aMu223EP0xk3U8xMfaP9TFp0vw61MC oA6LJdLrzFwBO0QB9YpCnQAKw6t63yQY9B30TIoTMypN/kmOMTBrp8NkAgEWuXASKKUh mK41II4kVzkG5wbj2ly9UJ37odWNxRmYNjhEK2x10am3K5P0zi3jQnoyT9zfPBPUIG57 SHJ1krMhPc/H/SfDqXfrwWKE3CLoP1Af9chv3ipOdV0tkbdUkDgrEWJtwCOG24v9SqKM JkcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a11-20020a170906190b00b006e82f2c77cfsi27347711eje.199.2022.07.02.05.23.02; Sat, 02 Jul 2022 05:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 07ECB68B8CF; Sat, 2 Jul 2022 15:23:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-at03-2.mx.upcmail.net (vie01a-dmta-at03-2.mx.upcmail.net [62.179.121.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E71E568B873 for ; Sat, 2 Jul 2022 15:22:52 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1o7c9E-006n2u-18 for ffmpeg-devel@ffmpeg.org; Sat, 02 Jul 2022 14:22:52 +0200 Received: from ren-mail-psmtp-mg02. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id 7c3foncuz8s8U7c9Dob2hi; Sat, 02 Jul 2022 14:22:51 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg02. with ESMTP id 7c9ConlRp8eSW7c9DonhTk; Sat, 02 Jul 2022 14:22:51 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=KKE5sHJo c=1 sm=1 tr=0 ts=62c0389b a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=W5tCvb14_zafgFN4A8AA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 2 Jul 2022 14:22:48 +0200 Message-Id: <20220702122250.23065-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfC2yFQX4RTIzLbpsJxErt+ktfF+oPGCCBkviLiW2fkc7ZOVY5w+O6uqW1/fibUTUo9evbtm680Gz9ognlJWhOemr18Rdel3xmnfr5W9CxR/X33bfM4B3 V7CuyE04unelaShettULJpObRAM/QSiYA5bmGob3PwsbiNm/BMD9ito+g0spts82zYWiH+O7VvS0rg== Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: No channels cannot be accessed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: GoUZkBADEciM Fixes: out of array access Fixes: 48145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5054524173189120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index bf961a03f5..7031fa0acb 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -361,6 +361,9 @@ static av_cold int read_specific_config(ALSDecContext *ctx) return AVERROR_PATCHWELCOME; } + if (avctx->ch_layout.nb_channels == 0) + return AVERROR_INVALIDDATA; + ctx->cur_frame_length = sconf->frame_length; // read channel config