diff mbox series

[FFmpeg-devel] libavcodec/qsvenc: Fix a log format issue

Message ID 20220707055755.90974-1-wenbin.chen@intel.com
State New
Headers show
Series [FFmpeg-devel] libavcodec/qsvenc: Fix a log format issue | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Chen, Wenbin July 7, 2022, 5:57 a.m. UTC
Add a line feed to fix a log format issue.

Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
 libavcodec/qsvenc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

zhilizhao(赵志立) July 7, 2022, 7:37 a.m. UTC | #1
> On Jul 7, 2022, at 1:57 PM, Wenbin Chen <wenbin.chen-at-intel.com@ffmpeg.org> wrote:
> 
> Add a line feed to fix a log format issue.
> 
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> libavcodec/qsvenc.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 2382c2f5f7..81d93235d7 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q,
>         case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE, "pyramid");   break;
>         default:                av_log(avctx, AV_LOG_VERBOSE, "auto");      break;
>         }
> +        av_log(avctx, AV_LOG_VERBOSE, "\n");

It’s not thread safe. There are multiple such cases, better be fixed together.

> 
>         av_log(avctx, AV_LOG_VERBOSE,
>                "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8"; MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
> -- 
> 2.32.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Chen, Wenbin July 7, 2022, 8:47 a.m. UTC | #2
> > On Jul 7, 2022, at 1:57 PM, Wenbin Chen <wenbin.chen-at-
> intel.com@ffmpeg.org> wrote:
> >
> > Add a line feed to fix a log format issue.
> >
> > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> > ---
> > libavcodec/qsvenc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> > index 2382c2f5f7..81d93235d7 100644
> > --- a/libavcodec/qsvenc.c
> > +++ b/libavcodec/qsvenc.c
> > @@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext
> *avctx, QSVEncContext *q,
> >         case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE,
> "pyramid");   break;
> >         default:                av_log(avctx, AV_LOG_VERBOSE, "auto");      break;
> >         }
> > +        av_log(avctx, AV_LOG_VERBOSE, "\n");
> 
> It’s not thread safe. There are multiple such cases, better be fixed together.

Ok, I will fix them together.

Thanks

> 
> >
> >         av_log(avctx, AV_LOG_VERBOSE,
> >                "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8";
> MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
> > --
> > 2.32.0
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 2382c2f5f7..81d93235d7 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -308,6 +308,7 @@  static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q,
         case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE, "pyramid");   break;
         default:                av_log(avctx, AV_LOG_VERBOSE, "auto");      break;
         }
+        av_log(avctx, AV_LOG_VERBOSE, "\n");
 
         av_log(avctx, AV_LOG_VERBOSE,
                "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8"; MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",