diff mbox series

[FFmpeg-devel,2/5] checkasm: motion: Make the benchmarks more stable

Message ID 20220713204854.3114817-2-martin@martin.st
State Accepted
Commit 237730f0e0422fd46ffaf7e724a68eb1e6459645
Headers show
Series [FFmpeg-devel,1/5] libavcodec: aarch64: Don't clobber v8 in the h%4 case in ff_pix_abs16_xy2_neon | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Martin Storsjö July 13, 2022, 8:48 p.m. UTC 
Don't use the last random offset, but a static one.
---
 tests/checkasm/motion.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Swinney, Jonathan July 15, 2022, 7:35 p.m. UTC | #1 
LGTM.

-- 

Jonathan Swinney

On 7/13/22, 3:49 PM, "Martin Storsjö" <martin@martin.st> wrote:

    CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



    Don't use the last random offset, but a static one.
    ---
     tests/checkasm/motion.c | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c
    index 79e4358941..87b20d1c10 100644
    --- a/tests/checkasm/motion.c
    +++ b/tests/checkasm/motion.c
    @@ -81,7 +81,8 @@ static void test_motion(const char *name, me_cmp_func test_func)
                     break;
                 }
             }
    -        // benchmark with the final value of ptr
    +        // Test with a fixed offset, for benchmark stability
    +        ptr = img2 + 3 * WIDTH + 3;
             bench_new(NULL, img1, ptr, WIDTH, 8);
         }
     }
    --
    2.25.1
diff mbox series

Patch

diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c
index 79e4358941..87b20d1c10 100644
--- a/tests/checkasm/motion.c
+++ b/tests/checkasm/motion.c
@@ -81,7 +81,8 @@  static void test_motion(const char *name, me_cmp_func test_func)
                 break;
             }
         }
-        // benchmark with the final value of ptr
+        // Test with a fixed offset, for benchmark stability
+        ptr = img2 + 3 * WIDTH + 3;
         bench_new(NULL, img1, ptr, WIDTH, 8);
     }
 }