From patchwork Wed Jul 13 20:48:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 36783 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:6da0:b0:8b:e47:9dbf with SMTP id wl32csp598260pzb; Wed, 13 Jul 2022 13:49:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vYzrdLHNKBfnNSGXu9z37eoj2pecez6cazK6+KXY2AQpqGRbUpnTqrLcXqSTdHyy3sRIWQ X-Received: by 2002:a17:907:284a:b0:72b:74ac:a83 with SMTP id el10-20020a170907284a00b0072b74ac0a83mr5219434ejc.560.1657745361267; Wed, 13 Jul 2022 13:49:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657745361; cv=none; d=google.com; s=arc-20160816; b=ilUKmmEa9yz5wW7g5FCbZHaUzEBhCaE4vI91n0adHN9UburWocGN16z74uFkfPLRHX BoKLmcWf+/Lx+6QwVqpXf+YLptPegCSVIoGvHjcsa9I1zY9orWgUDvIQHhaup159xzDM 9Mt6FQo+J8Z9lsNuAeQjUhUUIZ/urOPCZRsFsbMwyucTJHgtiDJ08kCGEKCFnLKLkz9/ aYN583lc968q4EUTpSpFy1zl+LWy7fVzkxBcoW5aX13OY1rmWT0xW7yMbqpEIcSgB54s 6J0XqlUOAbBYBYLmkiUvqZXIEUOzuOHtU4/k6ooFryuUjc42azzBrZke6dc1LL+XF1CO gLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=2FRHW9y0Uytb0mVwki9ykaD+ePTmmNzW+gOmUhRMmas=; b=lHRohMRZF00mJQfDPHnDdbnKXjaQRu/7+Okx1XnCFRBwb7P3ybqxvOGMwFTxU4DjIp rIm+jMuR1m23Lprm36qevkot3sDxBT87Fk+v8MTxeVxkkWYqPNRGKX588dT1M4JHacL0 OEJSQzp8kZQsxlZNo9ZR0Zu3Ag9apg8b999tDTU/C04xY3CNiyjzwsbU0ibomTNo9kX3 J2FpMFadN7xjOTDVV3hMbep1zUjTw+UyC9cfovDHaL0mqsGXxs11a+g8qF3ICrSi3NAP VDiTQhiDHnUzHSKLvoF/LExDK6ZJ9zjdhDkB+yz96ajHTXkXc84+SMgUGGUIsqKk7Zm2 J1IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b="7iCKG/Q4"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u16-20020a170906951000b00726429a7f5asi6442597ejx.491.2022.07.13.13.49.20; Wed, 13 Jul 2022 13:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20210112.gappssmtp.com header.s=20210112 header.b="7iCKG/Q4"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0357A68B658; Wed, 13 Jul 2022 23:49:06 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D911A68B9F2 for ; Wed, 13 Jul 2022 23:48:56 +0300 (EEST) Received: by mail-lj1-f178.google.com with SMTP id a10so13000434ljj.5 for ; Wed, 13 Jul 2022 13:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pHgJ59W2rMuHgRVzkbUHw33K/Qox/OdXac/r3vjau6E=; b=7iCKG/Q4+c5aadi3rWySj6hmsLg0a0AwmZwfYTDbLRvHYcodrjUp3kI8CpPGCzMzTf 1Cc78lZbkOYqcg+ctJZbqMTnxWdlHc6DkqA9yI3KDKJ/pM8EhWZ31SWtvXrDwXnoG24b /HAkukKZy684+pLQLC7eicQyH49aK6UN1KkBO2RQE94yQKEW07888PL6PSy5x2qENRS+ f4VaOSGI0lVQxkv4bZDXGsH6aTOWKLOBQK+MIk7J1xsHHtAWJK9KEbTaKhqdgb8hipLp v/fapSpZMB/CSfxt4Dc+LlmmOu7OjQsJgc/vR3UgmSaLTCHvlNB6RIZH5Q5qqeZbf4CH IeZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pHgJ59W2rMuHgRVzkbUHw33K/Qox/OdXac/r3vjau6E=; b=44hD+761a4dg0woqjEEYLGk0hAkPGi5MzYKBA0REHXNyfkZdB0hJOAagVuRImIKudP qJOf3wEX/crHvt4K6MR9cjiBHc5Fs2uvMfy/7lzs2kfThSz2Q77wcCWCZBdBxwk0irW5 ukKpa9hGFpeicyfREI4gjL9geGRj8KHzNbjaEjpTGYH2FfNjGVHPDkZ8oIPEG8AQxcjq UkkucTTYafCCvgQ7C/9kwa+w+ycSqswAAAyD9HJJoZBcQTj1RP9S29kYtkTA3DGvVe9x 3yKO+rBYdXvawLLBtnQ3AG6WPJ7yawInDMs31U4u2A/b/rk7VwWMzljWVyDKMNfbgLjI DnNw== X-Gm-Message-State: AJIora+8shr+P0uSULhu3/9nKIBoc0D97RQS0Yj1Vi/xupFNudtJvT+O lLnM4CBa3rv2RCYXWBl93e/S6OyzmGvfmWL5 X-Received: by 2002:a2e:7012:0:b0:25d:51e4:5e95 with SMTP id l18-20020a2e7012000000b0025d51e45e95mr2538114ljc.465.1657745336154; Wed, 13 Jul 2022 13:48:56 -0700 (PDT) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id c3-20020a056512074300b00489e011bad7sm1993836lfs.218.2022.07.13.13.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 13:48:55 -0700 (PDT) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 13 Jul 2022 23:48:52 +0300 Message-Id: <20220713204854.3114817-3-martin@martin.st> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713204854.3114817-1-martin@martin.st> References: <20220713204854.3114817-1-martin@martin.st> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/5] aarch64: me_cmp: Interleave some of the loads in ff_pix_abs16_xy2_neon X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jonathan Swinney Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QGTWpGMETBx2 Before: Cortex A53 A72 A73 Graviton 3 pix_abs_0_3_neon: 183.7 112.7 97.5 41.2 After: pix_abs_0_3_neon: 175.7 109.2 92.0 41.2 --- libavcodec/aarch64/me_cmp_neon.S | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index 31db3793d9..0ae23d8922 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -101,26 +101,32 @@ function ff_pix_abs16_xy2_neon, export=1 ld1 {v6.16b}, [x5], x3 // load pix3 ld1 {v16.16b}, [x1], x3 // load pix1 - ldur q19, [x5, #1] // load pix3+1 - ld1 {v18.16b}, [x5], x3 // load pix3 - ld1 {v17.16b}, [x1], x3 // load pix1 - - ldur q22, [x5, #1] // load pix3+1 - ld1 {v21.16b}, [x5], x3 // load pix3 - ld1 {v20.16b}, [x1], x3 // load pix1 - // These blocks compute the average: avg(pix2[n], pix2[n+1], pix3[n], pix3[n+1]) uaddl v30.8h, v4.8b, v5.8b // pix3 + pix3+1 0..7 uaddl2 v31.8h, v4.16b, v5.16b // pix3 + pix3+1 8..15 + + ldur q19, [x5, #1] // load pix3+1 + add v23.8h, v2.8h, v30.8h // add up 0..7, using pix2 + pix2+1 values from previous iteration add v24.8h, v3.8h, v31.8h // add up 8..15, using pix2 + pix2+1 values from previous iteration + + ld1 {v18.16b}, [x5], x3 // load pix3 + ld1 {v17.16b}, [x1], x3 // load pix1 + rshrn v23.8b, v23.8h, #2 // shift right 2 0..7 (rounding shift right) rshrn2 v23.16b, v24.8h, #2 // shift right 2 8..15 uaddl v2.8h, v6.8b, v7.8b // pix3 + pix3+1 0..7 uaddl2 v3.8h, v6.16b, v7.16b // pix3 + pix3+1 8..15 + + ldur q22, [x5, #1] // load pix3+1 + add v26.8h, v30.8h, v2.8h // add up 0..7, using pix2 + pix2+1 values from pix3 above add v27.8h, v31.8h, v3.8h // add up 8..15, using pix2 + pix2+1 values from pix3 above + + ld1 {v21.16b}, [x5], x3 // load pix3 + ld1 {v20.16b}, [x1], x3 // load pix1 + rshrn v26.8b, v26.8h, #2 // shift right 2 0..7 (rounding shift right) rshrn2 v26.16b, v27.8h, #2 // shift right 2 8..15