From patchwork Fri Jul 15 08:02:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 36797 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:43a1:b0:8b:53c6:bec9 with SMTP id i33csp125163pzl; Fri, 15 Jul 2022 01:03:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sM3hTnCOyaaSlP2wMUuLziW04snpkpYZ53RPIdtvCHnGeZ9fgXnDZcKPD+vSoabzQxQAPz X-Received: by 2002:aa7:cc0b:0:b0:437:9c60:127b with SMTP id q11-20020aa7cc0b000000b004379c60127bmr16955221edt.320.1657872198677; Fri, 15 Jul 2022 01:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657872198; cv=none; d=google.com; s=arc-20160816; b=FO4RgJiA9IHKPfeCTunzSb5jAii6E+wVoXr7GZvYw1+8wloNyDCXS4xBpoFIjZpg2S GpYv/RrkmqB996gb4qcco0XI0hKrdMVgnud0Q0F/5ZhYHXpod5GfIrE4Rq8RfxYBkRpx KNAERxXoIbI1sGvKA8iy6EVODHi4xNbpXJxcFbAUZmRfIwKpWU/8ntViITbUeC53VztQ 27P5PFv8m2/gR/Tk+meMaUYELRMAIPojyK8VU07ciEdv4hzC30VLow6OsXbQj0hMib59 Je8+17JKGZfQdrC/tLvWLOk6hB770/cYSLCwACpkxr0GaAgeZET8muKizC8sLn+Y70aQ bG4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=WfUfVD/LNLA48izIi8AcZR9QqQrLd/WAhJ2DH/WjQxI=; b=z66ZySBaY9/N6glwS872RiOrkiPs8ASGRSmnnmUJ2TrHeWkZPJ4efpZ+jMIqPms2N4 aBunj7ARF4+Ycw5FcGaVcHIgbyP+/rjdVEDJej216XV+83ITCXH622eoD4ij/6noaPl7 A35ZBycLsTD9Ygcu+m4vX0gMIfNgBn9qSovVMXkTsg2yiYl0F2YAokt83ZfwDSEcyu44 fM4xdPtaPVaGCl+Gos0bOzTDYI+owyGBRzL70E+q5piQYkU9o7J1IVOr18gXQlQZcEZ8 lSM7EVTktlhDA+hmyGJtSIf9Z3j1Z5RCucDEspQTA5oAjvH3iCWU3WMoCxlr8gVnbL4r gZpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=RElS4eh5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sd19-20020a1709076e1300b0072af95f96dbsi4985705ejc.70.2022.07.15.01.03.18; Fri, 15 Jul 2022 01:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=RElS4eh5; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E1A0068B75C; Fri, 15 Jul 2022 11:03:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 28F9A68B8B4 for ; Fri, 15 Jul 2022 11:02:59 +0300 (EEST) Received: by mail-lf1-f44.google.com with SMTP id bf9so6562649lfb.13 for ; Fri, 15 Jul 2022 01:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GtzCRjQ5NiO0sHFITcA3YlcNn5gMmT2hLxDgl/EiCeY=; b=RElS4eh5VQCEuOv9DTVM312lpbJS7djCdNDibmS/hSX41/FG5fKbBbuwqwtfTK9RwH /oodPCSbqctmw1W8/O9/FUi+q0A61APrO2fYqfgOMFFvh6512pzQib/nctV7g1FZXDQy tkQV8LHNzBK7Ri78D/WIGkF26pugmEYMvcQ2jUygvW9Et3f8swF7DPtlNdLhD+G4bxEp HOSmxOE8bsJFO0TLkxZhVZLSg/CMPG+PcHSY5A5iOlJm/eHO7ypFEsfrnrgJzUiRGxeS VTqX4YUdpQEGXKxySzfF2qYUdRvbfq46c+2IrW1lLBbzLeE8w3v0UwoItKQOOGDS8wpF Pydw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GtzCRjQ5NiO0sHFITcA3YlcNn5gMmT2hLxDgl/EiCeY=; b=LAo9BuWZIRJb95b8MnJ7hEQsc4ITHW39Lg3fDaV3iWJS1Wtv79Fxa/8fPFYWWuEKEz ljzjaGmQ/zjTgXlVI/PUUTCezVuiqJqNJTz9bk9Wdd44YTiPXgqfbzg2Rtd+LbJFE3FO 5rcdP7j2MZ18oq3In5ZEA2juaWi+yOfWIzsCCY5e+nTALajjHoc5M7yPBkj30PYcHQWy GiO3HnXSLsEkHglbyExy1uI+5tbHdspMJH84KXDolcJf3AHK/G9yDTBtBiwwY4CLrPLZ w7q9jU/z6ohV9RRSeyG9sLyHAey34HtB3wY06zI3CddAwSi6r/3K52EtBaN7dFO5o28d QUXA== X-Gm-Message-State: AJIora9HUAnz+DL9cV3KQrlpd5yN8AgIL0CR07ei4ubjd95VdeV88OtM t+GDQu/HXmpumjrrpaBRKmzXauTjYSVOKIxs X-Received: by 2002:a05:6512:1153:b0:48a:2836:692f with SMTP id m19-20020a056512115300b0048a2836692fmr76410lfg.650.1657872178327; Fri, 15 Jul 2022 01:02:58 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (adrf243.neoplus.adsl.tpnet.pl. [79.185.165.243]) by smtp.gmail.com with ESMTPSA id k1-20020a2eb741000000b0025d542731ffsm645548ljo.5.2022.07.15.01.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 01:02:57 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Fri, 15 Jul 2022 10:02:24 +0200 Message-Id: <20220715080228.686736-2-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220715080228.686736-1-hum@semihalf.com> References: <20220715080228.686736-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/5] lavc/aarch64: Add neon implementation for sse16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: LCngYirzNyKZ Provide neon implementation for sse16 function. Performance comparison tests are shown below. - sse_0_c: 273.0 - sse_0_neon: 48.2 Benchmarks and tests run with checkasm tool on AWS Graviton 3. Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 4 ++ libavcodec/aarch64/me_cmp_neon.S | 82 ++++++++++++++++++++++++ 2 files changed, 86 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index 136b008eb7..3ff5767bd0 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -30,6 +30,9 @@ int ff_pix_abs16_xy2_neon(MpegEncContext *s, uint8_t *blk1, uint8_t *blk2, int ff_pix_abs16_x2_neon(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, ptrdiff_t stride, int h); +int sse16_neon(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, + ptrdiff_t stride, int h); + av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) { int cpu_flags = av_get_cpu_flags(); @@ -40,5 +43,6 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->pix_abs[0][3] = ff_pix_abs16_xy2_neon; c->sad[0] = ff_pix_abs16_neon; + c->sse[0] = sse16_neon; } } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index e49d049fc2..88cd335443 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -278,3 +278,85 @@ function ff_pix_abs16_x2_neon, export=1 ret endfunc + +function sse16_neon, export=1 + // x0 - unused + // x1 - pix1 + // x2 - pix2 + // x3 - stride + // w4 - h + + cmp w4, #4 + movi d18, #0 + b.lt 2f + +// make 4 iterations at once +1: + + // res = abs(pix1[0] - pix2[0]) + // res * res + + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x2], x3 + uabd v30.16b, v0.16b, v1.16b + ld1 {v2.16b}, [x1], x3 + umull v29.8h, v30.8b, v30.8b + ld1 {v3.16b}, [x2], x3 + umull2 v28.8h, v30.16b, v30.16b + uabd v27.16b, v2.16b, v3.16b + uaddlp v17.4s, v29.8h + umull v26.8h, v27.8b, v27.8b + umull2 v25.8h, v27.16b, v27.16b + ld1 {v4.16b}, [x1], x3 + uadalp v17.4s, v26.8h + ld1 {v5.16b}, [x2], x3 + uadalp v17.4s, v25.8h + uabd v24.16b, v4.16b, v5.16b + ld1 {v6.16b}, [x1], x3 + umull v23.8h, v24.8b, v24.8b + uadalp v17.4s, v23.8h + umull2 v22.8h, v24.16b, v24.16b + uadalp v17.4s, v22.8h + ld1 {v7.16b}, [x2], x3 + uadalp v17.4s, v28.8h + uabd v21.16b, v6.16b, v7.16b + umull v20.8h, v21.8b, v21.8b + uadalp v17.4s, v20.8h + umull2 v19.8h, v21.16b, v21.16b + uadalp v17.4s, v19.8h + + sub w4, w4, #4 + uaddlv d16, v17.4s + cmp w4, #4 + add d18, d18, d16 + + b.ge 1b + + cbnz w4, 2f + fmov w0, s18 + + ret + +// iterate by one +2: + + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x2], x3 + + uabd v30.16b, v0.16b, v1.16b + umull v29.8h, v0.8b, v1.8b + umull2 v28.8h, v0.16b, v1.16b + uaddlp v17.4s, v29.8h + uadalp v17.4s, v28.8h + + + subs w4, w4, #1 + uaddlv d16, v17.4s + add d18, d18, d16 + + b.ne 2b + fmov w0, s18 + + ret + +endfunc