From patchwork Wed Jul 20 08:39:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 36856 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1649:b0:8b:613a:194d with SMTP id no9csp2254952pzb; Wed, 20 Jul 2022 01:40:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tFnSfuNnHMnOO8J2tgP5w8CPahMyDDbbPi+ctlfK8PCuEPKj3oUExibqkp/8R8dUWN3tJ/ X-Received: by 2002:a17:906:6a21:b0:72f:2174:16e6 with SMTP id qw33-20020a1709066a2100b0072f217416e6mr15942650ejc.177.1658306445903; Wed, 20 Jul 2022 01:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658306445; cv=none; d=google.com; s=arc-20160816; b=NlOi4JAF1wrHegPdQly9QZiauXnJa9EUNdFEEP/cwHopGmwc3yXXe3HgLmmYaFVTYS H0lqrOf9GaedIWLl1cZ6cfgNgcuTRR8c4U+iRB9+4RPbu4KkxXRln8elQdKKBGSpdxDO 3rzMPawugj9B0h5NTsnq/T0PrNxisrKfmdjVhd+U0KWZP+EkZOZVELc250ln3SOMdODY NWEbMfQshBTfxMoofhResMN3xR+6EhvnTcEtOXtZegYugQqPmARdUnqjBaiIJ4r7W8WA zNKATwp7nQogI8kzH63dNuuSuJ+jONZOlCWzts/HQ9uTOIjCQ4AUtnRwOdWZ8AJQixLY K6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=d6zSs/+v5Prymop10M1Ga6AoUPMQ2OJixCLBvHZVtmo=; b=AO1/mfLWnZ+2EHDvSngrsznmj0hGkKlRLATRUl3n/P2S+Lk0Wqjl55bTIZvdFN7OPG ZBsWJaJA7SFD09f+nRmmlkPBJoc1BME8ota61M/mR1Dk3cnUxzA3WVZxsajVXlhIb13q b/afqFDdmdPxA5Vj0tfP5Id57n1qs+7/ZxILE0WzWaU+iYl1c/ttsfVdpWabIjIiXuN0 zW7SFnrDO3w6qKPgbgEeppIhLnOHZxgAp7A6O7oETCz9arHxkrysINBkBmcZ9u30uA/1 0NSgwHWGhxdfmqXhusNBiEWJN4CoqKZyYyHYuVqlynW+tYXowX4lwRJLaW8gmQUYIT+4 KrFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=RJ9kewSE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dd8-20020a1709069b8800b0072f287ec4a4si9945315ejc.85.2022.07.20.01.40.45; Wed, 20 Jul 2022 01:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=RJ9kewSE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4008668B62B; Wed, 20 Jul 2022 11:40:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7613268B444 for ; Wed, 20 Jul 2022 11:40:27 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658306432; x=1689842432; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=l9FjtGEoBIxqDcw69Ms/n/HEOJmGRo2YxxTBuoFbORs=; b=RJ9kewSEDwA8hjCNL59KxPyK7f9F1Wz0IVpJGkRFc8o/aPFbXUomL6dN uJtxk9aOIA2BYA4B1nPkKxBtF2ltqnfHGK2Xf6xvYghGUPCYLyhwDbGyR BvVDwaDWmRFj7yKx4bDDPAx5ixnSyaTFiR9dZzsBw7KzOGJnwMIZdmEkM kWDIRkf67Z3CmwBBBnwbjkGDLs8iZKlcjs9Ou61WEGuqeTxjxMSHXh955 hPw8gwm5uLtWS+K1uxGtwXUJQI65fsQtSQQrrEHTavB7cXqDTsupd2I9C xvvcraaHRa8mJqfJ5/zei0m31pzGRPZcmYT3a5kPXJTRwUev8tSUHCa3k A==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="348412480" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="348412480" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 01:40:23 -0700 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="625574637" Received: from xhh-dg164.sh.intel.com ([10.238.5.169]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 01:40:22 -0700 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Wed, 20 Jul 2022 16:39:54 +0800 Message-Id: <20220720084006.5033-2-haihao.xiang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220720084006.5033-1-haihao.xiang@intel.com> References: <20220720084006.5033-1-haihao.xiang@intel.com> Subject: [FFmpeg-devel] [PATCH v11 01/13] configure: ensure --enable-libmfx uses libmfx 1.x X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qlgOuPBZH/6r From: Haihao Xiang Intel's oneVPL is a successor to MediaSDK, but removed some obsolete features of MediaSDK[1], some early versions of oneVPL still use libmfx as library name[2]. However some of obsolete features, including OPAQUE memory, multi-frame encode, user plugins and LA_EXT rate control mode etc, have been enabled in QSV, so user can not use --enable-libmfx to enable QSV if using an early version of oneVPL SDK. In order to ensure user builds FFmpeg against a right version of libmfx, this patch added a check for version < 2.0 and warning message about the used obsolete features. [1] https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html [2] https://github.com/oneapi-src/oneVPL --- configure | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 4888792015..98cbd7a4db 100755 --- a/configure +++ b/configure @@ -6580,10 +6580,12 @@ enabled liblensfun && require_pkg_config liblensfun lensfun lensfun.h lf_ # Media SDK or Intel Media Server Studio, these don't come with # pkg-config support. Instead, users should make sure that the build # can find the libraries and headers through other means. -enabled libmfx && { check_pkg_config libmfx "libmfx >= 1.28" "mfx/mfxvideo.h" MFXInit || - { require libmfx "mfx/mfxvideo.h mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && - { test_cpp_condition mfx/mfxdefs.h "MFX_VERSION >= 1028" || die "ERROR: libmfx version must be >= 1.28"; } && - warn "using libmfx without pkg-config"; } } +enabled libmfx && { { check_pkg_config libmfx "libmfx >= 1.28 libmfx < 2.0" "mfx/mfxvideo.h" MFXInit || + { require libmfx "mfx/mfxvideo.h mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && + { test_cpp_condition mfx/mfxdefs.h "MFX_VERSION >= 1028 && MFX_VERSION < 2000" || die "ERROR: libmfx version must be >= 1.28 and < 2.0"; } && + warn "using libmfx without pkg-config"; } } && + warn "build FFmpeg against libmfx 1.x, obsolete features of libmfx such as OPAQUE memory,\n"\ + "multi-frame encode, user plugins and LA_EXT rate control mode are enabled"; } if enabled libmfx; then check_cc MFX_CODEC_VP9 "mfx/mfxvp9.h mfx/mfxstructures.h" "MFX_CODEC_VP9"