From patchwork Mon Jul 25 04:11:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 36938 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1649:b0:8b:613a:194d with SMTP id no9csp1814351pzb; Sun, 24 Jul 2022 21:12:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vxpbYHBsGf1waW+Y/XrS00zqmVwhDfC7C/8meBeOEaE9BKNXZRKk1/sizTrL2K1i6xJJRi X-Received: by 2002:a05:6402:331d:b0:43b:ee33:8a5e with SMTP id e29-20020a056402331d00b0043bee338a5emr4900879eda.49.1658722345256; Sun, 24 Jul 2022 21:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658722345; cv=none; d=google.com; s=arc-20160816; b=DEMGbbevs5VYlsed3TroJoJ4zKPCvQUZWpzdpNxz6byhcfC+sz3+H7btm6wjRtmhgy ADL8h5A4h9QDYFsAdqMWa+c+6bhk8Zr7N9FaRW5/6wSDy0JWargMnBZzRSGBxr7rTXqU R1xcljsOdhxUVias8mLXdjaNnekzqQK6sMdXcPQd77NvGKz9nslnYycK6jwZKrUuGF6J wf2UY3uuMuTBwAi0D275CkVIS7rbLDhnhDMUiY9fc6Fh/rLMFjY9CyiPaYnQ3FWPx1vK V16Z5KGVwVgYiOLNsynbB8ue/cLDLr/pdd6+f88YkDDh1w0Fsk0R4RktzFHpwul+5MvJ ECWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=I8WG+IvGuZ4uIMzT8Z3JiVCd9j7ztNbna/JcKosXL3k=; b=k8ENW/jR9JuNG20Xv/ya7ehzbIrYisiZOnfF7nEDEgWUhrKy2TGKhhmhLQ/DAuNrGl pS1bfIrf42pQ+V7slUvr4S8Rpm12Jp0KRLld7w1iGtYs2XJpyY2D3apzGY54OtjzeFSr 4S0gCNaC3tj4FW4p/4MG6NMu6mPCeOfRkXVRQmadq41CZXmPW2ZySTGVIFktvG/0qok8 MfDR8bwO4r7Jf2cwA6UQNGaT8/X+DqfsTyHbplhcsi+terwW8WiY5x0kq1cxclZf5Hd1 hzJDfkCMsYKe1pugJMSIDZivm6lVcEKgHc7B0U5tGwVXHFPqWwQEUHJHIAiolZFWSFDo v5AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=JhqSG1mT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qk41-20020a1709077fa900b0072a6be70d30si13763242ejc.385.2022.07.24.21.12.24; Sun, 24 Jul 2022 21:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=JhqSG1mT; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7712168B7B9; Mon, 25 Jul 2022 07:12:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDD4968B378 for ; Mon, 25 Jul 2022 07:12:05 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658722331; x=1690258331; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=X7SDer9iE1ImLo26egOeUCdUM916OU5P5JMd8m2LV/I=; b=JhqSG1mTjBFYRZgzP1xA0OU55ELg4dP8OKQf6tX6MFozDwL5PQqk/QY0 bP/7/n18Q6Mt4wPbu0tUGe6y9VTp94gY9YDGroPIudVMYbNbtmmL19jYp m58Iqqk5lKzEsN1dW0bqe+BH+xnymG+/v7H6UT2iaR1fQCdmJgOTc+Mt2 HlRlZwUfYvdiL1oHfuIfZWRtYOSVN2g9AhBLa0c+lCUqZDyfSLj5CoEFw 0YudiFJZCusPRjj2XZXdcAEn53+yj0H/XEfyODuRUYBLZx9e9Q3XDEgCu aIGVFIHrGquVUy2GZzc7tz15XZZuJ1rlAJMQnFwO93/amYOXKYae5Uslf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10418"; a="274468200" X-IronPort-AV: E=Sophos;i="5.93,191,1654585200"; d="scan'208";a="274468200" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2022 21:12:02 -0700 X-IronPort-AV: E=Sophos;i="5.93,191,1654585200"; d="scan'208";a="596543981" Received: from xhh-dg164.sh.intel.com ([10.238.5.169]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2022 21:12:01 -0700 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Mon, 25 Jul 2022 12:11:39 +0800 Message-Id: <20220725041151.7710-2-haihao.xiang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220725041151.7710-1-haihao.xiang@intel.com> References: <20220725041151.7710-1-haihao.xiang@intel.com> Subject: [FFmpeg-devel] [PATCH v12 01/13] configure: ensure --enable-libmfx uses libmfx 1.x X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5kbWjyHTjFJu From: Haihao Xiang Intel's oneVPL is a successor to MediaSDK, but removed some obsolete features of MediaSDK[1], some early versions of oneVPL still use libmfx as library name[2]. However some of obsolete features, including OPAQUE memory, multi-frame encode, user plugins and LA_EXT rate control mode etc, have been enabled in QSV, so user can not use --enable-libmfx to enable QSV if using an early version of oneVPL SDK. In order to ensure user builds FFmpeg against a right version of libmfx, this patch added a check for version < 2.0 and warning message about the used obsolete features. [1] https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html [2] https://github.com/oneapi-src/oneVPL --- configure | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 6629d14099..027fd756c4 100755 --- a/configure +++ b/configure @@ -6580,10 +6580,12 @@ enabled liblensfun && require_pkg_config liblensfun lensfun lensfun.h lf_ # Media SDK or Intel Media Server Studio, these don't come with # pkg-config support. Instead, users should make sure that the build # can find the libraries and headers through other means. -enabled libmfx && { check_pkg_config libmfx "libmfx >= 1.28" "mfx/mfxvideo.h" MFXInit || - { require libmfx "mfx/mfxvideo.h mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && - { test_cpp_condition mfx/mfxdefs.h "MFX_VERSION >= 1028" || die "ERROR: libmfx version must be >= 1.28"; } && - warn "using libmfx without pkg-config"; } } +enabled libmfx && { { check_pkg_config libmfx "libmfx >= 1.28 libmfx < 2.0" "mfx/mfxvideo.h" MFXInit || + { require libmfx "mfx/mfxvideo.h mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && + { test_cpp_condition mfx/mfxdefs.h "MFX_VERSION >= 1028 && MFX_VERSION < 2000" || die "ERROR: libmfx version must be >= 1.28 and < 2.0"; } && + warn "using libmfx without pkg-config"; } } && + warn "build FFmpeg against libmfx 1.x, obsolete features of libmfx such as OPAQUE memory,\n"\ + "multi-frame encode, user plugins and LA_EXT rate control mode are enabled"; } if enabled libmfx; then check_cc MFX_CODEC_VP9 "mfx/mfxvp9.h mfx/mfxstructures.h" "MFX_CODEC_VP9"