From patchwork Wed Aug 3 13:58:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 37109 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1649:b0:8b:613a:194d with SMTP id no9csp458619pzb; Wed, 3 Aug 2022 07:01:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR7RRSlc9PXyEfCJTTNw90B55kUxkepH708QX/0pD7Np4jSY8bFeFCI1TchVEeoOmzRU0CUe X-Received: by 2002:a17:907:94d2:b0:730:87c1:e86c with SMTP id dn18-20020a17090794d200b0073087c1e86cmr10924949ejc.129.1659535261459; Wed, 03 Aug 2022 07:01:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659535261; cv=none; d=google.com; s=arc-20160816; b=WD0lHIu/3KAIcyZK7xX5DUUDcKKnU0IntPA8e/UwbdOKWAkWwmakA7ludf2FnXOoPR FNjzqIqWUg9v7PEuT03vQUwEMh4K21UD2l+8MMrBuW/JOi5Cpi0q4XcKa/K89FzVtMv9 xZuJ2ed12knsrfyNjeohqbWynbWvsADCVJHvUF9/8wYIAS/u+HaAXUaBZfIqEg3O0vNS 6l6fK6HRD1tiCTsPf3JZFfE6G+T2Nbk666BVvai80XlQdj5RpU1Y5HawrsaU2KgaCe2P coO08jxNLPZpoHMKcDUxsK2taXJAjv60ayUWqZPAkyczlhWhmluQ61tFRehRqMIuXo7/ Yn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=VAVDVFPTLTwrLOkzt6bcMfmPtVdwvcK0Q0G3f0STZcA=; b=x6QsjzngqdCJ6lJzH//aj8N2HGfZJDyYRTSNl9T1hQOgu3DRFc/C8t/evjbVALNpyI D4I6VlAhA6AD2zmeahp9KVil7VNWmwZr9jM9LGaTGJMg7xXpwKUa9auXx4OkR9bdb+ZR VftFY1Jz4efIEYJ7RqUHN9r4x7/qDxcLyk9ClWnqWbwihGK8UA1ke6SshKFTFOyWiIIN S81FRBtU1ilUz6IhCWLZogVqRPr3SeJu04ydicJ7u9PLBb5Ri7DhW8qyc4Hn0mdcF8AI SFZSgkeblhrEbHhjVYpuay5CAAjsAunXTdQ8iRuWi4Q1EYxc4pmvVazCJfYtIRE+jP1K pe+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j8-20020a05640211c800b0043d646c3ef9si11034687edw.259.2022.08.03.07.01.01; Wed, 03 Aug 2022 07:01:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9371668B94D; Wed, 3 Aug 2022 16:59:14 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E51E68B895 for ; Wed, 3 Aug 2022 16:59:06 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2E23D240590 for ; Wed, 3 Aug 2022 15:59:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id AtLuN8xjOy90 for ; Wed, 3 Aug 2022 15:59:04 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1D6DA240687 for ; Wed, 3 Aug 2022 15:58:55 +0200 (CEST) Received: by libav.khirnov.net (Postfix, from userid 1000) id 317843A054D; Wed, 3 Aug 2022 15:58:52 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Wed, 3 Aug 2022 15:58:36 +0200 Message-Id: <20220803135844.16662-17-anton@khirnov.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220803135844.16662-1-anton@khirnov.net> References: <20220803135844.16662-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 17/25] fftools/ffmpeg: drop the 'h' key handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /8QVhzmPwoeM This undocumented feature runtime-enables dumping input packets. I can think of no reasonable real-world use case that cannot also be accomplished in a different way. Keeping this functionality would interfere with the following commit moving it to the input thread (then setting the variable would require locking or atomics, which would be unnecessarily complicated for a feature that probably nobody uses). --- fftools/ffmpeg.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0a94b0d05a..3911db1948 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -3537,15 +3537,6 @@ static int check_keyboard_interaction(int64_t cur_time) if (key == '+') av_log_set_level(av_log_get_level()+10); if (key == '-') av_log_set_level(av_log_get_level()-10); if (key == 's') qp_hist ^= 1; - if (key == 'h'){ - if (do_hex_dump){ - do_hex_dump = do_pkt_dump = 0; - } else if(do_pkt_dump){ - do_hex_dump = 1; - } else - do_pkt_dump = 1; - av_log_set_level(AV_LOG_DEBUG); - } if (key == 'c' || key == 'C'){ char buf[4096], target[64], command[256], arg[256] = {0}; double time;