Message ID | 20220808085951.78794-1-martin@martin.st |
---|---|
State | Accepted |
Commit | 1eaa575cf11c054b0b724480f3070fc908faf8ef |
Headers | show |
Series | [FFmpeg-devel] tools: Make sure to create the tools directory before building decode_simple.o | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
Quoting Martin Storsjö (2022-08-08 10:59:51) > This directory dependency is normally added implicitly by rules > in ffbuild/common.mak; for tools it's created by a rule for TOOLOBJS. > TOOLOBJS is populated implicitly from TOOLS, and decode_simple.o > doesn't end up there because it's an odd occurrance of a lone > object file in the tools subdirectory, not belonging to any other > tool. > > --- > This fixes stray fate errors where make tried to build this object > file when no other rule had ended up creating the tools directory > already, like this one: > http://fate.ffmpeg.org/log.cgi?time=20220808051007&slot=i686-mingw32-clang-trunk&log=test > --- > tools/Makefile | 2 ++ > 1 file changed, 2 insertions(+) Should be ok
diff --git a/tools/Makefile b/tools/Makefile index f4d1327b9f..4afa23342d 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -20,6 +20,8 @@ tools/target_io_dem_fuzzer.o: tools/target_dem_fuzzer.c tools/venc_data_dump$(EXESUF): tools/decode_simple.o tools/scale_slice_test$(EXESUF): tools/decode_simple.o +tools/decode_simple.o: | tools + OUTDIRS += tools clean::