diff mbox series

[FFmpeg-devel] configure: enable the av1_frame_split bsf for the av1 decoder

Message ID 20220818190147.1576-1-h.leppkes@gmail.com
State New
Headers show
Series [FFmpeg-devel] configure: enable the av1_frame_split bsf for the av1 decoder | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Hendrik Leppkes Aug. 18, 2022, 7:01 p.m. UTC 
The BSF is required to make use of the AV1 decoder, thus configure
should also ensure it is build.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer Aug. 18, 2022, 7:09 p.m. UTC | #1 
On 8/18/2022 4:01 PM, Hendrik Leppkes wrote:
> The BSF is required to make use of the AV1 decoder, thus configure
> should also ensure it is build.
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fe94941a03..6a179190ac 100755
> --- a/configure
> +++ b/configure
> @@ -2788,7 +2788,7 @@ atrac3al_decoder_select="mdct"
>   atrac3p_decoder_select="mdct sinewin"
>   atrac3pal_decoder_select="mdct sinewin"
>   atrac9_decoder_select="mdct"
> -av1_decoder_select="cbs_av1"
> +av1_decoder_select="cbs_av1 av1_frame_split_bsf"
>   bink_decoder_select="blockdsp hpeldsp"
>   binkaudio_dct_decoder_select="mdct rdft dct sinewin wma_freqs"
>   binkaudio_rdft_decoder_select="mdct rdft sinewin wma_freqs"

LGTM
Andreas Rheinhardt Aug. 18, 2022, 7:12 p.m. UTC | #2 
Hendrik Leppkes:
> The BSF is required to make use of the AV1 decoder, thus configure
> should also ensure it is build.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fe94941a03..6a179190ac 100755
> --- a/configure
> +++ b/configure
> @@ -2788,7 +2788,7 @@ atrac3al_decoder_select="mdct"
>  atrac3p_decoder_select="mdct sinewin"
>  atrac3pal_decoder_select="mdct sinewin"
>  atrac9_decoder_select="mdct"
> -av1_decoder_select="cbs_av1"
> +av1_decoder_select="cbs_av1 av1_frame_split_bsf"
>  bink_decoder_select="blockdsp hpeldsp"
>  binkaudio_dct_decoder_select="mdct rdft dct sinewin wma_freqs"
>  binkaudio_rdft_decoder_select="mdct rdft sinewin wma_freqs"

LGTM. (Maybe order the prerequisites alphabetically as is already mostly
done?)

- Andreas
Andreas Rheinhardt Aug. 18, 2022, 7:14 p.m. UTC | #3 
Hendrik Leppkes:
> The BSF is required to make use of the AV1 decoder, thus configure
> should also ensure it is build.

s/build/built/
(if I am not mistaken)

> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fe94941a03..6a179190ac 100755
> --- a/configure
> +++ b/configure
> @@ -2788,7 +2788,7 @@ atrac3al_decoder_select="mdct"
>  atrac3p_decoder_select="mdct sinewin"
>  atrac3pal_decoder_select="mdct sinewin"
>  atrac9_decoder_select="mdct"
> -av1_decoder_select="cbs_av1"
> +av1_decoder_select="cbs_av1 av1_frame_split_bsf"
>  bink_decoder_select="blockdsp hpeldsp"
>  binkaudio_dct_decoder_select="mdct rdft dct sinewin wma_freqs"
>  binkaudio_rdft_decoder_select="mdct rdft sinewin wma_freqs"
diff mbox series

Patch

diff --git a/configure b/configure
index fe94941a03..6a179190ac 100755
--- a/configure
+++ b/configure
@@ -2788,7 +2788,7 @@  atrac3al_decoder_select="mdct"
 atrac3p_decoder_select="mdct sinewin"
 atrac3pal_decoder_select="mdct sinewin"
 atrac9_decoder_select="mdct"
-av1_decoder_select="cbs_av1"
+av1_decoder_select="cbs_av1 av1_frame_split_bsf"
 bink_decoder_select="blockdsp hpeldsp"
 binkaudio_dct_decoder_select="mdct rdft dct sinewin wma_freqs"
 binkaudio_rdft_decoder_select="mdct rdft sinewin wma_freqs"