diff mbox series

[FFmpeg-devel,3/6] fftools/ffmpeg_filter: remove an always-true check

Message ID 20220825085956.4790-3-anton@khirnov.net
State Accepted
Commit 4a4a206304e1d168e9a839d1a9c426e459343322
Headers show
Series [FFmpeg-devel,1/6] fftools/ffmpeg: remove a stale extern declaration | expand

Commit Message

Anton Khirnov Aug. 25, 2022, 8:59 a.m. UTC 
ost->enc is always non-NULL here, since
- this code is never called for streamcopy
- opening the output file will fail if an encoder cannot be found, so
  filters are never initialized
---
 fftools/ffmpeg_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 4e2787eba2..e9479018e4 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -105,7 +105,7 @@  static const char *choose_pix_fmts(OutputFilter *ofilter, AVBPrint *bprint)
     if (ost->enc_ctx->pix_fmt != AV_PIX_FMT_NONE) {
         return av_get_pix_fmt_name(choose_pixel_fmt(ost->enc, ost->enc_ctx->pix_fmt,
                                                     ost->enc_ctx->strict_std_compliance));
-    } else if (ost->enc && ost->enc->pix_fmts) {
+    } else if (ost->enc->pix_fmts) {
         const enum AVPixelFormat *p;
 
         p = ost->enc->pix_fmts;