From patchwork Tue Aug 30 12:09:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Neil Roberts X-Patchwork-Id: 37564 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp2514845pzh; Tue, 30 Aug 2022 05:10:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR49/lBHOvHn0Kvq4VR0jeuRSssx/Hv03mbUpKrnBY/gJkFGt0XPbCUrM0DVqZ9Dk+0E7oRm X-Received: by 2002:a17:906:6086:b0:731:3970:48d0 with SMTP id t6-20020a170906608600b00731397048d0mr16897990ejj.16.1661861438603; Tue, 30 Aug 2022 05:10:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661861438; cv=none; d=google.com; s=arc-20160816; b=wl0xP5ioNa7A0KPFFE+N8q9Uk/gZ1qIk581JAvd01mXuVEp7RUXsuKV+Ql5FABpMrb xkkNFxfvOhW8zSojq8jeyf4ZJsFeETnsKOf+JXAjpWBvBC4kTszP7bH4nSVotasW5FgL d8wf/EUpW2qW570Oi6jKFOInYv5Hv/A97mhxqmx8OktMB77Lay4xbeSdLFPY7o9KvqNu JAxqhMd9K3fDuajnIjdTbIfW00Aw3GJxhf6wiboa2NcQHB7VjttkjH3tsoKu1n5d6dCi nATZ953xg2yddLGuWq7OlY8rk2BafCGZuQn9a19YHIEDn17amLjdjVMgxPhVRAnqGizW KE2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=05luOHoOFMctwIRXcuxH/mPfV1ck0lb+QdlvPmFiXks=; b=jILXLCxQS/aS0beVYWaXF3NrdzQEz3kuZoApxAslvCCfn7cqVNw8iW4khyVfox3kzW QHx8JGyef5DiG9/tJaBtnd/E+dqkux88bkhyXJ6KajsUqrso/aFvL2TZLpiIkmhTkoYQ BMedq9Rdqc65EUZzV34VDfXskW3ertilH3kYShCRmvvjxrIrTEvTXTOayT0mPO0dmNtI /IMxWad9hdsQrJPDtIsYW78xNH9h9Q6BcuzmxoonGG3cQnCZ3ynOyM0zSis1WS4UDp/P R4xGMZnxEB6uF/LeBzaaWqaeSsooZo4TRnvydyG32pSEF2/wR38oWEBglQoXeVZz04qX 249Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@yahoo.co.uk header.s=s2048 header.b="p9Q/lOHI"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ga8-20020a1709070c0800b007306121368esi9919900ejc.668.2022.08.30.05.10.37; Tue, 30 Aug 2022 05:10:38 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@yahoo.co.uk header.s=s2048 header.b="p9Q/lOHI"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EBB8568BABC; Tue, 30 Aug 2022 15:10:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from sonic311-30.consmr.mail.ir2.yahoo.com (sonic311-30.consmr.mail.ir2.yahoo.com [77.238.176.162]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D461968B993 for ; Tue, 30 Aug 2022 15:10:26 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1661861425; bh=smxvZK4WDGTWvf+hMxi5dpRHzWB6xV8qZcTyTq8X73E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=p9Q/lOHIGaZqjb2rYbzFN+4N8NQuYmhDCDoxvPKx2BvmZ9qNkX3UquBuxsp8ea2BULJCkYaYCS7D6TzIfPHfiM37Y9wSQYmdBPdGA419vd+S/GovIfHiQG3PPuMMl0aBg1YuBeg/NFMV3JoqqwE4Kq6qBZzRAOtOeuhRxYBNyjvoBpKFyA7c4PNWNcBLxlTB91Xl9broscOrr9CCvhjv/499Z2wLtHGlDBNlSq7026zt+DD5//x3DhE994LvAN/aIP8Jk6TF8T1ROw3c3bDWJbqL1MpfGnb4FypiQJxRWFtYWOU7pXHwdhRUbeEn0JpSTrTm4OwTC/aSYfU//3UCzQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1661861425; bh=/gtpq4HeVsdltRlTPlCKz8oN+/aNbqL4NqVlEdhvUzU=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PSkuRApu7l050kIz6G1TPe6l+XiiGumTQ+pVtQF/Eu0BOAcW57ZUG+eAGu0vZZqv+HmvVHZMXgALmV0neU8Bn/RwAzOXda/RRj8sGwmUt0cnJ5u18XtgqglUwlXD945xj5IDQL96MGX4aqxuiFhUIjybN1Yo+VI5K5Kd39KBBFhTmJy++gJsEYVYe6HDHL75GkE/xC4yJ2rOqTMNnHBxxyHoy8vt+/O02O8e5IpcJ6ujDWok9gN0AaZAlqgjkxK8yLKeqfiln7C1uh/uqQiyaCTrnaKBHlvrdzh08u7yca5Xw+UcjylMUO5m9T/BQzAlz3nIxg/SMiLAwnsl6Csr0w== X-YMail-OSG: P1GsvrIVM1ki5_bg1_4VngQqWDfR20ACktRtLGSmRI7P9DQ4ZwdFQA7GB1QM_0. H1POHplT5V_O7KhoWt1AcQoBkHIJZWJ7ny_YiT5C.K.2vMrntk8qbJz.wU6kdpS6NMksAkphiz7c AzpQ_DyNuTXO7hdxJiEgn3yMtdv2PTVvpl2NVkszw4WSnxJsP_9kmhM.AvdaPrtRdpc38OZedLDM ZOUPS7.86p20OOoNhoI3ypsiGQc_nE96xsm4DssBV0LRYox0yGAQriwH4ZT5UdWqR3uNP6atN4oJ WUC1G0YpUei7v2IGF96r3zDO5.Rr4VYkWdsgMHP5DqHBC5e4xZlhYh_Ph57XXj2C0iHXqGgnqiEq 2UCG0iGNLKD0Vouhsmc.btFk3Dq9hrLgIn2tm8LVPKDbMLFeD4EIler6Fu2B7WcfY_0grHLpC4Ir M1SzPz.iGc6NH28Vd65r0CpcuYMeC7IO2uasS1tmAjT7MNHjdbIU137J0_R287RzamJ7JRFF8un1 6obJIiM2YtBX8ZWtqKAJa2CJurf6uthk7XP1qa8jhE3.6.hS_DSXFtIdsFzSRwz2hdF2sC0X3qlB DXzmohJVp6ssgLSHzaikT57y25Uy61K2kpdhjfNu78FE4vkWFczAUN7BybEsUIpJuOF3Yv0pspKn K9KkP7JuKiW3A7hHwsB8bw3Tf1AXBEurRhC9nBjv2MndC0p9tbuDj.kThzBmbk_j7mTyp3Z0RIX9 W.J8KPJyQnroWKfDX9DGtxSzQG0Q395krP.9MXnO4O3UAOyBds1cNwXc7tJAAtN3nK7Ad03XSF92 yPXrx.ANiPcBkVh3d5NKmpnaH7LkiFQJHEu3AIDWUypbwC5.XThmfFRPaVyQvJvOfsacug5k6PbH djZkEMLhRhILRwPRTC.ElxjjV8lGTtsTyjAv1tHe8xnapoTFtg0KuoqIx8gsGBjNfZ93HQcqgMzc fUS793Vxdao4bk_kNulRQD9ph3z5N_ks0ePqCIfyMgl2yS5bDIhiXVnD3OlzLIyamaz9jqukZkSz 7rsEA0OR2dSPuHNwXb7dvy7UXgdHeUKFLvxjRkxKrFozLr9jyZHrEBJYfm0aDAG12te3XREVkGnH GQ7kTyvsApnBkolDOPNs1ZrTW39iiSHUr3Ti3D5xYnLKy2q6u.oPmMv4CECagXqHhwxF.myjfzyO xShcmCtbxX80r5g.RUA3uviQs.AVygpGFEydT_uWQP3iyC.VSJ65QWlrwIuh9ep_fXip58QkYoJ2 FL56zSH1F2G0y.5.TRbcsMfBL2Bab3LT15ZYo2mcEp4LSS7iYo7zAHWq.nilSY.9Jzxk5xuO7ZZ9 oDKC64lcnEYwom_56eyF1gB77VFT7QB2r1cE9zvIImS_DyBx4tr_IJydXOTPZIQ_5sNxIrppo28R pYGOfQh.1FTSib6rWIy__pnAEj_X9XwHySJ3jybP16p_yLoKETL29hRRZk7vsvEdarjJf3sO8lbj 2kmDD5GDTh6ObRtugWwLh6dtNRdhjSHF87oj6h.9Az3Ng0Th4dT.a9J6rASl.QH5CpJ6zX6bxueV P9hD1wVDb998ZTvpVlDPRMgq4S6kxSPZvNxE5F3Y3XUJtV07iMUJPhGGsxPWMLu.dpDVVmvtgiNO bVA3HamlmVu8MIg4hT3A9r4871piV1XjWbR2uCDvi5kSoE5jbu0rPrb6qs5Lr8xrC4Nz8ziwAMHt pQhO0ZlVkg.Yz4iQ9FerzLvH3yrLoPVUe4OzcT2OskOwq9p.U10RQSx0c_W48WkIQo6p2Y7IAV8E ufA2.J9208I4bGPkMtfqbqdkDI_AgciqgK9hmnfaVwqYVtK9NSJxGPD.et90g3IUw9puWHz4Cdk. WTOZxS1wI4RAo9OvToPcjeQ47BbsVWMhCidE9AbFq8K.XdTHScFNhr74Rp.ItgaB7Jn17jLIvr7k cQPTdVm..XUm_eNmNPPFArmMZLfY0TE_kfkmsckC5H7ooKrAYeu9BzoNa6akO2vu22a0R6_4t_R9 ZnR5fM4qilkm9PV3VFOFJoaxEvDDmrWd7I0epaOI8Ipmv1_MKf3SHQSb85B3a0pHh9gMS7vyCPRF Z7A6IxU.VZcbqcUIfqcX0l7XN.eSWzIzkrXrJes_sVjxmnWg5mIYlM8crl2LAOXzCLA277hzseB5 YznpRdzXRUTZy8_s4FTCG2Jd.ciz8BhsEl69aN6wlN9cIuOHnpaTd.McnYdyId2gP7fQ3uRzLsnd HXM.F3BqkNe0T1vpqzzQ4iDRO_R5hi5fOgtyzqLLvvoZQIA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Tue, 30 Aug 2022 12:10:25 +0000 Received: by hermes--canary-production-ir2-f74ffc99c-m57bk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID cd239fc55189361b064b71248153a937; Tue, 30 Aug 2022 12:10:24 +0000 (UTC) From: Neil Roberts To: ffmpeg-devel@ffmpeg.org Date: Tue, 30 Aug 2022 14:09:53 +0200 Message-Id: <20220830120954.452255-1-bpeeluk@yahoo.co.uk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829215422.GK2088045@pb2> References: <20220829215422.GK2088045@pb2> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 1/2] avformat/file: Add a specialized url_check callback for pipe protocol X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 7422r18XnOlJ Using file_check for the pipe protocol doesn't make sense. For example, for a URL like “pipe:0” it would end up checking whether the “pipe:0” file exists. This patch instead makes it check the access modes on the corresponding file descriptor using fcntl on *nix and DuplicateHandle on Windows. v2: Use DuplicateHandle on Windows to check whether the duplicated handle can have the corresponding access flags. Signed-off-by: Neil Roberts --- libavformat/file.c | 74 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 71 insertions(+), 3 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 98c9e81bcb..b3f7bc9282 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -375,9 +375,8 @@ const URLProtocol ff_file_protocol = { #if CONFIG_PIPE_PROTOCOL -static int pipe_open(URLContext *h, const char *filename, int flags) +static int pipe_get_fd(const char *filename, int flags) { - FileContext *c = h->priv_data; int fd; char *final; av_strstart(filename, "pipe:", &filename); @@ -390,6 +389,14 @@ static int pipe_open(URLContext *h, const char *filename, int flags) fd = 0; } } + + return fd; +} + +static int pipe_open(URLContext *h, const char *filename, int flags) +{ + FileContext *c = h->priv_data; + int fd = pipe_get_fd(filename, flags); #if HAVE_SETMODE setmode(fd, O_BINARY); #endif @@ -398,13 +405,74 @@ static int pipe_open(URLContext *h, const char *filename, int flags) return 0; } +static int pipe_check(URLContext *h, int mask) +{ + int fd = pipe_get_fd(h->filename, mask); + int access = 0; + +#ifdef _WIN32 + + HANDLE pipe_handle = (HANDLE) _get_osfhandle(fd); + HANDLE tmp_handle; + + if (pipe_handle == INVALID_HANDLE_VALUE) + return AVERROR(errno); + + if (mask & AVIO_FLAG_READ && + DuplicateHandle(GetCurrentProcess(), /* hSourceProcessHandle */ + pipe_handle, + GetCurrentProcess(), /* hTargetProcessHandle */ + &tmp_handle, + FILE_READ_DATA, + FALSE, /* bInheritHandle */ + 0 /* options */)) { + access |= AVIO_FLAG_READ; + CloseHandle(tmp_handle); + } + + if (mask & AVIO_FLAG_WRITE && + DuplicateHandle(GetCurrentProcess(), /* hSourceProcessHandle */ + pipe_handle, + GetCurrentProcess(), /* hTargetProcessHandle */ + &tmp_handle, + FILE_WRITE_DATA, + FALSE, /* bInheritHandle */ + 0 /* options */)) { + access |= AVIO_FLAG_WRITE; + CloseHandle(tmp_handle); + } + +#else /* _WIN32 */ + + int status_flags = fcntl(fd, F_GETFL); + + if (status_flags == -1) + return AVERROR(errno); + + switch (status_flags & O_ACCMODE) { + case O_RDONLY: + access = AVIO_FLAG_READ; + break; + case O_WRONLY: + access = AVIO_FLAG_WRITE; + break; + case O_RDWR: + access = AVIO_FLAG_READ | AVIO_FLAG_WRITE; + break; + } + +#endif /* _WIN32 */ + + return access & mask; +} + const URLProtocol ff_pipe_protocol = { .name = "pipe", .url_open = pipe_open, .url_read = file_read, .url_write = file_write, .url_get_file_handle = file_get_handle, - .url_check = file_check, + .url_check = pipe_check, .priv_data_size = sizeof(FileContext), .priv_data_class = &pipe_class, .default_whitelist = "crypto,data"