diff mbox series

[FFmpeg-devel,5/7] swresample/swresample: Fix mismatching argument names

Message ID 20220915015301.34744-5-epirat07@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/7] avcodec: Fix Doxygen trailing brief comments | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Marvin Scholz Sept. 15, 2022, 1:52 a.m. UTC
---
 libswresample/swresample.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

James Almer Sept. 15, 2022, 2:12 a.m. UTC | #1
On 9/14/2022 10:52 PM, Marvin Scholz wrote:
> ---
>   libswresample/swresample.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libswresample/swresample.h b/libswresample/swresample.h
> index 980be65783..83821a0930 100644
> --- a/libswresample/swresample.h
> +++ b/libswresample/swresample.h
> @@ -354,8 +354,8 @@ int swr_convert(struct SwrContext *s, uint8_t **out, int out_count,
>    *              in this case the output timestamps will match output sample numbers.
>    *              See ffmpeg-resampler(1) for the two modes of compensation.
>    *
> - * @param s[in]     initialized Swr context
> - * @param pts[in]   timestamp for the next input sample, INT64_MIN if unknown
> + * @param[in] s     initialized Swr context
> + * @param[in] pts   timestamp for the next input sample, INT64_MIN if unknown
>    * @see swr_set_compensation(), swr_drop_output(), and swr_inject_silence() are
>    *      function used internally for timestamp compensation.
>    * @return the output timestamp for the next output sample
> @@ -636,8 +636,8 @@ int swr_convert_frame(SwrContext *swr,
>    * @see swr_close();
>    *
>    * @param swr             audio resample context
> - * @param output          output AVFrame
> - * @param input           input AVFrame
> + * @param output          out   AVFrame
> + * @param input           in    AVFrame

@param out             output AVFrame
@param in              input AVFrame

>    * @return                0 on success, AVERROR on failure.
>    */
>   int swr_config_frame(SwrContext *swr, const AVFrame *out, const AVFrame *in);
Marvin Scholz Sept. 15, 2022, 7:24 a.m. UTC | #2
On 15 Sep 2022, at 4:12, James Almer wrote:

> On 9/14/2022 10:52 PM, Marvin Scholz wrote:
>> ---
>>   libswresample/swresample.h | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libswresample/swresample.h b/libswresample/swresample.h
>> index 980be65783..83821a0930 100644
>> --- a/libswresample/swresample.h
>> +++ b/libswresample/swresample.h
>> @@ -354,8 +354,8 @@ int swr_convert(struct SwrContext *s, uint8_t **out, int out_count,
>>    *              in this case the output timestamps will match output sample numbers.
>>    *              See ffmpeg-resampler(1) for the two modes of compensation.
>>    *
>> - * @param s[in]     initialized Swr context
>> - * @param pts[in]   timestamp for the next input sample, INT64_MIN if unknown
>> + * @param[in] s     initialized Swr context
>> + * @param[in] pts   timestamp for the next input sample, INT64_MIN if unknown
>>    * @see swr_set_compensation(), swr_drop_output(), and swr_inject_silence() are
>>    *      function used internally for timestamp compensation.
>>    * @return the output timestamp for the next output sample
>> @@ -636,8 +636,8 @@ int swr_convert_frame(SwrContext *swr,
>>    * @see swr_close();
>>    *
>>    * @param swr             audio resample context
>> - * @param output          output AVFrame
>> - * @param input           input AVFrame
>> + * @param output          out   AVFrame
>> + * @param input           in    AVFrame
>
> @param out             output AVFrame
> @param in              input AVFrame
>

Whoops, thanks. Fixed, will wait a bit in case there are other
reviews before I send a v2.

>>    * @return                0 on success, AVERROR on failure.
>>    */
>>   int swr_config_frame(SwrContext *swr, const AVFrame *out, const AVFrame *in);
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libswresample/swresample.h b/libswresample/swresample.h
index 980be65783..83821a0930 100644
--- a/libswresample/swresample.h
+++ b/libswresample/swresample.h
@@ -354,8 +354,8 @@  int swr_convert(struct SwrContext *s, uint8_t **out, int out_count,
  *              in this case the output timestamps will match output sample numbers.
  *              See ffmpeg-resampler(1) for the two modes of compensation.
  *
- * @param s[in]     initialized Swr context
- * @param pts[in]   timestamp for the next input sample, INT64_MIN if unknown
+ * @param[in] s     initialized Swr context
+ * @param[in] pts   timestamp for the next input sample, INT64_MIN if unknown
  * @see swr_set_compensation(), swr_drop_output(), and swr_inject_silence() are
  *      function used internally for timestamp compensation.
  * @return the output timestamp for the next output sample
@@ -636,8 +636,8 @@  int swr_convert_frame(SwrContext *swr,
  * @see swr_close();
  *
  * @param swr             audio resample context
- * @param output          output AVFrame
- * @param input           input AVFrame
+ * @param output          out   AVFrame
+ * @param input           in    AVFrame
  * @return                0 on success, AVERROR on failure.
  */
 int swr_config_frame(SwrContext *swr, const AVFrame *out, const AVFrame *in);