diff mbox series

[FFmpeg-devel,v6,3/3] fate/flac: Add test of 32 bps encoding/decoding

Message ID 20220916201415.2583646-4-mvanb1@gmail.com
State Superseded
Headers show
Series 32bps FLAC patches | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Martijn van Beurden Sept. 16, 2022, 8:14 p.m. UTC
---
 tests/fate/flac.mak | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andreas Rheinhardt Oct. 4, 2022, 3:14 p.m. UTC | #1
Martijn van Beurden:
> ---
>  tests/fate/flac.mak | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
> index 115cc965e1..3424b2bf82 100644
> --- a/tests/fate/flac.mak
> +++ b/tests/fate/flac.mak
> @@ -6,6 +6,7 @@ FATE_FLAC += fate-flac-16-chmode-indep                                  \
>               fate-flac-16-lpc-cholesky                                  \
>               fate-flac-16-lpc-levinson                                  \
>               fate-flac-24-comp-8                                        \
> +             fate-flac-32-wasted-bits                                   \
>               fate-flac-rice-params                                      \
>  
>  fate-flac-16-chmode-%: OPTS = -ch_mode $(@:fate-flac-16-chmode-%=%)
> @@ -20,6 +21,9 @@ fate-flac-24-comp-%: OPTS = -compression_level $(@:fate-flac-24-comp-%=%)
>  fate-flac-24-%: REF = $(SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav
>  fate-flac-24-%: CMD = enc_dec_pcm flac wav s24le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac $(OPTS)
>  
> +fate-flac-32-wasted-bits: REF = $(SAMPLES)/audio-reference/drums_2ch_44kHz_s32_wastedbits.wav
> +fate-flac-32-wasted-bits: CMD = enc_dec_pcm flac wav s32le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac -strict experimental
> +
>  fate-flac-rice-params: REF = $(SAMPLES)/audio-reference/chorusnoise_2ch_44kHz_s16.wav
>  fate-flac-rice-params: CMD = enc_dec_pcm flac wav s16le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac
>  

Is the encoder bitexact, i.e. does it always produce the same output
regardless of plattform (this is different from the encoder's output
decoding exactly to the original input)?

- Andreas
Martijn van Beurden Oct. 4, 2022, 8:18 p.m. UTC | #2
Op di 4 okt. 2022 om 17:14 schreef Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
> Is the encoder bitexact, i.e. does it always produce the same output
> regardless of plattform (this is different from the encoder's output
> decoding exactly to the original input)?

I don't know but it seems unlikely to me. Of libFLAC I'm absolutely
sure it produces different outputs for different platforms. It seems
reasonable to assume ffmpeg won't be bitexact either.
diff mbox series

Patch

diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
index 115cc965e1..3424b2bf82 100644
--- a/tests/fate/flac.mak
+++ b/tests/fate/flac.mak
@@ -6,6 +6,7 @@  FATE_FLAC += fate-flac-16-chmode-indep                                  \
              fate-flac-16-lpc-cholesky                                  \
              fate-flac-16-lpc-levinson                                  \
              fate-flac-24-comp-8                                        \
+             fate-flac-32-wasted-bits                                   \
              fate-flac-rice-params                                      \
 
 fate-flac-16-chmode-%: OPTS = -ch_mode $(@:fate-flac-16-chmode-%=%)
@@ -20,6 +21,9 @@  fate-flac-24-comp-%: OPTS = -compression_level $(@:fate-flac-24-comp-%=%)
 fate-flac-24-%: REF = $(SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav
 fate-flac-24-%: CMD = enc_dec_pcm flac wav s24le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac $(OPTS)
 
+fate-flac-32-wasted-bits: REF = $(SAMPLES)/audio-reference/drums_2ch_44kHz_s32_wastedbits.wav
+fate-flac-32-wasted-bits: CMD = enc_dec_pcm flac wav s32le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac -strict experimental
+
 fate-flac-rice-params: REF = $(SAMPLES)/audio-reference/chorusnoise_2ch_44kHz_s16.wav
 fate-flac-rice-params: CMD = enc_dec_pcm flac wav s16le $(subst $(SAMPLES),$(TARGET_SAMPLES),$(REF)) -c flac