| Message ID | 20220917095936.39330-1-remi@remlab.net |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
remi@remlab.net: > From: Rémi Denis-Courmont <remi@remlab.net> > > While this probably never overflows, we are better safe than sorry. > > The callback prototype should probably also use ptrdiff_t or size_t but > I diggress. > --- > libavcodec/vorbisdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c > index 38a5367be3..9728997370 100644 > --- a/libavcodec/vorbisdec.c > +++ b/libavcodec/vorbisdec.c > @@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr, > > void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize) > { > - int i; > + ptrdiff_t i; > for (i = 0; i < blocksize; i++) { > if (mag[i] > 0.0) { > if (ang[i] > 0.0) { We allow the C99 "for (ptrdiff_t i = 0;". - Andreas
diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index 38a5367be3..9728997370 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr, void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize) { - int i; + ptrdiff_t i; for (i = 0; i < blocksize; i++) { if (mag[i] > 0.0) { if (ang[i] > 0.0) {
From: Rémi Denis-Courmont <remi@remlab.net> While this probably never overflows, we are better safe than sorry. The callback prototype should probably also use ptrdiff_t or size_t but I diggress. --- libavcodec/vorbisdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)