From patchwork Sat Sep 17 21:15:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 37988 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1c:b0:96:9ee8:5cfd with SMTP id c28csp389305pzh; Sat, 17 Sep 2022 14:16:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM43xMhNBrns+QgCxVhy7+i6eEGraQBVund64JVwSIFGe/7DeVV/HF8zJK54rcJdBaKIZpTs X-Received: by 2002:a05:6402:27c8:b0:451:440a:2f48 with SMTP id c8-20020a05640227c800b00451440a2f48mr8958013ede.1.1663449381885; Sat, 17 Sep 2022 14:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663449381; cv=none; d=google.com; s=arc-20160816; b=ajT3KIIqpg6bLGRozSoJsPNo2HQAlJ4a+2YUPCRS9XSunH9lnsJnXYPHikK72tXdEa kufJiIpOJI/UEXL+Ndswn5Tf7w9RvUry69o9cwKyimD6qeQ1KvHUc08j72NjrKdnOfqe APGKhYqDVh8UTssaFXGyXmJwaigMGH6ir6Qj+ui39vkYnNB0tTsGNhVcOSOaBJXyL+YA kM26dnqoMwK/MojZYrdBd7yhsygxmmRz42y0ybThnllmWqCH19MUb3WYnucybf0lYQ/d /dlfR6HVE9mLDq0aN4AvDA+SHleFQgqdvtSQPR75FSt9j1+bdwdDf6KTOzdsqUCjbKQD lh5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=jrj1QAwW58kawV5v8IdkmuCajic6o7wJ3jBuy2LtgnU=; b=sQrUBxjRewpm9uFprwpNJ/1JGTEFANvpXH+ZHgh9c/VOyET4DO2HYpdUJ3r69DB+Jr XQ33/8yOXV7L4vVLnoAFJhnRKKBJAGwFJyhKjJw0HaoYGURCTnDElUbKodBLQwXx86/C WGl4vF5Hw+tseljUKXCyhPt/k6Q1lHCrOVhRTXzej+JBu5tyE1fXbnfEd+hIo6Io4GKm IPxNCxPyLWNnhpGOb/PulHo3bA/2jLn8G81KEdc51waCrOAED0OFMOzW+jWqT6iZCObJ nWkKkkC/mc9sQnsaVGnzAJt13MJHEi5ip+s8LDCcjsxJKT6dX8+i/KDgsDwAp2wBCE9D QVMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d11-20020a056402400b00b00453d55cb36csi155928eda.365.2022.09.17.14.16.21; Sat, 17 Sep 2022 14:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12BC668BBB2; Sun, 18 Sep 2022 00:16:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-at01-2.mx.upcmail.net (vie01a-dmta-at01-2.mx.upcmail.net [62.179.121.146]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4387768B9C0 for ; Sun, 18 Sep 2022 00:16:00 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at01.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1oZfAN-00GP11-FM for ffmpeg-devel@ffmpeg.org; Sat, 17 Sep 2022 23:15:59 +0200 Received: from ren-mail-psmtp-mg02. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id ZfAMoPQUB8s8UZfANoEt8F; Sat, 17 Sep 2022 23:15:59 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg02. with ESMTP id ZfANoy3fAbZLDZfANoILBU; Sat, 17 Sep 2022 23:15:59 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=6326390f a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=-_9i-eTdipuMXZ40kBcA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 17 Sep 2022 23:15:53 +0200 Message-Id: <20220917211557.11547-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220917211557.11547-1-michael@niedermayer.cc> References: <20220917211557.11547-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfKq4dzuArM76/NQYEO8esUrYd/wGR+o9H8JdspmBJiwZ/HNIHdoZoOQSAS1nZKd+h80BO8gdwGZHODuVtRQFAsm9g6cq+cIEEhGC8pPbThrywiQapkfX yVs2opJftzUeWjVoArRQaM3+Z4p/1LPCNOzHTxhrhT2zXoNe2p1QCHtOtTAKaBj5pvMXrfqOXPe7Ag== Subject: [FFmpeg-devel] [PATCH 5/9] avformat/dhav: Use 64bit seek_back X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: bmEUp/ValK4v Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_DHAV_fuzzer-6604736532447232 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/dhav.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dhav.c b/libavformat/dhav.c index 9d26efe8fc9..4e720f2a26c 100644 --- a/libavformat/dhav.c +++ b/libavformat/dhav.c @@ -242,7 +242,7 @@ static int64_t get_duration(AVFormatContext *s) avio_seek(s->pb, avio_size(s->pb) - 8, SEEK_SET); while (avio_tell(s->pb) > 12 && max_interations--) { if (avio_rl32(s->pb) == MKTAG('d','h','a','v')) { - int seek_back = avio_rl32(s->pb); + int64_t seek_back = avio_rl32(s->pb); avio_seek(s->pb, -seek_back, SEEK_CUR); read_chunk(s);