From patchwork Sun Sep 18 17:14:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 38010 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1c:b0:96:9ee8:5cfd with SMTP id c28csp790919pzh; Sun, 18 Sep 2022 10:14:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5zl4BIwq2C16aEIXvA4xjQJMqyXee6/V5/DFDhR+Qqkd7j/bhUetuMAsTaxnT8IEfVSgZT X-Received: by 2002:a17:907:1df1:b0:779:4f57:6bb2 with SMTP id og49-20020a1709071df100b007794f576bb2mr10413152ejc.407.1663521298008; Sun, 18 Sep 2022 10:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663521298; cv=none; d=google.com; s=arc-20160816; b=bdwelcVFm+ncDCUl5bZmP2c8zBysMTdhBLLEPGDzFwykOyOtDZ/rm5s/XHFqQ/BjEM ERnC6Tr7aIl4q4JsFqwCkAVTJrvk9Zmgb680aFQXsW3rtHJZU/iTVLXK3mNjK2b8g3Le kRJW4BqWyU9lGXAKkaZmDfXt1B3/j9iiAisJ3Rq7vtIfOuqc1qtpY+XDLbNylr13+k2/ Ev4owuPC64Q8BffV4tNzWWxr2lKHhwZybZZykd0tqlK88cDoJhqAjjUhPPKu3oUVx2my tkvv90MvG+Yd3wM5Fh0jV2uaZz6ndGv+HeOMg9Ae8X0YUS/yE5LinUsQ1mwOCxSQ4bWC Vh9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=mbSUzZRCevDxEYuP06G82hFbovAjbo+Mg4MMyZnpnrI=; b=Wm3hjXYGycYt5wid4ewL0E7JYvp1UO44MxJgobZOZ6E8V3I7YbU0gNj9zU8VO9sfHP 64T3xcq6IcgMv3qIEOnSmR91I68k5jn+EyE6r/FzH6nfpFkEJNy4vtC/lsfpQocYIkaS mURq3G4i94A0hk9+AMRQ043ApzFYRRBJoy38kDigGeMl4E6VpodiIeT3096aEc+0jl7n +n5yjL5Heemkb7+5BWwy1GPbOcFddniG6aK30F2N0Aw1ft3KdlAp445Hi7LCPJ1tzchQ c7Z/K67AsQJyUjItTgVtJj1B87nZqlD6p/aNv1GxxbLQwMRpnHo4s6rjhJHxoWkug8dJ 2Uxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id xc1-20020a170907074100b007806a566bc2si10246300ejb.457.2022.09.18.10.14.57; Sun, 18 Sep 2022 10:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4690468BB99; Sun, 18 Sep 2022 20:14:23 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-at03-1.mx.upcmail.net (vie01a-dmta-at03-1.mx.upcmail.net [62.179.121.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F2AB68BAB9 for ; Sun, 18 Sep 2022 20:14:13 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1oZxrw-00EpF3-UQ for ffmpeg-devel@ffmpeg.org; Sun, 18 Sep 2022 19:14:12 +0200 Received: from ren-mail-psmtp-mg01. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id Zxrtolzzy8s8UZxrwoH67A; Sun, 18 Sep 2022 19:14:12 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg01. with ESMTP id ZxrwoprDWOG5ZZxrwonHig; Sun, 18 Sep 2022 19:14:12 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=KJo5sHJo c=1 sm=1 tr=0 ts=632751e4 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=szEW-crVBjs0wOCdKpIA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Sep 2022 19:14:06 +0200 Message-Id: <20220918171410.31835-9-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220918171410.31835-1-michael@niedermayer.cc> References: <20220918171410.31835-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfF2HMG47EhbXeicF2ElTeURRlJxsumEeX1rHC4CqCix3UrXTjhBVuorQGqC7Mx1oZFuD4pTXVI/6i+hEa29qK8iizAJjwJ0YB5Q/KB1pkBImB11Mo8Cc SGDNy8FESyJmA05wmEOm45ZQr8dZkF/LiCaUY/iM4n1gdFEC7bU4+FBgZ4xe2J6SxmSS8bEF5zjvKw== Subject: [FFmpeg-devel] [PATCH 09/13] avformat/rpl: Use 64bit for duration computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: NvsfRMR42fLp Fixes: signed integer overflow: 24709512 * 88 cannot be represented in type 'int' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6737973728641024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/rpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index d025589bfc3..3ef6fda3862 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -279,7 +279,7 @@ static int rpl_read_header(AVFormatContext *s) error |= read_line(pb, line, sizeof(line)); // size of "helpful" sprite if (vst) { error |= read_line(pb, line, sizeof(line)); // offset to key frame list - vst->duration = number_of_chunks * rpl->frames_per_chunk; + vst->duration = number_of_chunks * (int64_t)rpl->frames_per_chunk; } // Read the index