From patchwork Tue Oct 4 14:40:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Scholz X-Patchwork-Id: 38552 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4d9:b0:9c:f4b:4e41 with SMTP id 25csp157938pzd; Tue, 4 Oct 2022 07:40:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5pE3msnLpp1lyP4aDpbaRM5GDcXjVILpkTTzc3gkbSHbF7ZrLcnH4sBHZkWnyS8eoQL0Y9 X-Received: by 2002:a17:907:d15:b0:781:e347:723 with SMTP id gn21-20020a1709070d1500b00781e3470723mr19262121ejc.723.1664894423780; Tue, 04 Oct 2022 07:40:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664894423; cv=none; d=google.com; s=arc-20160816; b=kEhqFRkpqMn7szP3Vx0BtcmOvBwrcgrNQt9zisjr9yPmiB/W/a4WR2tdeYrtKGwCwZ aBMPWMgFASmu4tdqmExmprYXSoU1WNtS8qB+ZQee/irrjcsj+LEXNRN5MaWJl2xQfRSW alnBhj2W4ShdMnUxNDiJLcFQoNT35jX+3GHrub+tGlPglrgTbIkoe4+gC0+lQdCkxQhu ENZWAkFHUSSU26+Oed85Flise4CdsIyQ8GBCOxkPUVJKXn5cKe7vPJI4XWouQVeL1jFW OBU5XqLScnTktEZaUOqia4V6VyEQFcXPpUm455SaW/SplzEOm4B3cZ1EfcVM2B4U7rk0 j9kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=5YdsdKqMsvcXqdPyP24gB468UK1nGC/PHQHn0/q9Gwc=; b=G/q/E1rn2JSWgr95E2iHuAeCUZDihD7Y5zXJI4xf1aI7KtZibOxw+MDxilwTWWlfi7 dcIbqxFCezu/xmNuIwk+FV8CPoYSmo8mG+MKJzMpGwR1Q0kz/0P+8AFxRMVN9Y3awj1W d4sG1xnYhugWhSw6H5kEhEwFV3EAvv/rYnNbYhrzakmxHPG7Z0P8PejFdkMPAIIqOgXi yvMKQ4zh3SiTzjEA59jVhB6pgxQVGXjXU4P9w6hv7toH5RicRzBq/XgTH2qgZTamFakb S5Bb+TT7UB70LtcAX1AwHIWktPwQH1VE7Fs1dbmsO+XY/JiPCT3uq0VvqGXstvD96X8X G+cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=PRwqIzt4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id jr3-20020a170906a98300b007825337afeesi10191232ejb.273.2022.10.04.07.40.22; Tue, 04 Oct 2022 07:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=PRwqIzt4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C5FF68BC41; Tue, 4 Oct 2022 17:40:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 91BA668BA39 for ; Tue, 4 Oct 2022 17:40:14 +0300 (EEST) Received: by mail-ed1-f54.google.com with SMTP id x59so9144578ede.7 for ; Tue, 04 Oct 2022 07:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=yFWglonU7QTLQ7wGSf5VXsHonAIHXM4pltF5ImwY+Vo=; b=PRwqIzt4t5H46ERY7uJ3FhH5ekdQywA/4JQDW1elLqiC7ebzM3D9Y+OMsG9rgsh5rs g5XCPG7p5Kd2X7iVs5ig03vTAoR5m9Q3DpDXHb9+VkZOk28RpP5pqHg6YUXgVOzA57tK QnOZoAEhQ26Fk+4NDJmopAAwb/Zym7gofWPSeqzb0Wk2z5CJaH1x/VmKm0/+SUe7iavI OaKZgNR9zJwKeOwJkWDjOE826lAq93ZP11hTjgdoVrhAMRijda9mGHlwzUwWcPzRM7YZ G12Sey1jA4l98braNrPfr9hnDMkIS8zUeq+JyDjJzCPno8oVDm2yieWKRHrHrqLh/9xn pQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=yFWglonU7QTLQ7wGSf5VXsHonAIHXM4pltF5ImwY+Vo=; b=ftmzZSo3P2fnFJ/CeleoB+8L87GIfvIYz+qmLPsntlVsUbw4QmKF/q9xIlf01J+EVI VrWJFqBCivJLAwQcpIBUKG83GRcvFZykZrEP4MRWm/oAbAwM78IS3zANNwZQmZ3VvDy5 AbM9Zjs5klGNfCPxD886oLdEuKKWOQMKxe3maggAW/sqfuaIm5g5JJL5T5e+v6pyM8V1 KMm8Ar+65YGvXirFIXtJMmvKz0qyk+7BLaIn7k8hy7cVznIKPVkyRFW/0rVJBoD91TDe f2G8RciS8RJv9gJPms18k/TyS4PD9OaevGCYCTbdw11vAWamLlAS8zWFfx6rtvjad3a/ 1sJg== X-Gm-Message-State: ACrzQf00crkghs8FoWjaPkagylVfRSvVXZD4+859GPWTSCqBOXxZNO0j Q0lOB/C1sbKrVB64Y6JD+VGT9TmMm9g1Ow== X-Received: by 2002:a50:bb68:0:b0:458:abbd:faf9 with SMTP id y95-20020a50bb68000000b00458abbdfaf9mr15101457ede.177.1664894413426; Tue, 04 Oct 2022 07:40:13 -0700 (PDT) Received: from localhost.localdomain (84-112-104-25.cable.dynamic.surfer.at. [84.112.104.25]) by smtp.gmail.com with ESMTPSA id y21-20020a1709064b1500b00722e50dab2csm7190554eju.109.2022.10.04.07.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 07:40:12 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Oct 2022 16:40:06 +0200 Message-Id: <20221004144008.89188-1-epirat07@gmail.com> X-Mailer: git-send-email 2.37.0 (Apple Git-136) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Use av_err2str X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marvin Scholz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: oWceYEqwcOJ0 av_err2str which is a wrapper for av_strerror already calls strerror_r if available and if not has a fallback for the other error codes that would be handled by that, so manually calling strerror again if it fails is not necessary. --- fftools/cmdutils.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index f911c52be2..beef8ce385 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -798,12 +798,7 @@ do { \ void print_error(const char *filename, int err) { - char errbuf[128]; - const char *errbuf_ptr = errbuf; - - if (av_strerror(err, errbuf, sizeof(errbuf)) < 0) - errbuf_ptr = strerror(AVUNERROR(err)); - av_log(NULL, AV_LOG_ERROR, "%s: %s\n", filename, errbuf_ptr); + av_log(NULL, AV_LOG_ERROR, "%s: %s\n", filename, av_err2str(err)); } int read_yesno(void)