From patchwork Sun Oct 9 13:14:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Reimar_D=C3=B6ffinger?= X-Patchwork-Id: 38627 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:789c:b0:9c:c2cd:5584 with SMTP id bf28csp881067pzc; Sun, 9 Oct 2022 06:14:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4eOGpheRsQiCZ7erl/5JdrMcZ4zebzdPYTbY6FEcu8hjuLVL2lyuSeCpdfin99cNnWClka X-Received: by 2002:a17:907:1b12:b0:72f:9b44:f9e with SMTP id mp18-20020a1709071b1200b0072f9b440f9emr11215944ejc.653.1665321299032; Sun, 09 Oct 2022 06:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665321299; cv=none; d=google.com; s=arc-20160816; b=cHt44ckf6Hh9egUS7DvlHA01vA1jdQV1k0P25gB3EI/kcX/TagRcepIawHclk5uLBK qqqv3/X6LRYccaxiJQSt5wvEyzziXxHOb1N4FItLv6tYsvRIMuIKXhwS8rYMGWP+gvjd /Xjlxs6nLmuFCILkyaRfsXfEF+3f9cBkxfq60U6igT22s1JILzINU8roMRabzBmibTwv 7MW1TIJ3xvjeup5BhRGAOmf8BPcLplqm0OPq5FOz6aH9N9P6BFN88iGm6F9B7qCJTM0J 1W1wrk74r4oPHrj74LNNmwywF0kStoaApiEBZUg8hS3oa+oCZyRf4W01tZLuEfF6YsRb 6h9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=Vxce2XhyM5cZOniQCOad1OknM1b83oU9BplmY8lBOZ4=; b=xSHYmJ+a8y7OPMbJqUKs4TclKycRMkLFQ/XFG6M1/vgJtWyUKQIDKB2N/TB2O6OGiS mZ6DNFhiw1X0LRaVVSzGdIGs5IbcvLGSIsT5AM2NEoq60mxk2Zvbx5yPR8PMcjH77OjI L7MogSmsQngCGAU9bqmeOMAuaITlgshquX4nXXYjEHOCipvaj/PBpBQyjnKXCfOSie// mVxfVFHK/A8kBnlC7irM2wdkzfGz4m02quoOJ80kLB33rM4gxspHW8FqQDzRQjfsRztr KSP1yze1ZxU/rWIa0ZpZajVgbFwbjkTZ3c1pQ1HVIaWmnPXkwGiNq43ELcxxcyHyStu7 UXWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.de Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w22-20020a056402269600b0045895e80ebfsi9132019edd.53.2022.10.09.06.14.58; Sun, 09 Oct 2022 06:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E943C68BB99; Sun, 9 Oct 2022 16:14:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71CCF68BA09 for ; Sun, 9 Oct 2022 16:14:48 +0300 (EEST) Received: from localhost ([94.254.63.29]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MQ5jC-1oUGaF2duq-00M6rr for ; Sun, 09 Oct 2022 15:14:47 +0200 From: =?utf-8?q?Reimar_D=C3=B6ffinger?= To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Oct 2022 15:14:47 +0200 Message-Id: <20221009131447.5001-1-Reimar.Doeffinger@gmx.de> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:a1JShzB7nOcA4iVUmu8A/l9BDn/09IKlrKSQsn/uqqfurerbDIX /jzdzEmeDZYoBQoeqP7jFCTOBU6Nyi3uX5NNS0StemFHmTxnixWUHrH7bKocHBreB0fJWWD 9tiIzjr8Qw6korWpdWS2h+Ofa544wZlW4irZw3osZY0of1pxm9U1JBRMp7Uo1zKtW17LzCq 0rIeRs36xpB2hk+56oebQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EzzvYT8kqR0=:Tmmc6sX3OzNbnEsMDYLtnI SB3J/DyB3ntUN5fIcUlyTYOOH+ZP62Civ9mb2JQtbKej93ypVcarNm5ujJkO4MNWz8I+dSp7v 0AOYAXFq2ApetaHxzuBRU2dw7ClV+trszuji2pD9XgaQlMaWY3VnOmZRBcNDdbKuVcvXqYPWr OHClPZ2F9yEnxjxb3Zu8ebh2tkkB6EivDpQ5D9H1tn5rP0tUQhWpsMtfUHwy+mVamxOYXSxj1 uSWvZ05g7iNRBrgGNz7UTGT5+P27PWU4fDLSy21duxnuIldPRNCipudnSawx0xSRAPmfvJApd DUN3s4KESi1I7siX6Vmcj8xwfPKTox0Jgu+vMrkBkiTX2psKLm8cgN8a0Hrk34DgNkzZoJDGN q+YmYu1cmqtxO//3QxBlcmFGpkYqChtMOrjOXzAK+ogtWi93kF8DOhG5IIjLZi9OM8tQ/iX0G BjVMEGYXl/IJp3PPihs2oxOBUZkyYpVrTN2xj/yVUCB7pMyrzAt+9kl74QBmKpVspA/NeJJPy Cd/nPglbKhxMJ896CIT0TcXXm8wuLqUyes8S9TDQO4oDrg93PacZvEGeKsC7SfPJcqs4U7cA8 9EoLPyjIIkrdJtvfn5ZGibUK/IFtRLhypYp/N9RnznQYgskcGmC3HB5cB1waDrm+PdDjYB/Lq acqnv+1dC3i82+BYbl8IchzNWcsj/97VqH9YuTEGGEJwDYrYBqfF64d+R8/2UDTK3sLrq92PE SPI1zCvly0N+gqDQ1JOsf7TpJ6d24OBxkm553PtmLbaeNVl7EygvoJgeiCNA2qhiejB3d0MTS rI/3tezpjyWoG/BRh2sGjbk7q4OpQ== Subject: [FFmpeg-devel] [PATCH] tx_float_neon: Do not access outside stack. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: eJ4M2p92Bo6t Use load/store instructions that modify sp to save registers to stack, like it is done for all other functions. At least valgrind complains about the current code. --- libavutil/aarch64/tx_float_neon.S | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavutil/aarch64/tx_float_neon.S b/libavutil/aarch64/tx_float_neon.S index 4126c3b812..4be93cc963 100644 --- a/libavutil/aarch64/tx_float_neon.S +++ b/libavutil/aarch64/tx_float_neon.S @@ -866,10 +866,10 @@ FFT16_FN ns_float, 1 .macro FFT32_FN name, no_perm function ff_tx_fft32_\name\()_neon, export=1 - stp d8, d9, [sp, #-16] - stp d10, d11, [sp, #-32] - stp d12, d13, [sp, #-48] - stp d14, d15, [sp, #-64] + stp d8, d9, [sp, #-16]! + stp d10, d11, [sp, #-16]! + stp d12, d13, [sp, #-16]! + stp d14, d15, [sp, #-16]! LOAD_SUBADD SETUP_SR_RECOMB 32, x7, x8, x9 @@ -911,10 +911,10 @@ function ff_tx_fft32_\name\()_neon, export=1 zip2 v31.2d, v11.2d, v15.2d st1 { v28.4s, v29.4s, v30.4s, v31.4s }, [x1] - ldp d14, d15, [sp, #-64] - ldp d12, d13, [sp, #-48] - ldp d10, d11, [sp, #-32] - ldp d8, d9, [sp, #-16] + ldp d14, d15, [sp], #16 + ldp d12, d13, [sp], #16 + ldp d10, d11, [sp], #16 + ldp d8, d9, [sp], #16 ret endfunc