diff mbox series

[FFmpeg-devel] configure: add pkg-config check for OpenAL

Message ID 20221029171244.16291-1-timo@rothenpieler.org
State Accepted
Commit d77241923780b8fcf117efc5d35d3ac9787b927e
Headers show
Series [FFmpeg-devel] configure: add pkg-config check for OpenAL | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Timo Rothenpieler Oct. 29, 2022, 5:12 p.m. UTC 
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Philip Langdale Oct. 29, 2022, 5:25 p.m. UTC | #1 
On Sat, 29 Oct 2022 19:12:44 +0200
Timo Rothenpieler <timo@rothenpieler.org> wrote:

> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 70c9e41dcc..30f0ce4e26 100755
> --- a/configure
> +++ b/configure
> @@ -6757,7 +6757,8 @@ enabled mmal              && { check_lib mmal
> interface/mmal/mmal.h mmal_port_co check_lib mmal
> interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util
> -lmmal_vc_client -lbcm_host; } || die "ERROR: mmal not found" &&
> check_func_headers interface/mmal/mmal.h
> "MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS"; } -enabled openal
>  && { { for al_extralibs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32";
> do +enabled openal            && { check_pkg_config openal "openal >=
> 1.1" "AL/al.h" alGetError ||
> +                               { for al_extralibs in
> "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do check_lib openal
> 'AL/al.h' alGetError "${al_extralibs}" && break; done } || die
> "ERROR: openal not found"; } && { test_cpp_condition "AL/al.h"
> "defined(AL_VERSION_1_1)" ||

LGTM

--phil
diff mbox series

Patch

diff --git a/configure b/configure
index 70c9e41dcc..30f0ce4e26 100755
--- a/configure
+++ b/configure
@@ -6757,7 +6757,8 @@  enabled mmal              && { check_lib mmal interface/mmal/mmal.h mmal_port_co
                                  check_lib mmal interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host; } ||
                                die "ERROR: mmal not found" &&
                                check_func_headers interface/mmal/mmal.h "MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS"; }
-enabled openal            && { { for al_extralibs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do
+enabled openal            && { check_pkg_config openal "openal >= 1.1" "AL/al.h" alGetError ||
+                               { for al_extralibs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do
                                check_lib openal 'AL/al.h' alGetError "${al_extralibs}" && break; done } ||
                                die "ERROR: openal not found"; } &&
                              { test_cpp_condition "AL/al.h" "defined(AL_VERSION_1_1)" ||