From patchwork Sun Nov 6 12:34:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 39188 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp1529855pzb; Sun, 6 Nov 2022 04:34:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM5c0ToaePR29obKBN88yfS2oM9sLpzm/FSqEkH0na1/zr4KXrpY2gyRTXrwJvy8CqKqsPBE X-Received: by 2002:a17:906:6956:b0:7ae:3a0b:c6f6 with SMTP id c22-20020a170906695600b007ae3a0bc6f6mr10971571ejs.383.1667738083274; Sun, 06 Nov 2022 04:34:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667738083; cv=none; d=google.com; s=arc-20160816; b=yETO2D7ldpFw4ukpwwoBg8Z2F3R31uawytps41HWEYC/cBy1/5tjkHZ/hKIHK5APfF mvQvfub54hGktGslnwOihiXtcPv2rjH1dN6zwgMsAUySxDmKkmZN3llTxMU2X7T3+PfB DD/vutKZ+J5+phpARQbhshsI+PiVvVOCJsxMAc1CP0QVgTq3Ur2EbbbhW+AXdx3VxCgR Pc2qohbTJ7r4dnXDSmPvoLyCO/d6WAH+5+h4zz8Ah+sL+tmgbpGUvjQCJMJwN2arXALg 4qBjaCH4pytGgz8V0u0fwDGs6Xc88HvhJ74RI4ixtueMNijYKD6kCNXpgLXHEAycBNhi 3vOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=di78MPso/iuKueygiYlrcDhM7BeFK9UKaJnYXYrXEbA=; b=s0esp4vSFBOcWo2g3kGK6djth8l7v1wAN2kHm44gnQ1FmwkBub078/JOApRyu+RZBK nptcLbgLTNYqmTb6aK8DliyxEayfFX2o+8IyZ1SNLl8FUr2yXlLiCpSF71PMnLGMnZbf ZQgXBGbInnkHnDW26VX/QHVZlT6KMopDVxmkgwY4WA5Zle8AJGft/PJg6WlfxdYyZGBK gFyaV7p+9ktGJyup/jmRthoTX9oLi2RHzFyP7pvKw5v/NKwgWC+V3d488oEMDAThfXhY YW1Rvyuw+3LM+aMUOB59KgxGKgnALWnT2IyjYbgxf57YiKfJCdmOAjOzLOkg6QgtmJG+ LwAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s4-20020a056402520400b004523826ed6dsi6645865edd.554.2022.11.06.04.34.42; Sun, 06 Nov 2022 04:34:43 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C1CF68B5B3; Sun, 6 Nov 2022 14:34:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 063D2680A26 for ; Sun, 6 Nov 2022 14:34:32 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 1A7CB1BF207 for ; Sun, 6 Nov 2022 12:34:31 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 6 Nov 2022 13:34:24 +0100 Message-Id: <20221106123430.1668-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH 1/7] avcodec/bonk: Use unsigned in predictor_calc_error() to avoid undefined overflows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: v/eyu6TaakTR Fixes: signed integer overflow: 22 * -2107998208 cannot be represented in type 'int' Fixes: 51363/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-5660734784143360 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bonk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c index 1695229dbd..9e8892e4db 100644 --- a/libavcodec/bonk.c +++ b/libavcodec/bonk.c @@ -278,7 +278,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error) *state_ptr = &(state[order-2]); for (i = order-2; i >= 0; i--, k_ptr--, state_ptr--) { - int k_value = *k_ptr, state_value = *state_ptr; + unsigned k_value = *k_ptr, state_value = *state_ptr; x -= shift_down(k_value * state_value, LATTICE_SHIFT); state_ptr[1] = state_value + shift_down(k_value * x, LATTICE_SHIFT);