Message ID | 20221106123430.1668-5-michael@niedermayer.cc |
---|---|
State | Accepted |
Commit | 104b516a13c3281e020fbaf751185b368baae5af |
Headers | show |
Series | [FFmpeg-devel,1/7] avcodec/bonk: Use unsigned in predictor_calc_error() to avoid undefined overflows | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | fail | Make failed |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
On 11/6/22, Michael Niedermayer <michael@niedermayer.cc> wrote: > also the original reference code does not contain a 0 check > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/bonk.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index 99dac0b951..37ad7854b6 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -203,8 +203,6 @@ static int intlist_read(BonkContext *s, int *buf, int > entries, int base_2_part) > } > > if (step < 256) { > - if (step == 0) > - return AVERROR_INVALIDDATA; > step = 65536 / step; > dominant = !dominant; > } > -- > 2.17.1 > Not sure, at your risk. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c index 99dac0b951..37ad7854b6 100644 --- a/libavcodec/bonk.c +++ b/libavcodec/bonk.c @@ -203,8 +203,6 @@ static int intlist_read(BonkContext *s, int *buf, int entries, int base_2_part) } if (step < 256) { - if (step == 0) - return AVERROR_INVALIDDATA; step = 65536 / step; dominant = !dominant; }
also the original reference code does not contain a 0 check Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/bonk.c | 2 -- 1 file changed, 2 deletions(-)