From patchwork Sun Nov 6 12:34:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 39192 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp1530060pzb; Sun, 6 Nov 2022 04:35:17 -0800 (PST) X-Google-Smtp-Source: AMsMyM5ifQXF4sRb/5ps7zwcpK+Hfii9lsKdQHBJmjh4Sl7IUJm//sX+5b48EFBC/RN7tIWbsh4s X-Received: by 2002:a17:907:984:b0:77f:4d95:9e2f with SMTP id bf4-20020a170907098400b0077f4d959e2fmr43320630ejc.176.1667738117258; Sun, 06 Nov 2022 04:35:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667738117; cv=none; d=google.com; s=arc-20160816; b=bA7xGQYb/7+6TDxCW5AjbZ3d0tv57eF5eNyzkEFmRnnCym4C+gWN3/8bHcWGj9eUiL QaC848fGjRV5SqO2t2JmicKENZUqFMzAtwTo1QkJJvRKv7jeA1HQ6OaaFlMJiFZbEgLM EZqBBX8nFyG+whXmS02ZoyqvgHhhFVpJrNHef/BNK/Ffdsyw7cRhi0HkK5Nee4YhPval ykbcqMq0lg/xDwYC16w0dbxfGC9DDjDwet3MtVmrGtV7uy3ekHPrKWlWq2flXugTIhx8 6wepaWGiQgXKojCsG+pptUUPs0H7LVDxLF+NEOlMwNAmuVlB+JizYYamQ2TRIJMLtUUt 169Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=BDLc5GlsfztHW5GHeZdMF/R0pnX4C8tLcSI29LNY9zc=; b=uwZlX+KbPUiPfQMZQea9zPDs83TAxYsA5wCd6ocJdQ0fTyvsd7rIKs04jbJNiWdED3 S3O/pyDNmVwJyH40ho7n8n6h9TeB3VDyQM4kkkzSuToerv0qPMDQhNccz/Z6IcVRPAJG m4qFzlq5QbpeVCi7w2fa1tEpjkId6FFytesuZXwnibnJ4yuaSeMz7J+bEB5jgiRIlGFk ID6M9QZoVvEEFCf2O9iFzwI8ZBVR2EMgrxcwxHiAJsj++7AIFzf++qHQwuUX5akK6gio XKHE9pYnRDRHueN9K1bXg8CHLcv0t8Ei/9zP2VL/kflzyBDhw050u9DckT2ykRf25Fya zhtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y14-20020a17090668ce00b0078e071ddcb0si4211236ejr.478.2022.11.06.04.35.15; Sun, 06 Nov 2022 04:35:17 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E77268B75F; Sun, 6 Nov 2022 14:34:47 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 885E668B6EC for ; Sun, 6 Nov 2022 14:34:39 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E24EC40008 for ; Sun, 6 Nov 2022 12:34:38 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 6 Nov 2022 13:34:28 +0100 Message-Id: <20221106123430.1668-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221106123430.1668-1-michael@niedermayer.cc> References: <20221106123430.1668-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 5/7] avcodec/bonk: step cannot become 0 without overflowing which is undefined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 1vXBZyPJz9Nw also the original reference code does not contain a 0 check Signed-off-by: Michael Niedermayer --- libavcodec/bonk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c index 99dac0b951..37ad7854b6 100644 --- a/libavcodec/bonk.c +++ b/libavcodec/bonk.c @@ -203,8 +203,6 @@ static int intlist_read(BonkContext *s, int *buf, int entries, int base_2_part) } if (step < 256) { - if (step == 0) - return AVERROR_INVALIDDATA; step = 65536 / step; dominant = !dominant; }