From patchwork Wed Nov 9 22:31:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Foucu X-Patchwork-Id: 39246 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp581815pzb; Wed, 9 Nov 2022 14:33:59 -0800 (PST) X-Google-Smtp-Source: AMsMyM436jmnwLs7HUkh8vVvdBo/N/NRPPkzQR/Ebn8L9XVFuJaBY0mxyQ0Dt/tQ6cC44AX9vtpE X-Received: by 2002:a17:906:3607:b0:7ad:a798:cdc0 with SMTP id q7-20020a170906360700b007ada798cdc0mr57097622ejb.357.1668033239125; Wed, 09 Nov 2022 14:33:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668033239; cv=none; d=google.com; s=arc-20160816; b=FGNYpE7j1QnZsZj0Rc1ArwvpAQoa5VSyy8V5KO3iS24EnUvralcd7h5Jfoo1hUeoAM ifW+/uq8aj7P9/njqNltNF3NffG73HjOo3LryR02xQJ5ddQ/3ZD1PPXxE/4ZU31ATg5j QCJowTWqKBQ7OGCeNm5b7dfJKyHITfrNY2FIu6h7nzAcDBfiCPQtqoSm1E5pIKBSZLQX PEEfQSlCVh5mpvR8a2+ni5+EW3KoEouyUPhEPelqiR/WOd/U37gQ8YS7yF0CIGVHI+Wc DVFkeLnvLpHyuFUxpulehFDLLUcjPmsfWdVNbz5B1+asHAxMnDrTj7ujsSH5C3ZjqpMg rVbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=G1cj77MTI/7C6sjp91LOiw8l2uN2iKIlxHlZQ/oohHc=; b=u4B1SGOUO6Dq25g0/rUdhZfMl3QZCveJc3sHVhW522cOVfmhYMPT7PoFpvkAojtmDb po8pVXZ/0drbhLyQW4cvJ3NXNeFr3LkCugMMI9pNiDGLVKnPzuD76CJcbaJfkqCBzNV2 o3xvP2pmeJq6U7ehBh/fpj5HmhwGaDBnbYndvyVsqP7gsoVYPeSMFnh7DKviXVY49szy OVH7u4vvq0WEGS5ZXBVIDst1AOMjGncwhm5YBJhZV+X+woMYkcWCD71Jl9gbwIagrK6p a/v4aM89i9aor8yQ4skfUDYjSQ8D70FbFm+o/XAs5cHditA57JgDiulUuWK2bvZ12buf 2cww== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="bLgdI/Jj"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id xc2-20020a170907074200b0073ce34d1a13si16713052ejb.499.2022.11.09.14.33.58; Wed, 09 Nov 2022 14:33:59 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="bLgdI/Jj"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 55ACB68B914; Thu, 10 Nov 2022 00:33:55 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB29A68B176 for ; Thu, 10 Nov 2022 00:33:48 +0200 (EET) Received: by mail-pj1-f49.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso53538pjc.5 for ; Wed, 09 Nov 2022 14:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8snpiTyo9q8/7w+OEhrP7Ke5FCff7yjea5s+pa6VczQ=; b=bLgdI/JjHmqhlnavgr+looKD2IDO5oSGxlqrih5Uxg7qOfijdfIzaqJapH14aPpeGp 5bmH4lxEmGywo1SYb/icEOFcnFdSqfVv2YAi+R+DZE5cJ4YuSNKuWt/TdM1yrqE0cxlE TIwFMgqpX0G1V0j1buSOxK92ssbRAJz/ywm+XGpqqgvy5/PvUYhntdd6hdzYzxXnMVyO lb97abGdR+bjgNjYfCvYr2YjhDJQ/LSWedm6pbOm5oG7NdwTH+Si98ALb+KTzu8SSfqr i7Y9h4gz8q/6xFmsuMqJ0jGsDIabTRYsABQ1Kg/e3zIEwmhM6kzuh35qiuOMguHX/y1I y3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8snpiTyo9q8/7w+OEhrP7Ke5FCff7yjea5s+pa6VczQ=; b=RMKpnJjYUFvIeeO0MaTB8+ISl8jl7zAZfRaP9cKZTfn4gWeI3XERw6d5K05iEElLjH mug7hm0Hk2J31a4RbloHAm+IrmnOXAIfdFTKoCvWMx/nksWLeoWpXvnnYXiDggk8CIyY MCHIwADu+3OoiG1uzu799trfKE2Gk5DP0cLStPJtDYU01cwyWz9wUtgoIA0ycKlZRuP8 h+5Cqg3QY+dp3OXjgKEoWgbdjkgi789F4l/0JrBQ4qKu2/Xk2y1uIT/cCVB8fodjPjQE l4HnCfWbasd4k8elShvQywyXnfEmFiceRU4SHcztTK40yWpokIyzI6mrkWAjfuvxOGmH lL9A== X-Gm-Message-State: ACrzQf3vKkYL1ORKVCcOGJcMRA3xsYGDYublnwfaSl2gofgM3Emc0YTJ BnAcMIcSe3u7HKemHp6BV6QBqhG2zMR6KA== X-Received: by 2002:a17:90b:f94:b0:213:cc9a:1b38 with SMTP id ft20-20020a17090b0f9400b00213cc9a1b38mr56922385pjb.59.1668033225936; Wed, 09 Nov 2022 14:33:45 -0800 (PST) Received: from tfoucu2.mtv.corp.google.com ([2620:0:1000:4011:7dda:9946:aeda:5c08]) by smtp.gmail.com with ESMTPSA id w3-20020a628203000000b00562784609fbsm8692794pfd.209.2022.11.09.14.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 14:33:44 -0800 (PST) From: Thierry Foucu To: ffmpeg-devel@ffmpeg.org Date: Wed, 9 Nov 2022 14:31:32 -0800 Message-Id: <20221109223132.1795504-1-tfoucu@gmail.com> X-Mailer: git-send-email 2.38.1.493.g58b659f92b-goog MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] motion_est: fixed signed_integer_overflow when computing score X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thierry Foucu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ijnB/XJK/mB0 --- libavcodec/motion_est.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index d17ffe42b4..95978d95dd 100644 --- a/libavcodec/motion_est.c +++ b/libavcodec/motion_est.c @@ -1571,7 +1571,7 @@ void ff_estimate_b_frame_motion(MpegEncContext * s, type= CANDIDATE_MB_TYPE_BACKWARD_I; } - score= ((unsigned)(score*score + 128*256))>>16; + score= ((uint64_t)(score)*(uint64_t)(score) + 128*256)>>16; c->mc_mb_var_sum_temp += score; s->mc_mb_var[mb_y*s->mb_stride + mb_x] = score; //FIXME use SSE }