From patchwork Mon Nov 14 09:13:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 39270 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp2305016pzb; Mon, 14 Nov 2022 01:14:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf79ctUZRuakAeC++9O9T893OCbvOeUHfHxZ8SdXBPHdvPA/Rc2evyLinHNypH+5/1X44rzW X-Received: by 2002:a17:906:7ac7:b0:7a5:7e25:5b11 with SMTP id k7-20020a1709067ac700b007a57e255b11mr9250388ejo.254.1668417242092; Mon, 14 Nov 2022 01:14:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668417242; cv=none; d=google.com; s=arc-20160816; b=Ea7L2ZFzDy9MR4vYOOczs8nx9RMyZYj+GgPL1+0CJPyuY2UWjkrMMAb01BI0qPAjmV BL1W7IyGLchlcC4JYihOIKFV/2jbtmDG6nuGoE75l0MkoaICpApC/MzCzrl47P4j0mts ruKLDdc4fdwE0XAL0+aH7OR9Gp2j2gVvPQlcbdCcKGC+PqRk75CqJlAxuIjYZA6/qxIq 3Tbt0mo/cJhvS6CKVtlunBur/7zb2w4hcT7grCziqYxdvsi0bi5xwV6gk6W6fQPp0V55 V8aq5fFqn3a2LZ9Jqrdpd+KPcD/4zJ4lItd5YFHN8dvuevaMtg4E6pz/YCrmPsA6UHY+ VIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=1gaMhMGM9gpYR5X/vrnrP4U7P0ttMIbcTVqZOae5r4w=; b=KWJ2kLoSBuO7a7vt2Uh59ONl9Z8B7//evsBohMOLemIaZlQv1QoIadDTXugOH512LD 224Q65ZtfROTe1YLmCUpYl5ySt3JJebb9AMVcAoi28qMvrOtZ5jmMHJLOEmaMeF8osSu cbGRw2B7RhtlURD3gYpbslAZo1X1nhegZlRRLBqUaNb+F49MV8eOvlR12ifkxp46nVhG dQ3AEjO1VfUVFhRcdYwnueoBrhj1KYe3RNoqe7xTNVyzRXZyGyT40aDrRdu1Ue24AYA+ L8FTpDoxdyp8gCLvqeECQur+C5CYbYPMJ7NEMiZQZrVzKeSdSaReoLgsJ/gYaGj5zNPM 3JBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q21-20020a50cc95000000b00462af00c12bsi7694057edi.398.2022.11.14.01.14.00; Mon, 14 Nov 2022 01:14:02 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04B1D68BD6B; Mon, 14 Nov 2022 11:13:36 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B599468BD5A for ; Mon, 14 Nov 2022 11:13:27 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7693D2404F8 for ; Mon, 14 Nov 2022 10:13:27 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id TlBtpW9caLNO for ; Mon, 14 Nov 2022 10:13:25 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 17494240499 for ; Mon, 14 Nov 2022 10:13:25 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 804443A054D for ; Mon, 14 Nov 2022 10:13:17 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Nov 2022 10:13:09 +0100 Message-Id: <20221114091309.15755-4-anton@khirnov.net> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114091309.15755-1-anton@khirnov.net> References: <20221114091309.15755-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/4] doc/developer.texi: refine the "contributing code" section X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: wHJYNd8TN1/Q Drop the reference to directly committing code, because - it is highly discouraged and very rarely done these days - there is no good reason NOT to submit patches for review Add a link to the development policy chapter. --- doc/developer.texi | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index 2e050edc6a..cf918ac6b1 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -46,15 +46,10 @@ consult @url{https://ffmpeg.org/legal.html}. @section Contributing code -There are 2 ways by which code gets into FFmpeg: -@itemize @bullet -@item Submitting patches to the ffmpeg-devel mailing list. - See @ref{Submitting patches} for details. -@item Directly committing changes to the main tree. -@end itemize - -Whichever way, changes should be reviewed by the maintainer of the code -before they are committed. And they should follow the @ref{Coding Rules}. +All proposed code changes should be submitted for review to +@url{mailto:ffmpeg-devel@@ffmpeg.org, the development mailing list}, as +described in more detail in the @ref{Submitting patches} chapter. The code +should comply with the @ref{Development Policy} and follow the @ref{Coding Rules}. The developer making the commit and the author are responsible for their changes and should try to fix issues their commit causes. @@ -267,6 +262,7 @@ For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}: (setq c-default-style "ffmpeg") @end lisp +@anchor{Development Policy} @chapter Development Policy @section Patches/Committing