From patchwork Mon Nov 14 14:35:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Bin" X-Patchwork-Id: 39271 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp2481970pzb; Mon, 14 Nov 2022 07:05:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5b9HkX6ttlauiBACPtVTNA81+mJZ6WGOfmGEZTka01QyMqWBQ9zGW4bRAjR6tC8dvy90q+ X-Received: by 2002:a17:906:8385:b0:7ad:8035:ae3d with SMTP id p5-20020a170906838500b007ad8035ae3dmr10512770ejx.46.1668438359738; Mon, 14 Nov 2022 07:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668438359; cv=none; d=google.com; s=arc-20160816; b=dUfW1oLmx9EjE01aNlMneyAY8m6iNNi+HUuUL/0ocvCs1o+F5CF9mcgn6YyByGrqQa eENdAg1ki+FW5lkG0pPOj6akP5lmZE/CjwGifHZfq+gPQ6WXFel+jKXlD7kE53YcffOk yAWsRJCth0s1laEzOJhZuhrn3RUe599bemyKuLghISHqO+/mjEIQA8EHJ1FOOcFt/lFm wm0LKiFcVJYgFW+kiteU74wsB8rW6CjNWiQ+wjWhKBXxMGWNf6sl06d7t67G+PvG1j5K xaZZmKvziSnXct1TMt7maIjaELohGS6CRpuHKJHAqi2ZwVW5UxOLDiwTXqBuOF3YSvZ0 lp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=LCzhg8nbed+5Y18nU4e1i6w4GAcbHXLUY42IHg28kK4=; b=bgoeEsF/yyyYW5+DSYQkwj2URA/FYd9gQxD9bYTU7qmjwYskCoCXHi2EsJ0RpJvPxR xMAblW7LuOt32QU2BpK1/mxNBLAuI27oYclySWQVQtU+JrPN56fd5RhputcsZe23Doyo NGYUzbtSuH5UIDgUbUSUrBNdRxIV11vQsA4DtwrREDqCWDyveO/oNFlU1+061j3bUY4O nk4Cbv1i+FRUZD/PAU2L+wrSiMGAYHtIsxIE/GfiuymhloTDeH9IueJvJHNw/xj5YQmo kAijtlCe6/wpITqza6VUAnAwxqCiK6J4nm2NasP9puFNJCkBBVAxOFl1Z/45vsz3r53f FPbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=J11wIsW6; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h8-20020a056402280800b00457263f9ee0si8740089ede.93.2022.11.14.07.05.51; Mon, 14 Nov 2022 07:05:59 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=J11wIsW6; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C58B68B375; Mon, 14 Nov 2022 17:05:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF94168AF9F for ; Mon, 14 Nov 2022 17:05:40 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668438346; x=1699974346; h=from:to:cc:subject:date:message-id; bh=+3iH3itwaLGSXmO18rxuPCcYd122wqGCgTnrSieyeuA=; b=J11wIsW6pT1xTSwQcaBKSMzzolu9WqSNgz2slEXuWCvlfqUfhNpryYmk UaLmTqsA8y/AnC6k8+IUf761m6+L5t6M2ex9KChNpv44azdcVFlR1exsD zvUV3JpGEuLdv0vGdjUiVoPz3aDTF+e47cDH7AdjK8rLSTE6kcUjhyF0f yaa/EFK7b4Wj1iuhUfWz2iP36ZLj5kbB1x+tqhf51ngQVv8orjEi85wJ4 jSHFtpaLrm6b4Y8yvQXfpWRe5Fltu3232njwjzjtPKM2Nw9SHPBAni6lN oKRp75gxocvBQL4bOp2i11Y1TEoPOa06z2luBorJ71+W3pNfnIEqEekF+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="311993772" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="311993772" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 06:58:24 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="669680419" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="669680419" Received: from bionic.bj.intel.com ([172.16.183.158]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 06:58:22 -0800 From: bin.wang-at-intel.com@ffmpeg.org To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Nov 2022 22:35:51 +0800 Message-Id: <20221114143551.9740-1-bin.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH v1] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wang, Bin" , Wang@ffbox0-bg.ffmpeg.org MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: KVbnZk6aEqJW From: "Wang, Bin" Signed-off-by: Wang, Bin --- libavfilter/x86/vf_convolution.asm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm index c912d56752..a6be95690b 100644 --- a/libavfilter/x86/vf_convolution.asm +++ b/libavfilter/x86/vf_convolution.asm @@ -189,8 +189,8 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x %endif %if WIN64 - SWAP xmm0, xmm2 - SWAP xmm1, xmm3 + VBROADCASTSS m0, xmm2 + VBROADCASTSS m1, xmm3 mov r2q, matrixmp mov r3q, ptrmp DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x @@ -281,7 +281,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, fmaddss xmm4, xmm5, xmm5, xmm4 sqrtps xmm4, xmm4 - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias cvttps2dq xmm4, xmm4 ; trunc to integer packssdw xmm4, xmm4 packuswb xmm4, xmm4