From patchwork Sat Nov 26 08:18:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 39450 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp6013030pzb; Sat, 26 Nov 2022 00:19:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6J7QTYPc2qBRgl8EuCQBRgw3jsR6THRetEuEtrivPobPyUbLA4CSIqQ/gopZGzlriGw5Ie X-Received: by 2002:aa7:c84d:0:b0:468:354b:280d with SMTP id g13-20020aa7c84d000000b00468354b280dmr39837248edt.178.1669450776212; Sat, 26 Nov 2022 00:19:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669450776; cv=none; d=google.com; s=arc-20160816; b=nCBbMvOG4DkJdrWOFf/YSw7dT2ByaVE50nsifTZ2184FAOdruL/c4wOL2j6Z8Fy6hs DMlJFg87BRTRpQVk8zQiTNvXlDdH+X6zzcEAfFBIFsU9CS5VGGgVx0YpKmX0SGbCUnVc Nc/0BgQ4wy190MrBc8TM4fMMhQ2sb43DukUccLJQ4c9AdNQEd/4Ny8/QMVnrsOVQ29Ae CSpcRFQzrBkHOnxz2FV7NusF3DXXujePN4fruy+h+MyNsignowydxbV5momX2tSer/O8 05SdrIIK+K0o4V9t56078MKPqoVW0Fus7DuSK0y+Su9VW2KVGXRXNd/6CeqAZAfaOPlT lwbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=CAD9B9UXiT60f9z3CCpmAe6PkN3OVIZgnpnahSmPS/E=; b=PUQiXyBZmiuckX3qxQFPcEFLdkrXxC8JIpUhxNiHrc3WNSKCafb6hXuv9Ktr7fi0mb M3ozBk4nIQE6BQwTYDZYnd6EjU2TToASDJoodPyXtdsktPdz7Monmht9AXQbwZpJ0KCO oVb0DiEcraqZi0CNWsdzxwSf++uW2TnzDNO7gouMR0Xdw3Eog1+acC1B0u5WWEv68Kmg 2hZfA2QJe/Zv/8dG9nQnxTbxCEMMziqniyHgxHG1zBZebAp+LWgsD9xCY2dBOjycSPRp 1lWkr1IRDXQemSRlLWGz4QSW9lC28gWZ88HZCx+xNGZd37q62AAKcDyLd42kQrOiHVr4 itGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 25-20020a508e59000000b00468cd2ab847si3956769edx.172.2022.11.26.00.19.35; Sat, 26 Nov 2022 00:19:36 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D09C68B6F0; Sat, 26 Nov 2022 10:19:31 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A4E8368A929 for ; Sat, 26 Nov 2022 10:19:24 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3E9F52406CF for ; Sat, 26 Nov 2022 09:19:24 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id isnshZu0jX8V for ; Sat, 26 Nov 2022 09:19:23 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 898EA2400F5 for ; Sat, 26 Nov 2022 09:19:23 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 4AE643A0102 for ; Sat, 26 Nov 2022 09:19:23 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Sat, 26 Nov 2022 09:18:59 +0100 Message-Id: <20221126081911.31275-1-anton@khirnov.net> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 01/13] fftools/ffmpeg: stop explicitly closing decoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qJXqtN6L3hOL It serves no purpose, they will be closed and freed in avcodec_free_context() called from ist_free(). --- fftools/ffmpeg.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 3767ab444b..ba91af2c95 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -3908,13 +3908,6 @@ static int transcode(void) exit_program(1); } - /* close each decoder */ - for (ist = ist_iter(NULL); ist; ist = ist_iter(ist)) { - if (ist->decoding_needed) { - avcodec_close(ist->dec_ctx); - } - } - hw_device_free_all(); /* finished ! */