From patchwork Mon Dec 12 04:33:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan Doshi X-Patchwork-Id: 39679 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp18635pzb; Sun, 11 Dec 2022 20:33:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf4y7BkB7n7cRispr84kG1MqS6xNN2Rk6X/nCx6pojzHSmpfF9VgOVgdHevqVxYeDeuus0JR X-Received: by 2002:a17:906:8456:b0:7c1:e78:1e2 with SMTP id e22-20020a170906845600b007c10e7801e2mr16264136ejy.11.1670819637425; Sun, 11 Dec 2022 20:33:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670819637; cv=none; d=google.com; s=arc-20160816; b=uy2NuEA8uONkfeNLmYqu9LakbJPbaG+/SQnhxt38v9fbr9E518BX0DtzLJxa40QhHh zcpssFdZjQc22sJAQi5hw0qgl9df0cvnwh/y4G4SoZXLvR9nidjPhqcBGwmiMpAblFVd bp3TGtuY7xY+e9+V0LcpS3/kNxlmLCT8FE8Lmtg27bQMwGwWwsv+ywGun/3GkqmLGds4 Ad9uA1cKNHpjywoERxs2PqRjtYNkPNC8khCX92+GYhuP551Z4ZOz73zMZtywztvEyDHp 8Xpbz2kwZiUPCtg3CWuYIP2y6+EdX6A3FCm63syW2kNZXixiEVpHFMsJKaeyAR1aF2RR IAEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=HIPSLRyU6yX6Fqh9Q1fH24OrYwrtrMn8wV2AAuukzdM=; b=ivq3UI43mlypkvecaHvzSq+5WfGcfUQ5k+UUR8t1Ffx3j9WUs4nguGjwxezhuOiqgv 59inuPbfJdaF57s4iVJ7W67lrlbaF22VMog9CVj7xHdPRYI4+7TEjN+Ddx+U7NGoQYw1 9jm3GYWCg37Oi1l+0Vz2Wr7p8wi1F0kdmOfEKnszhGLiEAEwGs69bXg96fju6O6DnCV5 hWqxHgHE4jFN3+xpDSYbaF5j6jKh2tZwT8Qu8vyEtJkEPfoyT/7QEZWWkTO6Nh3Ox9Zg kxfWBuuD3jshVa7o8X6r/GrzHS3V/8bWCu3EfcjrgGjzMrJnxZiwgrkiARTmkAhEwX6V xD6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id nd7-20020a170907628700b0073d6c0facdcsi5988374ejc.259.2022.12.11.20.33.56; Sun, 11 Dec 2022 20:33:57 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD91E68BDD2; Mon, 12 Dec 2022 06:33:52 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C37E68B476 for ; Mon, 12 Dec 2022 06:33:45 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4NVpfX3n6Jz9sSD for ; Mon, 12 Dec 2022 05:33:40 +0100 (CET) From: Gyan Doshi To: ffmpeg-devel@ffmpeg.org Date: Mon, 12 Dec 2022 10:03:10 +0530 Message-Id: <20221212043310.927-1-ffmpeg@gyani.pro> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/movenc: correct write_colr warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QsMSuGBDXZrw The old warning is no longer correct after this block was recomposed in c5b20cfe19. The block is only active for supported formats. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7b00e65cdd..d3c823e4e6 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2331,7 +2331,7 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex int prefer_icc = mov->flags & FF_MOV_FLAG_PREFER_ICC || !has_color_info; mov_write_colr_tag(pb, track, prefer_icc); } else if (mov->flags & FF_MOV_FLAG_WRITE_COLR) { - av_log(mov->fc, AV_LOG_WARNING, "Not writing 'colr' atom. Format is not MOV or MP4.\n"); + av_log(mov->fc, AV_LOG_WARNING, "Not writing 'colr' atom. Not all color properties specified.\n"); } } if (track->mode == MODE_MOV || track->mode == MODE_MP4) {