| Message ID | 20221213024216.259-1-mindmark@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v3,1/4] avcodec/bswapdsp: remove unused cextern | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Mon, Dec 12, 2022 at 6:42 PM <mindmark@gmail.com> wrote: > From: Mark Reid <mindmark@gmail.com> > > --- > libavcodec/x86/bswapdsp.asm | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm > index 31c6c48a21..2aa235e13c 100644 > --- a/libavcodec/x86/bswapdsp.asm > +++ b/libavcodec/x86/bswapdsp.asm > @@ -26,8 +26,6 @@ > SECTION_RODATA > pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 > > -cextern pb_80 > - > SECTION .text > > ; %1 = aligned/unaligned > -- > 2.31.1.windows.1 > > ping
On Mon, Dec 26, 2022 at 1:31 PM Mark Reid <mindmark@gmail.com> wrote: > > > On Mon, Dec 12, 2022 at 6:42 PM <mindmark@gmail.com> wrote: > >> From: Mark Reid <mindmark@gmail.com> >> >> --- >> libavcodec/x86/bswapdsp.asm | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm >> index 31c6c48a21..2aa235e13c 100644 >> --- a/libavcodec/x86/bswapdsp.asm >> +++ b/libavcodec/x86/bswapdsp.asm >> @@ -26,8 +26,6 @@ >> SECTION_RODATA >> pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 >> >> -cextern pb_80 >> - >> SECTION .text >> >> ; %1 = aligned/unaligned >> -- >> 2.31.1.windows.1 >> >> > ping > ping
Quoting Mark Reid (2023-01-06 19:09:10) > On Mon, Dec 26, 2022 at 1:31 PM Mark Reid <mindmark@gmail.com> wrote: > > > > > > > On Mon, Dec 12, 2022 at 6:42 PM <mindmark@gmail.com> wrote: > > > >> From: Mark Reid <mindmark@gmail.com> > >> > >> --- > >> libavcodec/x86/bswapdsp.asm | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm > >> index 31c6c48a21..2aa235e13c 100644 > >> --- a/libavcodec/x86/bswapdsp.asm > >> +++ b/libavcodec/x86/bswapdsp.asm > >> @@ -26,8 +26,6 @@ > >> SECTION_RODATA > >> pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 > >> > >> -cextern pb_80 > >> - > >> SECTION .text > >> > >> ; %1 = aligned/unaligned > >> -- > >> 2.31.1.windows.1 > >> > >> > > ping > > > > ping Are you really duplicating a whole bunch of files from lavc in sws? I don't think that's anywhere remotely close to acceptable.
On Tue, Jan 10, 2023 at 3:07 AM Anton Khirnov <anton@khirnov.net> wrote: > Quoting Mark Reid (2023-01-06 19:09:10) > > On Mon, Dec 26, 2022 at 1:31 PM Mark Reid <mindmark@gmail.com> wrote: > > > > > > > > > > > On Mon, Dec 12, 2022 at 6:42 PM <mindmark@gmail.com> wrote: > > > > > >> From: Mark Reid <mindmark@gmail.com> > > >> > > >> --- > > >> libavcodec/x86/bswapdsp.asm | 2 -- > > >> 1 file changed, 2 deletions(-) > > >> > > >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm > > >> index 31c6c48a21..2aa235e13c 100644 > > >> --- a/libavcodec/x86/bswapdsp.asm > > >> +++ b/libavcodec/x86/bswapdsp.asm > > >> @@ -26,8 +26,6 @@ > > >> SECTION_RODATA > > >> pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 > > >> > > >> -cextern pb_80 > > >> - > > >> SECTION .text > > >> > > >> ; %1 = aligned/unaligned > > >> -- > > >> 2.31.1.windows.1 > > >> > > >> > > > ping > > > > > > > ping > > Are you really duplicating a whole bunch of files from lavc in sws? I > don't think that's anywhere remotely close to acceptable. > > This was what I was suggested to do http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304667.html > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
Le keskiviikkona 11. tammikuuta 2023, 0.57.13 EET Mark Reid a écrit : > > Are you really duplicating a whole bunch of files from lavc in sws? I > > don't think that's anywhere remotely close to acceptable. > > This was what I was suggested to do > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304667.html TBH, you do not need to duplicate the source to have the same code statically linked in two different libraries. At most, you need some macro to rename the functions to avoid duplicate symbols in the odd case that swscale and lavc are statically linked into the same shared object. (I do not personally like that coding style, but it seems quite popular in FFmpeg already.) I agree with Anton that duplicating the complete source does not seem acceptable (especially if *I* am expected to fix the RISC-V afterwards, but I digress).
diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm index 31c6c48a21..2aa235e13c 100644 --- a/libavcodec/x86/bswapdsp.asm +++ b/libavcodec/x86/bswapdsp.asm @@ -26,8 +26,6 @@ SECTION_RODATA pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12 -cextern pb_80 - SECTION .text ; %1 = aligned/unaligned
From: Mark Reid <mindmark@gmail.com> --- libavcodec/x86/bswapdsp.asm | 2 -- 1 file changed, 2 deletions(-)