From patchwork Thu Dec 15 10:49:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Darnley X-Patchwork-Id: 39712 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp470604pzb; Thu, 15 Dec 2022 02:51:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf7UvvC/83rwRmbxyqklx6NWkyULe/7BIuKVDmaGggJwviJPqQAtuEN0E+M2Iais5Rbw0IXX X-Received: by 2002:a17:906:4e9a:b0:7c0:b292:e56b with SMTP id v26-20020a1709064e9a00b007c0b292e56bmr21199301eju.68.1671101485879; Thu, 15 Dec 2022 02:51:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671101485; cv=none; d=google.com; s=arc-20160816; b=pqJw8ZQ0fjWnQDpR2s8jk5VscMjCBRAuYErlsbl7BEM6rJ/ryxPR14LLnrZQGL35VJ AiiPPZ0/7Yc7sOJireQG5h60ig89pzPHtpk/ieVLtvVy4ufPK6jZRON919tTs0JHB91T pumhHkkHPCugjObDsEH/vRkHzhhMMSUuXyK7gZBxn+ptLDcYwCYfMZ5ERpL7AuXkO+5c apCZ7+eJ3XWO2DV/CQ12bkf5HAFgSU03581+3F5q9sGHY8Ql+QHnRQPBlW9CYnXnWcE1 gEaImMvdCZOCHgRJei5rS4d+hjaH4efC+yfIO7iE0zPmPrj8/mXzo0St65YqVoUY59Qf QOOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=wJDuKEzq6UvPO+KaNoGrZF/24tz0mXuQvtC9b3u1qXo=; b=rsmJR7yoOWeMoiNdsEfu8t4jNl8y1IfMDsg4zuli+X79MklBzcva6icFpU/zZzItpi gRoAUmFo0m/XsYGJk6BqXmEgnxG1mZzz17qZtaaAj0/NmZZra4jPvPpZcOocmzuAOnKv zzD70odCTF84YoERClt8RZ6GcWDtOUAnlI76TV8qooaTwSnlrjTfgdccTmMGu8ym7X9E sefypUENaDQ1OVKESU7ouZbaM0XXPg/TpaPbcSz9NKniHmTcISSb+Y4j2xRh5FWDUMhV BJLNquEF762rW7xRJSgfMGHcpGGWQD1K1XoQnB4psPTtImT2ohJxRGz99K0zkM8Pg3Xz BGwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@obe-tv.20210112.gappssmtp.com header.s=20210112 header.b=QFQwAxLC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id kf22-20020a17090776d600b007c111fc30absi10043819ejc.865.2022.12.15.02.51.25; Thu, 15 Dec 2022 02:51:25 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@obe-tv.20210112.gappssmtp.com header.s=20210112 header.b=QFQwAxLC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4972268BA61; Thu, 15 Dec 2022 12:51:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C889068BA61 for ; Thu, 15 Dec 2022 12:51:14 +0200 (EET) Received: by mail-wr1-f43.google.com with SMTP id h12so2584524wrv.10 for ; Thu, 15 Dec 2022 02:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/PEwgkX/578fNVw2vaAn4BOMru9w83vX1hqP9jomb4o=; b=QFQwAxLCTk5qaUoAeE+cGJysLjmJ8UGKdjXzsqEmXkBPnr/c3u1YscjZhRCvzYZ9v/ MhJgwq7fH7nxMoBzET0ONiz46Izo+8Wja//kZYJe9YRFNZAkYlD2lF3TtqQwX/Zdhf/7 waM5bMTxc2nzlUQXKpSXwd5PKbiyEge30tZFxxM5tl3LwlB/Y7aE6s2DHdhJq69+IrWD 9WpMzZC0exrtDt5SbTmPjaI8NK+4nwOGTIH5IDrW3yblG76728zulp6dx3M2jkR1vDUV ghxmsNReLYk/GPu82M8oUpjjz6kuamZi5WERCX2HK94HXOnZAPiYqhBoI/UCBGFSbrC+ KIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/PEwgkX/578fNVw2vaAn4BOMru9w83vX1hqP9jomb4o=; b=BUl15LaMXC1MUL0MJX/8dG8q/f5FlPAnwOxYMShdR1Mx0hpj0QhW0+7ynMKG9fUqHe LXrXfPPu37ePj3zvbMzLItu9llrq3KkbbjOuiTxsM4HkmIaIZgYXDdMSpgdawnRIw/c3 BN4rMDwq7WwXXWtqfAZkla7rT9h5bluhxw8AhyQMIAcn+WR7V7ojvznnrvyiQWbbQu9Z Y2UOSp5Hp3H0g3/ifvEqkwo1BTTx6+7RRGmc34/kFkHT/jGuhcN/2cxrPCLbFoTBRGv+ 2EbNZ93SMcCsoYuyD6S1N2mrQ5RK7fPYFRRqxoAmOF8+llGYPTmAyXnLKYIdKA4WD/jA y6fA== X-Gm-Message-State: ANoB5pkci+VRulG9UDJrjE3KplyaMKlUUe/se8PuT86NdEpzZAwRGNse dR+QQJ+YZN6M7M/Fm9dns+TOWS6bDOIRfyD1 X-Received: by 2002:a5d:4012:0:b0:242:5878:2923 with SMTP id n18-20020a5d4012000000b0024258782923mr16868391wrp.10.1671101474118; Thu, 15 Dec 2022 02:51:14 -0800 (PST) Received: from Dana.systemlords.lan (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b002415dd45320sm5421977wru.112.2022.12.15.02.51.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 02:51:13 -0800 (PST) From: James Darnley To: ffmpeg-devel@ffmpeg.org Date: Thu, 15 Dec 2022 11:49:03 +0100 Message-Id: <20221215104904.3264109-1-jdarnley@obe.tv> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/x86/v210: add some comments to the improved avx2 function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vA5mUtYLqWbv --- libavcodec/x86/v210.asm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/v210.asm b/libavcodec/x86/v210.asm index 3b9e0761df..600a4ddc5f 100644 --- a/libavcodec/x86/v210.asm +++ b/libavcodec/x86/v210.asm @@ -65,18 +65,18 @@ cglobal v210_planar_unpack_%1, 5, 5, 6 + 2 * cpuflag(avx2), src, y, u, v, w mova m0, [srcq] %endif - pmullw m1, m0, m3 - pslld m0, 12 - psrlw m1, 6 ; yB yA u5 v4 y8 y7 v3 u3 y5 y4 u2 v1 y2 y1 v0 u0 - psrld m0, 22 ; 00 v5 00 y9 00 u4 00 y6 00 v2 00 y3 00 u1 00 y0 + pmullw m1, m0, m3 ; shifts the 1st and 3rd sample of each dword into the high 10 bits of each word + pslld m0, 12 ; shifts the 2nd sample of each dword into the high 10 bits of each dword + psrlw m1, 6 ; shifts the 1st and 3rd samples back into the low 10 bits + psrld m0, 22 ; shifts the 2nd sample back into the low 10 bits of each dword %if cpuflag(avx2) - vpblendd m2, m1, m0, 0x55 ; yB yA 00 y9 y8 y7 00 y6 y5 y4 00 y3 y2 y1 00 y0 + vpblendd m2, m1, m0, 0x55 ; merge the odd dwords from m0 and even from m1 ; yB yA 00 y9 y8 y7 00 y6 y5 y4 00 y3 y2 y1 00 y0 pshufb m2, m4 ; 00 00 yB yA y9 y8 y7 y6 00 00 y5 y4 y3 y2 y1 y0 vpermd m2, m6, m2 ; 00 00 00 00 yB yA y9 y8 y7 y6 y5 y4 y3 y2 y1 y0 movu [yq+2*wq], m2 - vpblendd m1, m1, m0, 0xaa ; 00 v5 u5 v4 00 u4 v3 u3 00 v2 u2 v1 00 u1 v0 u0 + vpblendd m1, m1, m0, 0xaa ; merge the even dwords from m0 and odd from m1 ; 00 v5 u5 v4 00 u4 v3 u3 00 v2 u2 v1 00 u1 v0 u0 pshufb m1, m5 ; 00 v5 v4 v3 00 u5 u4 u3 00 v2 v1 v0 00 u2 u1 u0 vpermq m1, m1, 0xd8 ; 00 v5 v4 v3 00 v2 v1 v0 00 u5 u4 u3 00 u2 u1 u0 pshufb m1, m7 ; 00 00 v5 v4 v3 v2 v1 v0 00 00 u5 u4 u3 u2 u1 u0