From patchwork Wed Dec 28 03:19:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marton Balint X-Patchwork-Id: 39798 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp3859422pzb; Tue, 27 Dec 2022 19:20:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXsEK1O1mq644eFo+CE3k3aX50LYidK6SpEAKL6mWmwcWyA1EXK1wZkInvUqgFhECJ1qAwcJ X-Received: by 2002:a05:6402:1caa:b0:46c:72fb:3810 with SMTP id cz10-20020a0564021caa00b0046c72fb3810mr25801801edb.41.1672197615185; Tue, 27 Dec 2022 19:20:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672197615; cv=none; d=google.com; s=arc-20160816; b=eEdzDfV7hMA7OhQJt/QK/Me/PGmy42gCHO9mpAzzNA2R6K5uWkqOtCJ+Ktv4alCm+v pQWeWIGriUewu5JTBY4HVb7XwsbYHOgsDJ+DlwnbJv/5z15mN10jHkeZumjXUQfW9Fhm JVT0e+byxAM7WQsuI9GeMkYR0uIJxbLui3APWn4SuNyjo2Eg812EVISyAwLDzo9uF4A+ w7dHGcnNRiM7ImiLa+0obqW99j2RgdSA69ya3urhp+/TS9w7MQQMvZOvoHO662ng+3zb /gTIua75bkwBCQxkNuRZnlILOVk3iNjSH2dTE71H+uwXgDvFRxnlxCt2IolRrDvqSRMf zCCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:delivered-to; bh=qyyrTg3eH8QbDRb6LGZdMr/1+yHOfln3GoOkIxBFtBo=; b=Jth5ksirDCX5zoN2/SKRu1mFVS6003a8brbmM39s6Wxkfe63JPUB01YW/Y8gTlAwHt Mdp5qJ8xFIRNcmskuPSIb2wdL+TBUswM4QIyV9fl6aXSMgtwkDfpKtFGK4c8fTtS/aEP Y3VkSPGlN+ELlYJGl2mHeh/OZR91oVIFizTXrbfQBAKL23P5ns6VUS9Mvm+bho3d9HBc xQPJiSOa5cGIgLm+l7kT/4xjejxksiCXLJ8qiPbPH1nPom11w/0EpjZ2hUUk8VDIvz4U sEvSb982bZM3Vo2wP4fKc6TX5ApwuS/1EYIM97b3tUvJrS0l+QAPNW1CYnmTSgCkoNd6 Pkrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q3-20020a056402248300b00482f01ff579si9440123eda.131.2022.12.27.19.20.14; Tue, 27 Dec 2022 19:20:15 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2CB8068BC18; Wed, 28 Dec 2022 05:20:11 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63F2268BC0D for ; Wed, 28 Dec 2022 05:20:04 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id C5BDCE840F; Wed, 28 Dec 2022 04:20:02 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MWSg2eRtYUXs; Wed, 28 Dec 2022 04:20:00 +0100 (CET) Received: from bluegene.passwd.hu (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 3D202E82F8; Wed, 28 Dec 2022 04:20:00 +0100 (CET) From: Marton Balint To: ffmpeg-devel@ffmpeg.org Date: Wed, 28 Dec 2022 04:19:56 +0100 Message-Id: <20221228031958.26570-1-cus@passwd.hu> X-Mailer: git-send-email 2.35.3 In-Reply-To: <76674b9a-30ff-a43-6d51-8c74dca8fa@passwd.hu> References: <76674b9a-30ff-a43-6d51-8c74dca8fa@passwd.hu> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: check index entry array size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Tv0XtqlDtotu Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e6118e141d..ad4ee15570 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1198,11 +1198,15 @@ static int mxf_read_essence_container_data(void *arg, AVIOContext *pb, int tag, static int mxf_read_index_entry_array(AVIOContext *pb, MXFIndexTableSegment *segment) { int i, length; + uint32_t nb_index_entries; if (segment->temporal_offset_entries) return AVERROR_INVALIDDATA; - segment->nb_index_entries = avio_rb32(pb); + nb_index_entries = avio_rb32(pb); + if (nb_index_entries > INT_MAX) + return AVERROR_INVALIDDATA; + segment->nb_index_entries = nb_index_entries; length = avio_rb32(pb); if(segment->nb_index_entries && length < 11)