diff mbox series

[FFmpeg-devel,v2,1/3] avformat/imfdec: remove the experimental flag

Message ID 20230105232946.21950-1-pal@sandflow.com
State New
Headers show
Series [FFmpeg-devel,v2,1/3] avformat/imfdec: remove the experimental flag | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Pierre-Anthony Lemieux Jan. 5, 2023, 11:29 p.m. UTC 
From: Pierre-Anthony Lemieux <pal@palemieux.com>

---
 libavformat/imfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomas Härdin Jan. 6, 2023, 3:45 p.m. UTC | #1 
tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> ---
>  libavformat/imfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 03de9ce151..a92686e93b 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
>  const AVInputFormat ff_imf_demuxer = {
>      .name           = "imf",
>      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> Master Format)"),
> -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> +    .flags          = AVFMT_NO_BYTE_SEEK,
>      .flags_internal = FF_FMT_INIT_CLEANUP,
>      .priv_class     = &imf_class,
>      .priv_data_size = sizeof(IMFContext),

This demuxer is really limited though, right?

/Tomas
Pierre-Anthony Lemieux Jan. 6, 2023, 3:50 p.m. UTC | #2 
On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
>
> tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > ---
> >  libavformat/imfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > index 03de9ce151..a92686e93b 100644
> > --- a/libavformat/imfdec.c
> > +++ b/libavformat/imfdec.c
> > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> >  const AVInputFormat ff_imf_demuxer = {
> >      .name           = "imf",
> >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > Master Format)"),
> > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > +    .flags          = AVFMT_NO_BYTE_SEEK,
> >      .flags_internal = FF_FMT_INIT_CLEANUP,
> >      .priv_class     = &imf_class,
> >      .priv_data_size = sizeof(IMFContext),
>
> This demuxer is really limited though, right?

Can you clarify what you mean by "limited"?

The demuxer is intended to only process IMF packages (playlist + track files).

>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Tomas Härdin Jan. 6, 2023, 4:09 p.m. UTC | #3 
fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux:
> On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
> > 
> > tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> > > 
> > > ---
> > >  libavformat/imfdec.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > > index 03de9ce151..a92686e93b 100644
> > > --- a/libavformat/imfdec.c
> > > +++ b/libavformat/imfdec.c
> > > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> > >  const AVInputFormat ff_imf_demuxer = {
> > >      .name           = "imf",
> > >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > > Master Format)"),
> > > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > > +    .flags          = AVFMT_NO_BYTE_SEEK,
> > >      .flags_internal = FF_FMT_INIT_CLEANUP,
> > >      .priv_class     = &imf_class,
> > >      .priv_data_size = sizeof(IMFContext),
> > 
> > This demuxer is really limited though, right?
> 
> Can you clarify what you mean by "limited"?
> 
> The demuxer is intended to only process IMF packages (playlist +
> track files).

Perhaps I was speaking ahead. Last time I looked lavf was not capable
of performing the kind of NLE functionality required for full IMF
support. Perhaps imfdec does that internally? It doesn't seem so..

/Tomas
Pierre-Anthony Lemieux Jan. 6, 2023, 4:18 p.m. UTC | #4 
On Fri, Jan 6, 2023 at 8:09 AM Tomas Härdin <git@haerdin.se> wrote:
>
> fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux:
> > On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
> > >
> > > tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > > > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> > > >
> > > > ---
> > > >  libavformat/imfdec.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > > > index 03de9ce151..a92686e93b 100644
> > > > --- a/libavformat/imfdec.c
> > > > +++ b/libavformat/imfdec.c
> > > > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> > > >  const AVInputFormat ff_imf_demuxer = {
> > > >      .name           = "imf",
> > > >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > > > Master Format)"),
> > > > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > > > +    .flags          = AVFMT_NO_BYTE_SEEK,
> > > >      .flags_internal = FF_FMT_INIT_CLEANUP,
> > > >      .priv_class     = &imf_class,
> > > >      .priv_data_size = sizeof(IMFContext),
> > >
> > > This demuxer is really limited though, right?
> >
> > Can you clarify what you mean by "limited"?
> >
> > The demuxer is intended to only process IMF packages (playlist +
> > track files).
>
> Perhaps I was speaking ahead. Last time I looked lavf was not capable
> of performing the kind of NLE functionality required for full IMF
> support. Perhaps imfdec does that internally? It doesn't seem so..

The demuxer supports the full range of playlist (CPL) functionality,
including multiple non-coincident resources and resource repeats.

Only audio and image are supported for now.

See the current FATE test and the additional proposal sample at:

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20221230071243.24762-1-pal@sandflow.com/


>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Anton Khirnov Feb. 20, 2023, 5:55 p.m. UTC | #5 
Quoting pal@sandflow.com (2023-01-06 00:29:44)
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> ---
>  libavformat/imfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 03de9ce151..a92686e93b 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
>  const AVInputFormat ff_imf_demuxer = {
>      .name           = "imf",
>      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
> -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> +    .flags          = AVFMT_NO_BYTE_SEEK,

The demuxer has been upstream for quite a while without too many issues,
so I'd say this is reasonable.
Pierre-Anthony Lemieux Feb. 20, 2023, 7:34 p.m. UTC | #6 
On Mon, Feb 20, 2023 at 9:55 AM Anton Khirnov <anton@khirnov.net> wrote:
>
> Quoting pal@sandflow.com (2023-01-06 00:29:44)
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > ---
> >  libavformat/imfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > index 03de9ce151..a92686e93b 100644
> > --- a/libavformat/imfdec.c
> > +++ b/libavformat/imfdec.c
> > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> >  const AVInputFormat ff_imf_demuxer = {
> >      .name           = "imf",
> >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
> > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > +    .flags          = AVFMT_NO_BYTE_SEEK,
>
> The demuxer has been upstream for quite a while without too many issues,
> so I'd say this is reasonable.

Ok. Will apply tomorrow unless objections are raised.

>
> --
> Anton Khirnov
diff mbox series

Patch

diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 03de9ce151..a92686e93b 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@ -1018,7 +1018,7 @@  static const AVClass imf_class = {
 const AVInputFormat ff_imf_demuxer = {
     .name           = "imf",
     .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
-    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
+    .flags          = AVFMT_NO_BYTE_SEEK,
     .flags_internal = FF_FMT_INIT_CLEANUP,
     .priv_class     = &imf_class,
     .priv_data_size = sizeof(IMFContext),