From patchwork Tue Jan 17 17:04:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 40065 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1d43:b0:b8:6755:f97e with SMTP id cs3csp1991872pzb; Tue, 17 Jan 2023 09:05:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXviK8KJsTfboa204mE10pIf8MG3TH+mUxWpbqEmlo+c8pF3kGTIhOuCZixMX7V0Z72pHxEf X-Received: by 2002:a05:6402:3715:b0:499:cc2c:bf6f with SMTP id ek21-20020a056402371500b00499cc2cbf6fmr4194598edb.35.1673975134854; Tue, 17 Jan 2023 09:05:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673975134; cv=none; d=google.com; s=arc-20160816; b=yik0fMH2u+K0IRLVH5k2NFOrM0FNDU9Fd082bh1YC5BOn5zlgIOngOBSwV9+uXLdeA X/ZtDgf6pLQ3jbv2XuQBL/+oN0U1fSwNYvG98CqouqQmhYYlzt5repGCoEt+hG84U3BV Ac97x5nJncRMN34Hvj8GBHFz0dFFP1l96yOzL8JIX/esLWANOhWTWOl4Ey9VGs64FYz/ SFHAIl9k0biDQmdsRP0dDvd8+sbp7Z4BB6CKL3aY1/H7LRnG2M64fRMRC2pQ7v/mo57V dVqc6MK/kTwa6nYwUeiH8vP2yr5mTxI678T6zzajh/sixOhEcuLnzcctRWAETjnTHH5r v+7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=hXx17WtzWTwc7jyO3KNR7Wkx6//uBcrsc4dbY1YpYWQ=; b=bPBzjQdeKn+K3h1BPdq7VmgUmLMuj40D2ssmDezxyDO/l/xSsE0Hty9keUxZEQlrE5 wws7qJt+lW7q51xFH9iWu05QdK0XM/VJmlJ9ysjUxsoUCtTDqFAvRrnYplJu7UDSzg5e JnSTELbRIqVUjDeseqbo4Y+3dMjkbqEImP5wxS+YImPop6UYp1uG34jcnW/Z8uCiqEd7 WrFLiFB8PJFa0aL64IALH/jlPSg++rrPQS+69LOHgeRSWUAk8DNVZKEYDa4GHkeoD+5B TmOl/tc9pN7CSvpz8dgLnFiCB4q5+L0/Oh4NOf1901S46QPuYKM+fbIqvdJwNcJmjdAw eePQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id wz1-20020a170906fe4100b0084d4733f909si26472533ejb.964.2023.01.17.09.05.34; Tue, 17 Jan 2023 09:05:34 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3618C68BE89; Tue, 17 Jan 2023 19:05:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E2FC68BE1B for ; Tue, 17 Jan 2023 19:05:14 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 15742240183 for ; Tue, 17 Jan 2023 18:05:14 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id SKwpIBhtjHXA for ; Tue, 17 Jan 2023 18:05:12 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D290D2400F5 for ; Tue, 17 Jan 2023 18:05:12 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 7A3433A02AF for ; Tue, 17 Jan 2023 18:05:06 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Jan 2023 18:04:58 +0100 Message-Id: <20230117170500.4053-1-anton@khirnov.net> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [RFC PATCH 1/3] lavfi/avfilter: export process_options() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: fBlYFNCVYamf Also, replace an AVFilterContext argument with a logging context+private class, as those are the only things needed in this function. Will be useful in future commits. --- libavfilter/avfilter.c | 20 ++++++++++---------- libavfilter/internal.h | 13 +++++++++++++ 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index c2ecdffa6f..86b275dc4f 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -797,8 +797,8 @@ int ff_filter_get_nb_threads(AVFilterContext *ctx) return ctx->graph->nb_threads; } -static int process_options(AVFilterContext *ctx, AVDictionary **options, - const char *args) +int ff_filter_opt_parse(void *logctx, const AVClass *priv_class, + AVDictionary **options, const char *args) { const AVOption *o = NULL; int ret; @@ -812,8 +812,8 @@ static int process_options(AVFilterContext *ctx, AVDictionary **options, while (*args) { const char *shorthand = NULL; - if (ctx->filter->priv_class) - o = av_opt_next(ctx->priv, o); + if (priv_class) + o = av_opt_next(&priv_class, o); if (o) { if (o->type == AV_OPT_TYPE_CONST || o->offset == offset) continue; @@ -826,9 +826,9 @@ static int process_options(AVFilterContext *ctx, AVDictionary **options, &parsed_key, &value); if (ret < 0) { if (ret == AVERROR(EINVAL)) - av_log(ctx, AV_LOG_ERROR, "No option name near '%s'\n", args); + av_log(logctx, AV_LOG_ERROR, "No option name near '%s'\n", args); else - av_log(ctx, AV_LOG_ERROR, "Unable to parse '%s': %s\n", args, + av_log(logctx, AV_LOG_ERROR, "Unable to parse '%s': %s\n", args, av_err2str(ret)); return ret; } @@ -838,13 +838,13 @@ static int process_options(AVFilterContext *ctx, AVDictionary **options, key = parsed_key; /* discard all remaining shorthand */ - if (ctx->filter->priv_class) - while ((o = av_opt_next(ctx->priv, o))); + if (priv_class) + while ((o = av_opt_next(&priv_class, o))); } else { key = shorthand; } - av_log(ctx, AV_LOG_DEBUG, "Setting '%s' to value '%s'\n", key, value); + av_log(logctx, AV_LOG_DEBUG, "Setting '%s' to value '%s'\n", key, value); av_dict_set(options, key, value, AV_DICT_MULTIKEY); @@ -908,7 +908,7 @@ int avfilter_init_str(AVFilterContext *filter, const char *args) int ret = 0; if (args && *args) { - ret = process_options(filter, &options, args); + ret = ff_filter_opt_parse(filter, filter->filter->priv_class, &options, args); if (ret < 0) goto fail; } diff --git a/libavfilter/internal.h b/libavfilter/internal.h index aaf2c6c584..2ec41917f7 100644 --- a/libavfilter/internal.h +++ b/libavfilter/internal.h @@ -405,4 +405,17 @@ int ff_filter_process_command(AVFilterContext *ctx, const char *cmd, int ff_filter_init_hw_frames(AVFilterContext *avctx, AVFilterLink *link, int default_pool_size); +/** + * Parse filter options into a dictionary. + * + * @param logctx context for logging + * @param priv_class a filter's private class for shorthand options or NULL + * @param options dictionary to store parsed options in + * @param args options string to parse + * + * @return a non-negative number on success, a negative error code on failure + */ +int ff_filter_opt_parse(void *logctx, const AVClass *priv_class, + AVDictionary **options, const char *args); + #endif /* AVFILTER_INTERNAL_H */