diff mbox series

[FFmpeg-devel] doc/ffmpeg: extend -dts_delta_threshold option description

Message ID 20230125010744.255455-1-stefasab@gmail.com
State New
Headers show
Series [FFmpeg-devel] doc/ffmpeg: extend -dts_delta_threshold option description | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Stefano Sabatini Jan. 25, 2023, 1:07 a.m. UTC
---
 doc/ffmpeg.texi | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

Comments

Gyan Doshi Jan. 25, 2023, 5:17 a.m. UTC | #1
On 2023-01-25 06:37 am, Stefano Sabatini wrote:
> ---
>   doc/ffmpeg.texi | 17 +++++++++++++++--
>   1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 67b3294256..122f7e3387 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -1823,8 +1823,21 @@ results, but increase memory use and latency.
>   
>   The default value is 10 seconds.
>   
> -@item -dts_delta_threshold
> -Timestamp discontinuity delta threshold.
> +@item -dts_delta_threshold @var{threshold}
> +Timestamp discontinuity delta threshold, expressed as a floating point
> +number of @var{AV_TIME_BASE} units.
This is a CLI option and those users don't deal with AV_TIME_BASE . More 
useful to say it's in seconds.

> +
> +If a timestamp discontinuity is detected whose absolute value is
> +greater than @var{threshold} * @var{AV_TIME_BASE}, ffmpeg will remove the
> +discontinuity by decreasing/increasing the current DTS and PTS by the
> +corresponding delta value.

Might want to mention that this only applies to AV_FMT_DISCONT demuxers, 
or rather give a few examples, like MPEG-TS, HLS..etc.
For all other formats that users normally work with, clarify that only 
dts_error_threshold is relevant.

> +
> +Timestamp discontinuity correction can be inhibited by setting a big value for
> +@var{threshold}, and is automatically disabled when employing the
> +@code{-copy_ts} option.

For copy_ts, it is still applied for all negative deltas except the 
smallest.

Not blocking, but I'm reworking this code at present. Shouldn't really 
affect this patch. See 
https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305539.html

Regards,
Gyan
diff mbox series

Patch

diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index 67b3294256..122f7e3387 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -1823,8 +1823,21 @@  results, but increase memory use and latency.
 
 The default value is 10 seconds.
 
-@item -dts_delta_threshold
-Timestamp discontinuity delta threshold.
+@item -dts_delta_threshold @var{threshold}
+Timestamp discontinuity delta threshold, expressed as a floating point
+number of @var{AV_TIME_BASE} units.
+
+If a timestamp discontinuity is detected whose absolute value is
+greater than @var{threshold} * @var{AV_TIME_BASE}, ffmpeg will remove the
+discontinuity by decreasing/increasing the current DTS and PTS by the
+corresponding delta value.
+
+Timestamp discontinuity correction can be inhibited by setting a big value for
+@var{threshold}, and is automatically disabled when employing the
+@code{-copy_ts} option.
+
+Default value is 10.
+
 @item -dts_error_threshold @var{seconds}
 Timestamp error delta threshold. This threshold use to discard crazy/damaged
 timestamps and the default is 30 hours which is arbitrarily picked and quite