From patchwork Thu Feb 2 15:57:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan Doshi X-Patchwork-Id: 40218 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5494:b0:bf:7b3a:fd32 with SMTP id i20csp463641pzk; Thu, 2 Feb 2023 07:58:00 -0800 (PST) X-Google-Smtp-Source: AK7set+Zw0VU90X5nJ/MZe91KiDhIYufjHl8SSrnY0x8IlNEDgE58V6zNJ+uOPODM9b+l9KLPChz X-Received: by 2002:a17:906:305a:b0:873:699f:e87c with SMTP id d26-20020a170906305a00b00873699fe87cmr6787495ejd.71.1675353480497; Thu, 02 Feb 2023 07:58:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675353480; cv=none; d=google.com; s=arc-20160816; b=rbnA5YPzhXtjS6lYZV10gNCoKnmVa8/icBduxGaPRVVWOBnV4yVTK+GSzMTHmvUhUV U0qY70DOCqqk5+SfZJH+XhFx+3wOmceSF1qGXRCDS1C2EKjp0a2cl14HngveSepWsqLE iio/dcP5Uf39MOGlVVW0ZhslvEgqGzwjE3TrWIkENJcqVsBjrDrDHiH7+05tIPUnZL/6 wmc+uQx1mQvrPGxLQq2hgxfZdAc4gtV0K0jgRzjfDKIfbnZTVxPyoBiX/IS0KJFrW13K dAMlUB0+imKtwjIcYoAk8c2W0R3Z2mWl+5ckGKTv8MeSmuHMRVjLoNiZNuKgBq+ZD9x3 u7FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=wcvcdmq403hEdMyjiFz3siboxrl9DVYl/0ly7+QGUfk=; b=rowGNIFrM7Ucg3Bhh3wfVy00wN/RM3Gteu7QhIHIVFhifXU+AHuiKf6w/j5B1INAhb JJyf4OdmIWMKjH62v/Re7uopP6tIWhT3WEkR63ka1Eg9Aja8DbMaApk5spIv2WRLtqxW wumzLe/KluaEjYLyrj0Ckflz/9Mj+1BO8yJ2Ga2HQkGno83mcJ2fCx/021pEqrSKqFLw wZLwvHJfU4F2NmvqL9npIj6XYlVvvX5vfRVJ4ZYysofeb9QHqGoorj/ONmmXR5CfwNWD kBxauTDGYBnwesXyYm2PKvdH5rJEUOqtL7T6ymbxMk5tYfx1mOBm4xJSnX13+nNCMnx7 umnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 7-20020a17090601c700b008875432b6b0si16251972ejj.539.2023.02.02.07.57.59; Thu, 02 Feb 2023 07:58:00 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B1A3C68BDC9; Thu, 2 Feb 2023 17:57:47 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4DEA968BDC9 for ; Thu, 2 Feb 2023 17:57:41 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4P73Mk5rWNz9svY for ; Thu, 2 Feb 2023 16:57:38 +0100 (CET) From: Gyan Doshi To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Feb 2023 21:27:07 +0530 Message-Id: <20230202155707.29415-2-ffmpeg@gyani.pro> In-Reply-To: <20230202155707.29415-1-ffmpeg@gyani.pro> References: <20230202155707.29415-1-ffmpeg@gyani.pro> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avformat/flvenc: add option to read metadata from file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: OuF6Pm6dzKiJ Useful, in conjuntion with option meta_period, to vary metadata during stream. File format is ffmetadata. --- configure | 2 +- doc/muxers.texi | 3 + libavformat/flvenc.c | 134 +++++++++++++++++++++++++++++++++---------- 3 files changed, 108 insertions(+), 31 deletions(-) diff --git a/configure b/configure index 9d78a244a3..de371632c4 100755 --- a/configure +++ b/configure @@ -3433,7 +3433,7 @@ eac3_demuxer_select="ac3_parser" f4v_muxer_select="mov_muxer" fifo_muxer_deps="threads" flac_demuxer_select="flac_parser" -flv_muxer_select="aac_adtstoasc_bsf" +flv_muxer_select="aac_adtstoasc_bsf ffmetadata_demuxer" gxf_muxer_select="pcm_rechunk_bsf" hds_muxer_select="flv_muxer" hls_demuxer_select="adts_header ac3_parser" diff --git a/doc/muxers.texi b/doc/muxers.texi index 02ecddf186..000c92b2a7 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -555,6 +555,9 @@ With every video packet. @end table Note that metadata will always be re-emitted if a metadata update event is signalled. +@item meta_filename +Specify a ffmetadata file from which to load metadata. + @end table @anchor{framecrc} diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index d1c7a493d1..f41f5a361f 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -122,6 +122,10 @@ typedef struct FLVContext { double framerate; AVCodecParameters *data_par; + char *meta_filename; + AVFormatContext *meta_ctx; + AVDictionary *meta_dict; + int flags; int meta_period; } FLVContext; @@ -277,6 +281,92 @@ static void put_amf_bool(AVIOContext *pb, int b) avio_w8(pb, !!b); } +static int read_metadata_from_file(AVFormatContext *s, unsigned int ts, int header) +{ + FLVContext *flv = s->priv_data; + const AVInputFormat *meta_format = NULL; + AVDictionary *current_meta_dict = NULL; + float timestamp = ts/1000.f; + int ret; + + if (!flv->meta_filename) + return 0; + + meta_format = av_find_input_format("ffmetadata"); + if (!meta_format) { + av_log(s, AV_LOG_ERROR, "ffmetadata demuxer not found.\n"); + return AVERROR(ENOSYS); + } + + avformat_close_input(&flv->meta_ctx); + + ret = avformat_open_input(&flv->meta_ctx, flv->meta_filename, meta_format, NULL); + if (ret < 0) { + av_log(s, AV_LOG_ERROR, "Failed to read metadata from file %s t: %f.", flv->meta_filename, timestamp); + if (flv->meta_dict) + av_log(s, AV_LOG_ERROR, " Continuing with old metadata."); + av_log(s, AV_LOG_ERROR, "\n"); + return ret; + } + + if (flv->meta_dict) { + av_dict_copy(¤t_meta_dict, flv->meta_dict, 0); + av_dict_free(&flv->meta_dict); + } + + ret = av_dict_copy(&flv->meta_dict, flv->meta_ctx->metadata, 0); + if (ret < 0) { + av_log(s, AV_LOG_ERROR, "Could not transfer metadata from %s at %f seconds. Continuing with old metadata.\n", flv->meta_filename, timestamp); + av_dict_free(&flv->meta_dict); + av_dict_copy(&flv->meta_dict, current_meta_dict, 0); + av_dict_free(¤t_meta_dict); + return ret; + } + + av_log(s, AV_LOG_VERBOSE, "Metadata from file %s updated %s at %f seconds.\n", flv->meta_filename, header ? "in header" : "in video packet", timestamp); + av_dict_free(¤t_meta_dict); + avformat_close_input(&flv->meta_ctx); + + return 0; +} + +static int write_user_metadata_tag(AVFormatContext *s, AVDictionaryEntry *tag, AVIOContext *pb, int *metadata_count) +{ + + av_log(s, AV_LOG_DEBUG, "Writing tag %s with value %s count: %d\n", tag->key, tag->value, *metadata_count); + + if( !strcmp(tag->key, "width") + ||!strcmp(tag->key, "height") + ||!strcmp(tag->key, "videodatarate") + ||!strcmp(tag->key, "framerate") + ||!strcmp(tag->key, "videocodecid") + ||!strcmp(tag->key, "audiodatarate") + ||!strcmp(tag->key, "audiosamplerate") + ||!strcmp(tag->key, "audiosamplesize") + ||!strcmp(tag->key, "stereo") + ||!strcmp(tag->key, "audiocodecid") + ||!strcmp(tag->key, "duration") + ||!strcmp(tag->key, "onMetaData") + ||!strcmp(tag->key, "datasize") + ||!strcmp(tag->key, "lasttimestamp") + ||!strcmp(tag->key, "totalframes") + ||!strcmp(tag->key, "hasAudio") + ||!strcmp(tag->key, "hasVideo") + ||!strcmp(tag->key, "hasCuePoints") + ||!strcmp(tag->key, "hasMetadata") + ||!strcmp(tag->key, "hasKeyframes") + ){ + av_log(s, AV_LOG_DEBUG, "Ignoring metadata for %s\n", tag->key); + return AVERROR(EINVAL); + } + put_amf_string(pb, tag->key); + avio_w8(pb, AMF_DATA_TYPE_STRING); + put_amf_string(pb, tag->value); + (*metadata_count)++; + + return 0; +} + static void write_metadata(AVFormatContext *s, unsigned int ts) { AVIOContext *pb = s->pb; @@ -360,36 +450,11 @@ static void write_metadata(AVFormatContext *s, unsigned int ts) } ff_standardize_creation_time(s); - while ((tag = av_dict_iterate(s->metadata, tag))) { - if( !strcmp(tag->key, "width") - ||!strcmp(tag->key, "height") - ||!strcmp(tag->key, "videodatarate") - ||!strcmp(tag->key, "framerate") - ||!strcmp(tag->key, "videocodecid") - ||!strcmp(tag->key, "audiodatarate") - ||!strcmp(tag->key, "audiosamplerate") - ||!strcmp(tag->key, "audiosamplesize") - ||!strcmp(tag->key, "stereo") - ||!strcmp(tag->key, "audiocodecid") - ||!strcmp(tag->key, "duration") - ||!strcmp(tag->key, "onMetaData") - ||!strcmp(tag->key, "datasize") - ||!strcmp(tag->key, "lasttimestamp") - ||!strcmp(tag->key, "totalframes") - ||!strcmp(tag->key, "hasAudio") - ||!strcmp(tag->key, "hasVideo") - ||!strcmp(tag->key, "hasCuePoints") - ||!strcmp(tag->key, "hasMetadata") - ||!strcmp(tag->key, "hasKeyframes") - ){ - av_log(s, AV_LOG_DEBUG, "Ignoring metadata for %s\n", tag->key); - continue; - } - put_amf_string(pb, tag->key); - avio_w8(pb, AMF_DATA_TYPE_STRING); - put_amf_string(pb, tag->value); - metadata_count++; - } + + while (tag = av_dict_get(s->metadata, "", tag, AV_DICT_IGNORE_SUFFIX)) + write_user_metadata_tag(s, tag, pb, &metadata_count); + while (tag = av_dict_get(flv->meta_dict, "", tag, AV_DICT_IGNORE_SUFFIX)) + write_user_metadata_tag(s, tag, pb, &metadata_count); if (write_duration_filesize) { put_amf_string(pb, "filesize"); @@ -718,6 +783,7 @@ static int flv_write_header(AVFormatContext *s) if (flv->flags & FLV_NO_METADATA) { pb->seekable = 0; } else { + read_metadata_from_file(s, 0, 1); write_metadata(s, 0); } @@ -880,6 +946,8 @@ static int flv_write_packet(AVFormatContext *s, AVPacket *pkt) if (meta_upd_flag || (flv->meta_period == FLV_META_AT_KF && par->codec_type == AVMEDIA_TYPE_VIDEO && (pkt->flags & AV_PKT_FLAG_KEY)) || (flv->meta_period == FLV_META_EVERY_PACKET && par->codec_type == AVMEDIA_TYPE_VIDEO )) { + (flv->meta_period == 2 && par->codec_type == AVMEDIA_TYPE_VIDEO )) { + read_metadata_from_file(s, ts, 0); write_metadata(s, ts); if (meta_upd_flag) s->event_flags &= ~AVSTREAM_EVENT_FLAG_METADATA_UPDATED; @@ -1053,6 +1121,11 @@ static void flv_deinit(AVFormatContext *s) } flv->filepositions = flv->head_filepositions = NULL; flv->filepositions_count = 0; + + if (flv->meta_dict) + av_dict_free(&flv->meta_dict); + + avformat_close_input(&flv->meta_ctx); } static const AVOption options[] = { @@ -1066,6 +1139,7 @@ static const AVOption options[] = { { "at_start", "only once at start", 0, AV_OPT_TYPE_CONST, {.i64 = FLV_META_ONCE_AT_START}, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM, "meta_period" }, { "at_keyframes", "with every video keyframe", 0, AV_OPT_TYPE_CONST, {.i64 = FLV_META_AT_KF}, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM, "meta_period" }, { "every_packet", "with every video packet", 0, AV_OPT_TYPE_CONST, {.i64 = FLV_META_EVERY_PACKET}, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM, "meta_period" }, + { "meta_filename", "ffmetadata file to import metadata", offsetof(FLVContext, meta_filename), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, AV_OPT_FLAG_ENCODING_PARAM }, { NULL }, };