From patchwork Fri Feb 17 17:02:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan Doshi X-Patchwork-Id: 40424 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5494:b0:bf:7b3a:fd32 with SMTP id i20csp1499680pzk; Fri, 17 Feb 2023 09:03:35 -0800 (PST) X-Google-Smtp-Source: AK7set/hWShDZrKHm0KfssnfEY/LxzXi4mFfoHQuZ7gQmPCNIXAbraoQSB2yDDG5aFFa8/cT48mB X-Received: by 2002:a17:906:c55:b0:8b1:7dea:cc40 with SMTP id t21-20020a1709060c5500b008b17deacc40mr3677342ejf.9.1676653415171; Fri, 17 Feb 2023 09:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676653415; cv=none; d=google.com; s=arc-20160816; b=iKvXE3TnQGdfkumftAE/Rev24urhnuVbwQjx8IwaM170cHrrurgaxiKF9A2oqdXKos v918/RkjjLuMqXbStXItozJuaAoC6ZSeOVBFDVIF1Blyi0LRMJhxBCIxoNyYXkZeHMv9 3darfaRbl6rMr4RVHaQ2hb7cr7v5WvgN3c0QJuTM4xbMuZ0RC3lYSyPmwOAFnm49i6mz W8IjyXXzUZU0Hg71WneIQgUCb9JltfYwUqRl+6Oo/XBGfZ5WPf8k7q6DqzUjV7s7Tmka h1WE5wj0ngVNbZHShsoO2aWfqvK3jcamR5HadQON5E29atYiORtd/oUD5QTyhWESGjxt tlKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=nIcYIEIP1dXYzBcB8qaxajuY0ordCVDulyjac9pzQn8=; b=wMZu/O4f4AUqI5TM4yHqYnX+gQ4BoUhOFYY9Muv3I1KMH6+zjxibWyj0pmt/wG+gN+ i6Q03kMKVKgW6egEqAoNM+xx7tT+x4fd8bcRPpfhwpuwr5dY99mssGYFahpQt5TqQN6T 6PCafDStxOpkfKvJ+POpj28qZpZ84bqd4ieJwtViKwt1zf69hOp+euU/eiUoyVsjFjH5 nSdfCMWBg8bYylYI1/SSHkSBrQlCt0m8Gpq+QdFmNn+e599Mqob37H4CrEFb0fVXt3+R GOyYvqTKAWPJaM42tbul9DvTdg0htjBWrJbdGDW0rZeJDn87ngcSq6A5iPzQtm9MYOe3 AgCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v19-20020a17090651d300b008b13c785d5bsi6608354ejk.247.2023.02.17.09.03.34; Fri, 17 Feb 2023 09:03:35 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D62868BDFF; Fri, 17 Feb 2023 19:03:20 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 131CA68BE85 for ; Fri, 17 Feb 2023 19:03:13 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4PJJ6Q4FVGz9sWD for ; Fri, 17 Feb 2023 18:03:10 +0100 (CET) From: Gyan Doshi To: ffmpeg-devel@ffmpeg.org Date: Fri, 17 Feb 2023 22:32:46 +0530 Message-Id: <20230217170249.8148-2-ffmpeg@gyani.pro> In-Reply-To: <20230217170249.8148-1-ffmpeg@gyani.pro> References: <20230217170249.8148-1-ffmpeg@gyani.pro> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4PJJ6Q4FVGz9sWD Subject: [FFmpeg-devel] [PATCH v3 2/5] avformat: add av_program_copy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 42siGK1Ea7Rl Helper to transfer programs from one muxing context to another. --- doc/APIchanges | 3 ++ libavformat/avformat.c | 66 ++++++++++++++++++++++++++++++++++++++++++ libavformat/avformat.h | 22 ++++++++++++++ libavformat/version.h | 3 +- 4 files changed, 93 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 889f9925b1..2588c17560 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09 API changes, most recent first: +2023-02-xx - xxxxxxxxxx - lavf 60.4.100 - avformat.h + Add av_program_copy() + 2023-02-xx - xxxxxxxxxx - lavf 60.3.100 - avformat.h Add av_program_add_stream_index2(). diff --git a/libavformat/avformat.c b/libavformat/avformat.c index 0f203e4f86..64741b6f4a 100644 --- a/libavformat/avformat.c +++ b/libavformat/avformat.c @@ -369,6 +369,72 @@ void av_program_add_stream_index(AVFormatContext *ac, int progid, unsigned idx) return; } +int av_program_copy(AVFormatContext *dst, const AVFormatContext *src, int progid, int overwrite) +{ + const AVProgram *src_prog = NULL; + AVProgram *dst_prog = NULL; + int ret, idx = -1; + + for (unsigned i = 0; i < src->nb_programs; i++) + if (src->programs[i]->id == progid) + src_prog = src->programs[i]; + + if (!src_prog) { + av_log(dst, AV_LOG_ERROR, "source program not found: id=0x%04x\n", progid); + return AVERROR(EINVAL); + } + + for (unsigned i = 0; i < dst->nb_programs; i++) { + if (dst->programs[i]->id == progid) + idx = i; + } + + if (idx >= 0 && !overwrite) { + av_log(dst, AV_LOG_WARNING, "target muxer already has program with id=0x%04x; not overwriting\n", progid); + return 0; + } + + av_log(dst, AV_LOG_TRACE, "%s program: id=0x%04x\n", idx >= 0 ? "overwriting" : "copying", progid); + + if (idx >= 0) { + dst_prog = dst->programs[idx]; + av_dict_free(&dst_prog->metadata); + av_freep(&dst_prog->stream_index); + dst_prog->nb_stream_indexes = 0; + } else { + dst_prog = av_mallocz(sizeof(*dst_prog)); + if (!dst_prog) + return AVERROR(ENOMEM); + ret = av_dynarray_add_nofree(&dst->programs, &dst->nb_programs, dst_prog); + if (ret < 0) { + av_free(dst_prog); + return ret; + } + } + + /* public fields */ + dst_prog->id = src_prog->id; + dst_prog->flags = src_prog->flags; + dst_prog->discard = src_prog->discard; + dst_prog->program_num = src_prog->program_num; + dst_prog->pmt_pid = src_prog->pmt_pid; + dst_prog->pcr_pid = src_prog->pcr_pid; + dst_prog->pmt_version = src_prog->pmt_version; + + for (unsigned i = 0; i < dst->nb_streams; i++) { + for (unsigned j = 0; j < src_prog->nb_stream_indexes; j++) + if (dst->streams[i]->id == src->streams[src_prog->stream_index[j]]->id) { + if (ret = av_program_add_stream_index2(dst, dst_prog->id, i) < 0) + return ret; + } + } + + if (ret = av_dict_copy(&dst_prog->metadata, src_prog->metadata, 0) < 0) + return ret; + + return 0; +} + AVProgram *av_find_program_from_stream(AVFormatContext *ic, AVProgram *last, int s) { for (unsigned i = 0; i < ic->nb_programs; i++) { diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 33ab0bc8ba..46b4d177c3 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1886,6 +1886,28 @@ uint8_t *av_stream_get_side_data(const AVStream *stream, AVProgram *av_new_program(AVFormatContext *s, int id); +/** + * Copy an AVProgram from one AVFormatContext to another. + * + * Streams in the destination context whose IDs match the IDs of the streams in the + * source AVProgram index are added to the stream index of the copied AVProgram. + * + * If a new program has to be added, the function expects and requires any existing buffer + * holding the array of pointers to AVPrograms in the destination context to have its size + * be a power-of-two value. This should be the case if all earlier programs were created + * using av_new_program or this function. + * + * @param dst pointer to the target muxer context + * @param src pointer to the source muxer context + * @param progid ID of the program to be copied + * @param overwrite whether to overwrite if target muxer already + * contains a program with the same ID + * + * @return >= 0 in case of success, a negative AVERROR code in case of + * failure + */ +int av_program_copy(AVFormatContext *dst, const AVFormatContext *src, int progid, int overwrite); + /** * @} */ diff --git a/libavformat/version.h b/libavformat/version.h index 7ff1483912..62fa908659 100644 --- a/libavformat/version.h +++ b/libavformat/version.h @@ -31,7 +31,8 @@ #include "version_major.h" -#define LIBAVFORMAT_VERSION_MINOR 3 +#define LIBAVFORMAT_VERSION_MINOR 4 + #define LIBAVFORMAT_VERSION_MICRO 100 #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \