From patchwork Mon Feb 20 19:29:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 40456 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5494:b0:bf:7b3a:fd32 with SMTP id i20csp2166747pzk; Mon, 20 Feb 2023 11:30:28 -0800 (PST) X-Google-Smtp-Source: AK7set+Cye4iAvqTZOal6S7a+So5lojXpD8chk2bveA06VNTJYXDDrGOZJycucYigtwwWQVg7fyY X-Received: by 2002:a17:906:eca1:b0:87d:eff1:acc8 with SMTP id qh1-20020a170906eca100b0087deff1acc8mr9803624ejb.48.1676921428558; Mon, 20 Feb 2023 11:30:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676921428; cv=none; d=google.com; s=arc-20160816; b=ANwzbqo0O0k8lYIUOQVKqY5Ufhvxr9vP3IjWg1E16AMZ5tQO7JfXeMYshTzRYBXnQY PEHnXvR8Hdi/1gp6p4mJuYDI5YMWvAXz2upfCxfFGZqEk4sPJQmmulCURfQqcB4qJ2GZ x1zMdRJE4f6lZun92KqScy2YTro8R87GEdai7KD5Ae2zDjanIP9WQIMu0kGvPvi6iHiO kxfhyvnYtnwbPz3til049KgPccaP0mZi3H/tlyeujGVvV38W3VcB1mTEzIxmSXB6DY49 KK1jDvCPxbgSOsRXpuELbcegY1O6egkmqT2PJ/iFXKLl5uS6l0sIcCWo0o6LJDLddSMf pJ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=pnQ7KdLoPnJ/UN//9GsaQjbA6f7lqh9uUDsh7iGn7Jw=; b=yNjkSu3kPHlOUnkcLi5RPwFwZBi++RY28ElTXJCqXon9Qik+ynfozGzqD3S2UYjUSl jrDe16SImkagCQ004iQ8Xh9eEQrCcflt8RHIHpa15UXCCCYRXbjVnMNlQeiFpKo8RkkO /HN9w92wex6UfqibDyCflSYHi6Z2zvUtBCAmrgcuBk63yX77/ufXUWGEY4VSC7KgyLqj Rgu4synmCM0dYGr18XGRXM1B1B84yTDKqUmRjLXyHxbdAavw5D9D1qUwk4vt9eAtsgTd ZnYdDIFv1i2z/eOE7umUZ0+u9ZV+/iFGSZlsTB85P4bKblMSGCrenmzHc07L9frwcaVT srSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id wl17-20020a170907311100b008b174de7f17si12488191ejb.824.2023.02.20.11.30.28; Mon, 20 Feb 2023 11:30:28 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFB2D68C0B0; Mon, 20 Feb 2023 21:29:51 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 96FE568C0AB for ; Mon, 20 Feb 2023 21:29:44 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 9F4EDE0002 for ; Mon, 20 Feb 2023 19:29:43 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 20 Feb 2023 20:29:29 +0100 Message-Id: <20230220192929.4493-6-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230220192929.4493-1-michael@niedermayer.cc> References: <20230220192929.4493-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 6/6] avcodec/rka: avoid undefined doubling sum overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QeLtiyB7vjjn Fixes: signed integer overflow: -2124073172 * 2 cannot be represented in type 'int' Fixes: 56099/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-4530933127839744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rka.c b/libavcodec/rka.c index 1eb2289e58..2212e3f930 100644 --- a/libavcodec/rka.c +++ b/libavcodec/rka.c @@ -724,7 +724,7 @@ static int decode_filter(RKAContext *s, ChContext *ctx, ACoder *ac, int off, uns src = &ctx->buf1[off + -1]; for (int i = 0; i < filt.size && i < 15; i++) sum += filt.coeffs[i] * (unsigned)src[-i]; - sum = sum * 2; + sum = sum * 2U; for (int i = 15; i < filt.size; i++) sum += filt.coeffs[i] * (unsigned)src[-i]; sum = sum >> 6;