diff mbox series

[FFmpeg-devel,1/3] lavc/codec.h: add AV_CODEC_CAP_SINGLE_SUB_RECT

Message ID 20230221002516.25784-1-rcombs@rcombs.me
State New
Headers show
Series [FFmpeg-devel,1/3] lavc/codec.h: add AV_CODEC_CAP_SINGLE_SUB_RECT | expand

Checks

Context Check Description
andriy/configure_x86 warning Failed to apply patch
yinshiyou/configure_loongarch64 warning Failed to apply patch

Commit Message

rcombs Feb. 21, 2023, 12:25 a.m. UTC
---
 doc/APIchanges       | 3 +++
 libavcodec/codec.h   | 5 +++++
 libavcodec/version.h | 2 +-
 3 files changed, 9 insertions(+), 1 deletion(-)

Comments

Nicolas George Feb. 21, 2023, 7:42 a.m. UTC | #1
rcombs (12023-02-20):
> ---
>  doc/APIchanges       | 3 +++
>  libavcodec/codec.h   | 5 +++++
>  libavcodec/version.h | 2 +-
>  3 files changed, 9 insertions(+), 1 deletion(-)

And... No change to the framework to make use of this flag? Like, return
AVERROR(EINVAL) if the flag is present but several rectangles are given?

Regards,
rcombs Feb. 21, 2023, 8:07 a.m. UTC | #2
> On Feb 21, 2023, at 01:42, Nicolas George <george@nsup.org> wrote:
> 
> rcombs (12023-02-20):
>> ---
>> doc/APIchanges       | 3 +++
>> libavcodec/codec.h   | 5 +++++
>> libavcodec/version.h | 2 +-
>> 3 files changed, 9 insertions(+), 1 deletion(-)
> 
> And... No change to the framework to make use of this flag? Like, return
> AVERROR(EINVAL) if the flag is present but several rectangles are given?

I didn't want to break existing applications further, though I don't feel strongly about it either way (since the existing behavior is already very poor).

> 
> Regards,
> 
> -- 
>  Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/doc/APIchanges b/doc/APIchanges
index bc52a07964..56f33aa25b 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -14,6 +14,9 @@  libavutil:     2021-04-27
 
 API changes, most recent first:
 
+2023-02-20 - xxxxxxxxxx - lavc 59.60.100 - codec.h
+  Add AV_CODEC_CAP_SINGLE_SUB_RECT.
+
 2023-01-29 - xxxxxxxxxx - lavc 59.59.100 - avcodec.h
   Add AV_CODEC_FLAG_COPY_OPAQUE and AV_CODEC_FLAG_FRAME_DURATION.
 
diff --git a/libavcodec/codec.h b/libavcodec/codec.h
index 77a1a3f5a2..c0df33ef3c 100644
--- a/libavcodec/codec.h
+++ b/libavcodec/codec.h
@@ -190,6 +190,11 @@ 
  */
 #define AV_CODEC_CAP_ENCODER_RECON_FRAME (1 << 22)
 
+/**
+ * This encoder requires a single rectangle per AVSubtitle.
+ */
+#define AV_CODEC_CAP_SINGLE_SUB_RECT (1 << 23)
+
 /**
  * AVProfile.
  */
diff --git a/libavcodec/version.h b/libavcodec/version.h
index 752adc81f8..2ed4ef5547 100644
--- a/libavcodec/version.h
+++ b/libavcodec/version.h
@@ -29,7 +29,7 @@ 
 
 #include "version_major.h"
 
-#define LIBAVCODEC_VERSION_MINOR  59
+#define LIBAVCODEC_VERSION_MINOR  60
 #define LIBAVCODEC_VERSION_MICRO 100
 
 #define LIBAVCODEC_VERSION_INT  AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \