diff mbox series

[FFmpeg-devel,v2] avcodec/mjpegdec: support weird RGB subsampling with progressive

Message ID 20230316193214.24025-1-leo.izen@gmail.com
State Accepted
Commit b18a9c29713abc3a1b081de3f320ab53a47120c6
Headers show
Series [FFmpeg-devel,v2] avcodec/mjpegdec: support weird RGB subsampling with progressive | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Leo Izen March 16, 2023, 7:32 p.m. UTC 
This allows weird subsampling with progressive JPEGs to be decoded,
such as full-RG and only B subsampled.
---
 libavcodec/mjpegdec.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

Comments

Leo Izen March 31, 2023, 8:36 a.m. UTC | #1 
On 3/16/23 15:32, Leo Izen wrote:
> This allows weird subsampling with progressive JPEGs to be decoded,
> such as full-RG and only B subsampled.
> ---
>   libavcodec/mjpegdec.c | 27 +++++++++++++++++----------
>   1 file changed, 17 insertions(+), 10 deletions(-)
> 

Bumping for review, thanks.

- Leo Izen (thebombzen)
Leo Izen April 7, 2023, 2:15 p.m. UTC | #2 
On 3/16/23 15:32, Leo Izen wrote:
> This allows weird subsampling with progressive JPEGs to be decoded,
> such as full-RG and only B subsampled.
> ---
>   libavcodec/mjpegdec.c | 27 +++++++++++++++++----------
>   1 file changed, 17 insertions(+), 10 deletions(-)
> 

Will apply in a few days.

- Leo Izen (thebombzen)
Leo Izen April 10, 2023, 9:07 a.m. UTC | #3 
On 4/7/23 10:15, Leo Izen wrote:
> On 3/16/23 15:32, Leo Izen wrote:
>> This allows weird subsampling with progressive JPEGs to be decoded,
>> such as full-RG and only B subsampled.
>> ---
>>   libavcodec/mjpegdec.c | 27 +++++++++++++++++----------
>>   1 file changed, 17 insertions(+), 10 deletions(-)
>>
> 
> Will apply in a few days.
> 
> - Leo Izen (thebombzen)

Applied as b18a9c29713abc3a1b081de3f320ab53a47120c6.

- Leo Izen (thebombzen)
diff mbox series

Patch

diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
index c833d66c4d..3fc18aac73 100644
--- a/libavcodec/mjpegdec.c
+++ b/libavcodec/mjpegdec.c
@@ -571,10 +571,15 @@  int ff_mjpeg_decode_sof(MJpegDecodeContext *s)
         case 0x22221100:
         case 0x22112200:
         case 0x11222200:
-            if (s->bits <= 8) s->avctx->pix_fmt = s->cs_itu601 ? AV_PIX_FMT_YUV444P : AV_PIX_FMT_YUVJ444P;
-            else
+            if (s->bits > 8)
                 goto unk_pixfmt;
-            s->avctx->color_range = s->cs_itu601 ? AVCOL_RANGE_MPEG : AVCOL_RANGE_JPEG;
+            if (s->adobe_transform == 0 || s->component_id[0] == 'R' &&
+                    s->component_id[1] == 'G' && s->component_id[2] == 'B') {
+                s->avctx->pix_fmt = AV_PIX_FMT_GBRP;
+            } else {
+                s->avctx->pix_fmt = s->cs_itu601 ? AV_PIX_FMT_YUV444P : AV_PIX_FMT_YUVJ444P;
+                s->avctx->color_range = s->cs_itu601 ? AVCOL_RANGE_MPEG : AVCOL_RANGE_JPEG;
+            }
             break;
         case 0x11000000:
         case 0x13000000:
@@ -673,10 +678,6 @@  int ff_mjpeg_decode_sof(MJpegDecodeContext *s)
             avpriv_report_missing_feature(s->avctx, "Lowres for weird subsampling");
             return AVERROR_PATCHWELCOME;
         }
-        if ((AV_RB32(s->upscale_h) || AV_RB32(s->upscale_v)) && s->progressive && s->avctx->pix_fmt == AV_PIX_FMT_GBRP) {
-            avpriv_report_missing_feature(s->avctx, "progressive for weird subsampling");
-            return AVERROR_PATCHWELCOME;
-        }
         if (s->ls) {
             memset(s->upscale_h, 0, sizeof(s->upscale_h));
             memset(s->upscale_v, 0, sizeof(s->upscale_v));
@@ -1697,9 +1698,6 @@  int ff_mjpeg_decode_sos(MJpegDecodeContext *s, const uint8_t *mb_bitmask,
         s->h_scount[i]  = s->h_count[index];
         s->v_scount[i]  = s->v_count[index];
 
-        if((nb_components == 1 || nb_components == 3) && s->nb_components == 3 && s->avctx->pix_fmt == AV_PIX_FMT_GBR24P)
-            index = (index+2)%3;
-
         s->comp_index[i] = index;
 
         s->dc_index[i] = get_bits(&s->gb, 4);
@@ -2722,6 +2720,15 @@  the_end:
             }
         }
     }
+
+    if (s->avctx->pix_fmt == AV_PIX_FMT_GBRP) {
+        av_assert0(s->nb_components == 3);
+        FFSWAP(uint8_t *, frame->data[0], frame->data[2]);
+        FFSWAP(uint8_t *, frame->data[0], frame->data[1]);
+        FFSWAP(int, frame->linesize[0], frame->linesize[2]);
+        FFSWAP(int, frame->linesize[0], frame->linesize[1]);
+    }
+
     if (s->adobe_transform == 0 && s->avctx->pix_fmt == AV_PIX_FMT_GBRAP) {
         int w = s->picture_ptr->width;
         int h = s->picture_ptr->height;