From patchwork Thu Mar 30 09:38:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 40920 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4645:b0:e3:3194:9d20 with SMTP id eb5csp1184903pzb; Thu, 30 Mar 2023 02:38:59 -0700 (PDT) X-Google-Smtp-Source: AKy350YUHIos+R4EEYPIEBUUu7OHkTSD7jaXqCXowbWO4ltvJetgZGdsbPRAt44k85NpTOKaqudp X-Received: by 2002:a17:906:ef90:b0:8b2:7567:9c30 with SMTP id ze16-20020a170906ef9000b008b275679c30mr27968900ejb.59.1680169139086; Thu, 30 Mar 2023 02:38:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680169139; cv=none; d=google.com; s=arc-20160816; b=cHxf+tFpSLN96mBA0MX7yUBql6NrybPifvEguyPesRo2b+NgCrSfhQCte6cAF5dJyv rVLbbv6tOhsArVr/CrcQVdSqnSgdooX1l97CNLC+3vEi2ai5TWnHosYtsSdorPy9U97G YjLg+wceCSC4JorqnXmYfJyEtbyyPpGLoJ0EeBK+TC701JEG80YzpUn92B4qzpp0SXRO Xo1W0xEgfVudirnWFHGRs6SL12hCZ6QJuBmGGVdbZaV2I1hqyInpkrBqxPuRFPi+46Qt /8CCVzok6Y9ltnO4/F9cbBe2x0DmxLof+ocfacy+HryfwWS8/yKnDITGAiVVIY6cIMrG oYVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=SjRygo+tqHXsn1h++4y+2jlQFzbGmDAxLNeo4s6LvnM=; b=JwIA6LO443/hz07knmjES+ct6D43NGxNQeWuBxgfxqsjcY9QwTc2MivkUfMc9c1Gca uGQkjevQWtWeoWw+6BKSiP2mTsuLqdyxFs3g+Q6DhKI6x18IVb8aVIgHBnmaXHOqSZfl SghO5n7QY8Ru8NcmUxV9dS/CQqS59CpI2L7+SoIMihAhPuG+p/PsqNZjWD2RnU5TXpNm JHDCYxJGMySC/DqEz4u/TqyrtSftECQsujz3rGw7UJ9i8qDQBYZfoU+gm/H20zmSE+2g 8N4fltDOkcPkdSanpqtIvcVeKdWAhvd1qXZSBnvkcPWnpnTLWDjpP+/arpzz4AjWQUMS 5Anw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qw36-20020a1709066a2400b0094415aa2c5fsi10830811ejc.977.2023.03.30.02.38.58; Thu, 30 Mar 2023 02:38:59 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1974868C620; Thu, 30 Mar 2023 12:38:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7366768C532 for ; Thu, 30 Mar 2023 12:38:38 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 365622404EC for ; Thu, 30 Mar 2023 11:38:38 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id C6uNJnFbUYCm for ; Thu, 30 Mar 2023 11:38:37 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6E5802404EE for ; Thu, 30 Mar 2023 11:38:37 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 17CE53A038E for ; Thu, 30 Mar 2023 11:38:31 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Thu, 30 Mar 2023 11:38:07 +0200 Message-Id: <20230330093809.22687-1-anton@khirnov.net> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: yfQexxxmzWb/ An uninitialized AVFormatContext instance with neither iformat nor oformat set will currently log as 'NULL', which is confusing and unhelpful. Print 'AVFormatContext' instead, which provides more information. This happens e.g. if choosing an output format fails in avformat_alloc_output_context2(). --- libavformat/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/options.c b/libavformat/options.c index 22ad523b2d..e4a3aceed0 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr) AVFormatContext* fc = (AVFormatContext*) ptr; if(fc->iformat) return fc->iformat->name; else if(fc->oformat) return fc->oformat->name; - else return "NULL"; + else return fc->av_class->class_name; } static void *format_child_next(void *obj, void *prev)