diff mbox series

[FFmpeg-devel] fate/png-icc-parse: update ref data

Message ID 20230409030721.19997-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel] fate/png-icc-parse: update ref data | expand

Checks

Context Check Description
andriy/configure_x86 warning Failed to apply patch
yinshiyou/configure_loongarch64 warning Failed to apply patch

Commit Message

Steven Liu April 9, 2023, 3:07 a.m. UTC 
When enable lcms2, the fate-png-icc-parse will get error bellow.
TEST    png-icc-parse

Comments

Leo Izen April 10, 2023, 1:14 p.m. UTC | #1 
On 4/8/23 23:07, Steven Liu wrote:
> When enable lcms2, the fate-png-icc-parse will get error bellow.
> TEST    png-icc-parse

I believe this change happened when I updated how PNG handles colors (no 
longer using mastering display metadata for that). Good catch!

- Leo Izen (thebombzen)
Steven Liu April 11, 2023, 1:53 a.m. UTC | #2 
Leo Izen <leo.izen@gmail.com> 于2023年4月10日周一 21:14写道：
>
> On 4/8/23 23:07, Steven Liu wrote:
> > When enable lcms2, the fate-png-icc-parse will get error bellow.
> > TEST    png-icc-parse
>
> I believe this change happened when I updated how PNG handles colors (no
> longer using mastering display metadata for that). Good catch!

Should i apply this patch?



Thanks
Steven
Steven Liu April 21, 2023, 6:08 a.m. UTC | #3 
Leo Izen <leo.izen@gmail.com> 于2023年4月10日周一 21:14写道：
>
> On 4/8/23 23:07, Steven Liu wrote:

> > When enable lcms2, the fate-png-icc-parse will get error bellow.
> > TEST    png-icc-parse
>
> I believe this change happened when I updated how PNG handles colors (no
> longer using mastering display metadata for that). Good catch!
>

Applied.


Thanks
Steven
diff mbox series

Patch

--- src/tests/ref/fate/png-icc-parse    2022-09-09 16:12:35.786357375 +0800
+++ tests/data/fate/png-icc-parse       2023-04-09 11:00:14.256826477 +0800
@@ -16,6 +16,10 @@ 
 pkt_size=40194
 width=128
 height=128
+crop_top=0
+crop_bottom=0
+crop_left=0
+crop_right=0
 pix_fmt=rgb24
 sample_aspect_ratio=1:1
 pict_type=I
@@ -25,7 +29,7 @@ 
 top_field_first=0
 repeat_pict=0
 color_range=pc
-color_space=unknown
+color_space=gbr
 color_primaries=bt709
 color_transfer=iec61966-2-1
 chroma_location=unspecified
@@ -34,15 +38,4 @@ 
 name=Photoshop ICC profile
 size=3144
 [/SIDE_DATA]
-[SIDE_DATA]
-side_data_type=Mastering display metadata
-red_x=63999/100000
-red_y=33001/100000
-green_x=30000/100000
-green_y=60000/100000
-blue_x=15000/100000
-blue_y=5999/100000
-white_point_x=31269/100000
-white_point_y=32899/100000
-[/SIDE_DATA]
 [/FRAME]
Test png-icc-parse failed. Look at tests/data/fate/png-icc-parse.err for details.
make: *** [src/tests/Makefile:306：fate-png-icc-parse] error 1

This patch can fix it.

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 tests/ref/fate/png-icc-parse | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/tests/ref/fate/png-icc-parse b/tests/ref/fate/png-icc-parse
index 18bb18a804..ffefce270a 100644
--- a/tests/ref/fate/png-icc-parse
+++ b/tests/ref/fate/png-icc-parse
@@ -16,6 +16,10 @@  pkt_pos=0
 pkt_size=40194
 width=128
 height=128
+crop_top=0
+crop_bottom=0
+crop_left=0
+crop_right=0
 pix_fmt=rgb24
 sample_aspect_ratio=1:1
 pict_type=I
@@ -25,7 +29,7 @@  interlaced_frame=1
 top_field_first=0
 repeat_pict=0
 color_range=pc
-color_space=unknown
+color_space=gbr
 color_primaries=bt709
 color_transfer=iec61966-2-1
 chroma_location=unspecified
@@ -34,15 +38,4 @@  side_data_type=ICC profile
 name=Photoshop ICC profile
 size=3144
 [/SIDE_DATA]
-[SIDE_DATA]
-side_data_type=Mastering display metadata
-red_x=63999/100000
-red_y=33001/100000
-green_x=30000/100000
-green_y=60000/100000
-blue_x=15000/100000
-blue_y=5999/100000
-white_point_x=31269/100000
-white_point_y=32899/100000
-[/SIDE_DATA]
 [/FRAME]