From patchwork Sun Apr 9 14:26:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 41074 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4645:b0:e3:3194:9d20 with SMTP id eb5csp1598612pzb; Sun, 9 Apr 2023 07:26:57 -0700 (PDT) X-Google-Smtp-Source: AKy350ZSrrzeaNN6RdCNNQzz60ZDhKS2ofde/hXgHYB6fu2HnzRrDAYDN5HGSgy7Qm6SRYGfVoHw X-Received: by 2002:aa7:c399:0:b0:502:928d:4c8d with SMTP id k25-20020aa7c399000000b00502928d4c8dmr4240980edq.0.1681050417205; Sun, 09 Apr 2023 07:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681050417; cv=none; d=google.com; s=arc-20160816; b=nyNTwxX7W9V5xLWNYQF3+n6SWgQaTxpC9rOXdpU3N8JALFC13AesFv3nKM8d6z7/8W rkJ69WLyZF63GcyQ9ea5zYmzFyCK7icTeUlL0NzVK1PX+z5W5vPhA88kTF8VvLpznVa/ Cz9kSvciA8O2NRUqyyc1f/heteg9nTleqZIEFBBBmcV+YIas+Phgbi4q7miDLIf1/9q4 lIDmCiV+OHa9O5eYZ8VU5XNTizAOYD8roanjcwAYYIVOa7OQ4aBJ7eB2GPGrnmShm+BG nLBHhJ9Y0z9jMN7ia9Na7xoOoWYpm/7LGVmqqjgxe77wZrpx9mjg6n/9VfarvP4UIrTw mStA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=G3RkNAwxd+rad5ypnJCHEJeEswNHy6d8xyoO+Y4MUWE=; b=JHeXF+yaYLArfcCk5evRr5YCHPBdgfZi/Fa48n0N+KFAosP8Lq4bjRIPIgSoehx2Ke 4/8vXUubP/XuXsXePKSVBac/QzXKpiKe0d3Fz39TnX5d70gEAJkJUDzeg9EDYK2arnsS a5MBl4wHbd7xInle5vBrz+HR7hcD8VNl7zL9gtHxlutekyU+zBjqamxtJ3V28EZcehXZ lMtXGoexfk5QJPAme8I3JTcU1TEbANiTx7MZsdenXDee0XCoJIi8sfDY7IISRHcPSUpK TdusqPl/XiTWoS4QF7Twnir2nJpBnleHnm+p4tLsKtD88SNaR32vvJfk0dufdKyVZ1XE EjHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u6-20020a056402064600b005047e09b249si4787269edx.389.2023.04.09.07.26.56; Sun, 09 Apr 2023 07:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A66C68BCC3; Sun, 9 Apr 2023 17:26:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BA2A68AD9B for ; Sun, 9 Apr 2023 17:26:31 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7A2B760002 for ; Sun, 9 Apr 2023 14:26:30 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 9 Apr 2023 16:26:24 +0200 Message-Id: <20230409142627.19820-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230409142627.19820-1-michael@niedermayer.cc> References: <20230409142627.19820-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 3/6] avcodec/rka: Fix signed integer overflow in decode_filter() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: hI+e5a15UsM5 Fixes: signed integer overflow: -631553 * 32768 cannot be represented in type 'int' Fixes: 57814/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-4614661233573888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rka.c b/libavcodec/rka.c index 2212e3f9306..3e86d83819c 100644 --- a/libavcodec/rka.c +++ b/libavcodec/rka.c @@ -737,7 +737,7 @@ static int decode_filter(RKAContext *s, ChContext *ctx, ACoder *ac, int off, uns } ctx->buf0[off] = ctx->buf1[off] + ctx->buf0[off + -1]; } else { - val *= 1 << ctx->cmode; + val *= 1U << ctx->cmode; sum += ctx->buf0[off + -1] + val; switch (s->bps) { case 16: sum = av_clip_int16(sum); break;