diff mbox series

[FFmpeg-devel,v2,01/12] avutil/frame: add AVFrameSideDataSet for passing sets of side data

Message ID 20230411212052.159889-2-jeebjp@gmail.com
State New
Headers show
Series encoder AVCodecContext configuration side data | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Jan Ekström April 11, 2023, 9:20 p.m. UTC 
---
 libavutil/frame.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Anton Khirnov April 12, 2023, 8:29 a.m. UTC | #1 
Quoting Jan Ekström (2023-04-11 23:20:41)
> ---
>  libavutil/frame.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 5b58c14ac3..45024c2a03 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -241,6 +241,14 @@ typedef struct AVFrameSideData {
>      AVBufferRef *buf;
>  } AVFrameSideData;
>  
> +/**
> + * Structure to hold a set of AVFrameSideData
> + */
> +typedef struct AVFrameSideDataSet {
> +    AVFrameSideData **side_data;
> +    int            nb_side_data;

The names are unnecessarily long and thus annoying to type IMO. The
type already has a descriptive name and the struct instance itself will
typically contain 'side_data' in its name.

Make those '[nb_]sd' or '[nb]_elem' or something short like this.
diff mbox series

Patch

diff --git a/libavutil/frame.h b/libavutil/frame.h
index 5b58c14ac3..45024c2a03 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -241,6 +241,14 @@  typedef struct AVFrameSideData {
     AVBufferRef *buf;
 } AVFrameSideData;
 
+/**
+ * Structure to hold a set of AVFrameSideData
+ */
+typedef struct AVFrameSideDataSet {
+    AVFrameSideData **side_data;
+    int            nb_side_data;
+} AVFrameSideDataSet;
+
 /**
  * Structure describing a single Region Of Interest.
  *