[FFmpeg-devel] fate/h264: add a test disabling cropping

Message ID	20230421121249.1527-1-jamrial@gmail.com
State	New
Headers	show Delivered-To: ffmpegpatchwork2@gmail.com Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Date: Fri, 21 Apr 2023 09:12:49 -0300 Message-Id: <20230421121249.1527-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fate/h264: add a test disabling cropping Precedence: list Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Series	[FFmpeg-devel] fate/h264: add a test disabling cropping \| expand [FFmpeg-devel] fate/h264: add a test disabling cropping

Message ID

20230421121249.1527-1-jamrial@gmail.com

State

New

Headers

Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org
 designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100;
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Fri, 21 Apr 2023 09:12:49 -0300
Message-Id: <20230421121249.1527-1-jamrial@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH] fate/h264: add a test disabling cropping
Precedence: list
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Series

[FFmpeg-devel] fate/h264: add a test disabling cropping | expand

Checks

Context	Check	Description
yinshiyou/make_loongarch64	success	Make finished
yinshiyou/make_fate_loongarch64	success	Make fate finished
andriy/make_x86	success	Make finished
andriy/make_fate_x86	success	Make fate finished

Context

Check

Description

yinshiyou/make_loongarch64

success

Make finished

yinshiyou/make_fate_loongarch64

success

Make fate finished

andriy/make_x86

success

Make finished

andriy/make_fate_x86

success

Make fate finished

Commit Message

James Almer April 21, 2023, 12:12 p.m. UTC

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/fate/h264.mak             |  4 ++
 tests/ref/fate/h264-no-cropping | 95 +++++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 tests/ref/fate/h264-no-cropping

Comments

James Almer April 22, 2023, 2:14 p.m. UTC | #1

On 4/21/2023 9:12 AM, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   tests/fate/h264.mak             |  4 ++
>   tests/ref/fate/h264-no-cropping | 95 +++++++++++++++++++++++++++++++++
>   2 files changed, 99 insertions(+)
>   create mode 100644 tests/ref/fate/h264-no-cropping
> 
> diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
> index 173806861a..cd2ad79ea2 100644
> --- a/tests/fate/h264.mak
> +++ b/tests/fate/h264.mak
> @@ -232,6 +232,7 @@ FATE_H264-$(call FRAMECRC, MOV, H264) += fate-h264-attachment-631
>   FATE_H264-$(call FRAMECRC, MPEGTS, H264, H264_PARSER MP3_DECODER SCALE_FILTER ARESAMPLE_FILTER) += fate-h264-skip-nokey fate-h264-skip-nointra
>   FATE_H264_FFPROBE-$(call DEMDEC, MATROSKA, H264) += fate-h264-dts_5frames
>   FATE_H264_FFPROBE-$(call PARSERDEMDEC, H264, H264, H264) += fate-h264-afd
> +FATE_H264_FFPROBE-$(call PARSERDEMDEC, H264, H264, H264) += fate-h264-no-cropping
>   
>   FATE_SAMPLES_AVCONV += $(FATE_H264-yes)
>   FATE_SAMPLES_FFPROBE += $(FATE_H264_FFPROBE-yes)
> @@ -452,6 +453,9 @@ fate-h264-reinit-%:                               CMD = framecrc -i $(TARGET_SAM
>   
>   fate-h264-dts_5frames:                            CMD = probeframes $(TARGET_SAMPLES)/h264/dts_5frames.mkv
>   fate-h264-afd:                                    CMD = run ffprobe$(PROGSSUF)$(EXESUF) -bitexact -show_entries frame_side_data_list $(TARGET_SAMPLES)/h264/bbc2.sample.h264
> +fate-h264-no-cropping:                            CMD = run ffprobe$(PROGSSUF)$(EXESUF) -bitexact -apply_cropping 0 -show_entries stream=width,height,coded_width,coded_height \
> +                                                                                        -show_entries frame=width,height,crop_top,crop_bottom,crop_left,crop_right \
> +                                                                                        -of compact=p=0 -i $(TARGET_SAMPLES)/h264/bbc2.sample.h264

Will merge this test with the one above it as it uses the same sample 
and command line, and apply.

diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
index 173806861a..cd2ad79ea2 100644
--- a/tests/fate/h264.mak
+++ b/tests/fate/h264.mak
@@ -232,6 +232,7 @@  FATE_H264-$(call FRAMECRC, MOV, H264) += fate-h264-attachment-631
 FATE_H264-$(call FRAMECRC, MPEGTS, H264, H264_PARSER MP3_DECODER SCALE_FILTER ARESAMPLE_FILTER) += fate-h264-skip-nokey fate-h264-skip-nointra
 FATE_H264_FFPROBE-$(call DEMDEC, MATROSKA, H264) += fate-h264-dts_5frames
 FATE_H264_FFPROBE-$(call PARSERDEMDEC, H264, H264, H264) += fate-h264-afd
+FATE_H264_FFPROBE-$(call PARSERDEMDEC, H264, H264, H264) += fate-h264-no-cropping
 
 FATE_SAMPLES_AVCONV += $(FATE_H264-yes)
 FATE_SAMPLES_FFPROBE += $(FATE_H264_FFPROBE-yes)
@@ -452,6 +453,9 @@  fate-h264-reinit-%:                               CMD = framecrc -i $(TARGET_SAM
 
 fate-h264-dts_5frames:                            CMD = probeframes $(TARGET_SAMPLES)/h264/dts_5frames.mkv
 fate-h264-afd:                                    CMD = run ffprobe$(PROGSSUF)$(EXESUF) -bitexact -show_entries frame_side_data_list $(TARGET_SAMPLES)/h264/bbc2.sample.h264
+fate-h264-no-cropping:                            CMD = run ffprobe$(PROGSSUF)$(EXESUF) -bitexact -apply_cropping 0 -show_entries stream=width,height,coded_width,coded_height \
+                                                                                        -show_entries frame=width,height,crop_top,crop_bottom,crop_left,crop_right \
+                                                                                        -of compact=p=0 -i $(TARGET_SAMPLES)/h264/bbc2.sample.h264
 
 fate-h264-encparams: CMD = venc_data $(TARGET_SAMPLES)/h264-conformance/FRext/FRExt_MMCO4_Sony_B.264 0 1
 FATE_SAMPLES_DUMP_DATA += fate-h264-encparams
diff --git a/tests/ref/fate/h264-no-cropping b/tests/ref/fate/h264-no-cropping
new file mode 100644
index 0000000000..84669ab733
--- /dev/null
+++ b/tests/ref/fate/h264-no-cropping
@@ -0,0 +1,95 @@ 
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1088|crop_top=0|crop_bottom=8|crop_left=0|crop_right=0|
+
+width=1440|height=1080|coded_width=1440|coded_height=1088

[FFmpeg-devel] fate/h264: add a test disabling cropping

Checks

Commit Message

Comments

Patch