From patchwork Sun Apr 23 22:32:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 41304 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:dca6:b0:f3:34fa:f187 with SMTP id ky38csp1041093pzb; Sun, 23 Apr 2023 15:32:59 -0700 (PDT) X-Google-Smtp-Source: AKy350YdG3T4BKHf4C5FuuOvd6/ngZ/0iIjSls3XFMGZUGkL1UJSnxGqj7CMdLEYVrW7NSQRfU6J X-Received: by 2002:a17:906:7c41:b0:956:fdb6:bc77 with SMTP id g1-20020a1709067c4100b00956fdb6bc77mr8026704ejp.30.1682289178826; Sun, 23 Apr 2023 15:32:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682289178; cv=none; d=google.com; s=arc-20160816; b=goYvCUGszrjMiw2OooAaP4kWV69dgrnfwfLKldQKDUbluJTpWnqmEKWR3JRVFK43qe +NwqcPc0jtX369otNSiEbT+gNE8FanSwKvEOlcTpSc7FltV1XVpob+NF0WHy2mF6AwLH XiGgTvMGuZ84C69lIiObo01eW3JlZnyZJmlvgj1QTQvs0B5onKxurc264leERz0cncqa qgUMJt3u8EEstltDba6UsWlxGT7qBQev9yyNkXdq77bW88dylxUnzBy0eqjWR574tZjI 7wt8FTuqzJkDCwM0evgrf39AvkqvvpOWM8pPXkt2fdyvoY+P8PrbT7ClsJvTQS+vosTS osTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=NNkVJoLAo/XI8Lkl6c0jhaI+WkiIc7rffEX2R8DKVzE=; b=J0J/OKQBbbnjguYyjoICXJYecmpLnhV2s2Ku8SdBrD2Sqd9IG5YBhYMu1DCQrhr7rO ByFd6NgEtSiWLDU5MNkscU0wsiDjj7cJCuTX6MB9e39WoZPZDUUyAUtd1BNBLcqqZ4wh rhr0ne+hKwOSjx5/xaeZoKv8+aLjH+GVRKaylZUFCIAC16Uuc653E6eEiHLW4o3FYwRL uLASImLN4LIz3f0+fOxzYQJ2nG0jN8zerB8EGY4McTF76RFXQagCMlASPIXTZu20enYK ID32Ws5D9ByfPuKHAfihYtOr+YBEECccHm7rsmYwCB5QnvNefWB+E/ZQSNMOBixbxnKd jEjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t19-20020a17090616d300b0094f76af1aa7si6556219ejd.655.2023.04.23.15.32.58; Sun, 23 Apr 2023 15:32:58 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A898168BF78; Mon, 24 Apr 2023 01:32:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78F5268BA82 for ; Mon, 24 Apr 2023 01:32:39 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 8F6101BF205 for ; Sun, 23 Apr 2023 22:32:38 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 24 Apr 2023 00:32:32 +0200 Message-Id: <20230423223236.375-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230423223236.375-1-michael@niedermayer.cc> References: <20230423223236.375-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 2/6] avcodec/apedec: Move pointer instead of copying each element in delay in long_filter_high_3800() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: pEwaEktxFnGz ~1000 -> 930 cycles Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index c08d13d6c2..40cd78a991 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -944,7 +944,7 @@ static void long_filter_high_3800(int32_t *buffer, int order, int shift, int len { int i, j; int32_t dotprod, sign; - int32_t coeffs[256], delay[256]; + int32_t coeffs[256], delay[256+256], *delayp = delay; if (order >= length) return; @@ -956,13 +956,16 @@ static void long_filter_high_3800(int32_t *buffer, int order, int shift, int len dotprod = 0; sign = APESIGN(buffer[i]); for (j = 0; j < order; j++) { - dotprod += delay[j] * (unsigned)coeffs[j]; - coeffs[j] += ((delay[j] >> 31) | 1) * sign; + dotprod += delayp[j] * (unsigned)coeffs[j]; + coeffs[j] += ((delayp[j] >> 31) | 1) * sign; } buffer[i] -= (unsigned)(dotprod >> shift); - for (j = 0; j < order - 1; j++) - delay[j] = delay[j + 1]; - delay[order - 1] = buffer[i]; + delayp ++; + delayp[order - 1] = buffer[i]; + if (delayp - delay == 256) { + memcpy(delay, delayp, sizeof(*delay)*256); + delayp = delay; + } } }